Received-SPF: pass (google.com: domain of linux-kernel+bounces-33907-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4ffe1482-62b7-ebea-def5-9239320002be@arm.com>
Date: Mon, 22 Jan 2024 18:06:53 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v8 00/24] x86/resctrl: monitored closid+rmid together,
 separate arch/fs locking
Content-Language: en-GB
To: Carl Worth <carl@os.amperecomputing.com>, x86@kernel.org,
 linux-kernel@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com>,
 Reinette Chatre <reinette.chatre@intel.com>,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Borislav Petkov <bp@alien8.de>, H Peter Anvin <hpa@zytor.com>,
 Babu Moger <Babu.Moger@amd.com>, shameerali.kolothum.thodi@huawei.com,
 D Scott Phillips OS <scott@os.amperecomputing.com>, lcherian@marvell.com,
 bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com,
 baolin.wang@linux.alibaba.com, Jamie Iles <quic_jiles@quicinc.com>,
 Xin Hao <xhao@linux.alibaba.com>, peternewman@google.com,
 dfustini@baylibre.com, amitsinght@marvell.com
References: <20231215174343.13872-1-james.morse@arm.com>
 <874jg9rh7k.fsf@rasp.cworth.amperemail.amperecomputing.com>
From: James Morse <james.morse@arm.com>
In-Reply-To: <874jg9rh7k.fsf@rasp.cworth.amperemail.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Carl,

On 22/12/2023 22:43, Carl Worth wrote:
> James Morse <james.morse@arm.com> writes:
>> This series does two things, it changes resctrl to call resctrl_arch_rmid_read()
>> in a way that works for MPAM, and it separates the locking so that the arch code
>> and filesystem code don't have to share a mutex. I tried to split this as two
>> series, but these touch similar call sites, so it would create more work.
>>
>> (What's MPAM? See the cover letter of the first series. [1])
> 
> Thanks, James. This is really useful for us at Ampere since it enables
> the MPAM driver on top of this series.
> 
> I've tested this series on an Ampere implementation, by successfully
> using resctrl to configure and exercise MPAM functionality.

Great! Thanks for this.


> I can't
> speak to the effects of the refactor on x86 since I have not tested that
> all.

> For the series:
> Tested-by: Carl Worth <carl@os.amperecomputing.com>

Thanks, I'll add an "# arm64" on the end of that to preserve your above comment about not
testing this on x86.


Thanks,

James