Received-SPF: pass (google.com: domain of linux-kernel+bounces-33951-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 22 Jan 2024 18:15:07 +0000
From: Conor Dooley <conor@kernel.org>
To: marius.cristea@microchip.com
Cc: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
	jdelvare@suse.com, linux@roeck-us.net, linux-hwmon@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: adding support for PAC193X
Message-ID: <20240122-fernlike-resolute-b16772806147@spud>
References: <20240122084712.11507-1-marius.cristea@microchip.com>
 <20240122084712.11507-2-marius.cristea@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qi0TL78qGZaNp8GQ"
Content-Disposition: inline
In-Reply-To: <20240122084712.11507-2-marius.cristea@microchip.com>


--qi0TL78qGZaNp8GQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Marius,

On Mon, Jan 22, 2024 at 10:47:11AM +0200, marius.cristea@microchip.com wrot=
e:
> From: Marius Cristea <marius.cristea@microchip.com>
>=20
> This is the device tree schema for iio driver for
> Microchip PAC193X series of Power Monitors with Accumulator.
>=20
> Signed-off-by: Marius Cristea <marius.cristea@microchip.com>

I like how this is looking now. I have two minor comments that if you
resend for some other reason you could change, but otherwise:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> ---
>  .../bindings/iio/adc/microchip,pac1934.yaml   | 120 ++++++++++++++++++
>  1 file changed, 120 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/microchip,p=
ac1934.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.=
yaml b/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
> new file mode 100644
> index 000000000000..cd9cb2a71566
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/microchip,pac1934.yaml
> @@ -0,0 +1,120 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/microchip,pac1934.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PAC1934 Power Monitors with Accumulator
> +
> +maintainers:
> +  - Marius Cristea <marius.cristea@microchip.com>
> +
> +description: |
> +  This device is part of the Microchip family of Power Monitors with
> +  Accumulator.
> +  The datasheet for PAC1931, PAC1932, PAC1933 and PAC1934 can be found h=
ere:
> +    https://ww1.microchip.com/downloads/aemDocuments/documents/OTH/Produ=
ctDocuments/DataSheets/PAC1931-Family-Data-Sheet-DS20005850E.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,pac1931
> +      - microchip,pac1932
> +      - microchip,pac1933
> +      - microchip,pac1934
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  slow-io-gpios:
> +    description: |

This...

> +      A GPIO used to trigger a change is sampling rate (lowering the chi=
p power
> +      consumption). If configured in SLOW mode, if this pin is forced hi=
gh,
> +      sampling rate is forced to eight samples/second. When it is forced=
 low,
> +      the sampling rate is 1024 samples/second unless a different sample=
 rate
> +      has been programmed.
> +
> +patternProperties:
> +  "^channel@[1-4]+$":
> +    type: object
> +    $ref: adc.yaml
> +    description: |

=2E..and this...

> +        Represents the external channels which are connected to the ADC.
> +
> +    properties:
> +      reg:
> +        items:
> +          minimum: 1
> +          maximum: 4
> +
> +      shunt-resistor-micro-ohms:
> +        description: |

=2E..and this | are not needed here as you have no formatting to preserve.

> +          Value in micro Ohms of the shunt resistor connected between
> +          the SENSE+ and SENSE- inputs, across which the current is meas=
ured.
> +          Value is needed to compute the scaling of the measured current.
> +
> +    required:
> +      - reg
> +      - shunt-resistor-micro-ohms
> +
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells =3D <1>;
> +        #size-cells =3D <0>;
> +
> +        pac193x: power-monitor@10 {

This "pac193x" label is not used and should be removed.

Thanks,
Conor.

> +            compatible =3D "microchip,pac1934";
> +            reg =3D <0x10>;
> +
> +            #address-cells =3D <1>;
> +            #size-cells =3D <0>;
> +
> +            channel@1 {
> +                reg =3D <0x1>;
> +                shunt-resistor-micro-ohms =3D <24900000>;
> +                label =3D "CPU";
> +            };
> +
> +            channel@2 {
> +                reg =3D <0x2>;
> +                shunt-resistor-micro-ohms =3D <49900000>;
> +                label =3D "GPU";
> +            };
> +
> +            channel@3 {
> +                reg =3D <0x3>;
> +                shunt-resistor-micro-ohms =3D <75000000>;
> +                label =3D "MEM";
> +                bipolar;
> +            };
> +
> +            channel@4 {
> +                reg =3D <0x4>;
> +                shunt-resistor-micro-ohms =3D <100000000>;
> +                label =3D "NET";
> +                bipolar;
> +            };
> +        };
> +    };
> +
> +...
> --=20
> 2.34.1
>=20

--qi0TL78qGZaNp8GQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZa6wqwAKCRB4tDGHoIJi
0q6hAP0QD1uLecPK8JtF9dahFAlvXtAIK2MF/bEG/+d2xCVPwAD+NitieK6tvevt
VhVPZLPjU6FN4abGu0j2yODLo75rmQg=
=CcoM
-----END PGP SIGNATURE-----

--qi0TL78qGZaNp8GQ--