Received-SPF: pass (google.com: domain of linux-kernel+bounces-33956-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <bfa5104f-b887-4cc4-a24c-0497b86d9dde@intel.com>
Date: Mon, 22 Jan 2024 10:18:01 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] x86/resctrl: Implement new mba_MBps throttling
 heuristic
Content-Language: en-US
To: "Luck, Tony" <tony.luck@intel.com>, "Yu, Fenghua" <fenghua.yu@intel.com>,
	Peter Newman <peternewman@google.com>, "x86@kernel.org" <x86@kernel.org>
CC: James Morse <james.morse@arm.com>, Jamie Iles <quic_jiles@quicinc.com>,
	Babu Moger <babu.moger@amd.com>, "Shen, Xiaochen" <xiaochen.shen@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231201214737.104444-1-tony.luck@intel.com>
 <20240118214213.59596-1-tony.luck@intel.com>
 <45d2891e-989a-45c9-a527-8b14ff5f8748@intel.com>
 <SJ1PR11MB60837D4884419BDC2DCAA2D2FC752@SJ1PR11MB6083.namprd11.prod.outlook.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB60837D4884419BDC2DCAA2D2FC752@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHFNd2pKbC85eTlQbFdiQndxeGUzdlJER3BIY01GSlkxV3BwbVJMTVRsMk0x?=
 =?utf-8?B?TVlRSXpPMlFVWDZhV1IxSTdGeG1teTBpZkMvMWdWWG5scVlkNUQyRkdMRkFv?=
 =?utf-8?B?elQrQitOWDF4cElNVDRpT2FxU2poZEhCQU42dXMrYUc5bTlleUZUaTErTC9F?=
 =?utf-8?B?VWpyTnF0bnZUYmVMeXlqWTY3Mkl3QkxqbkVicWhuZnRBVzl3Tm9uR0trc0Nn?=
 =?utf-8?B?RUVuWTlOVTNzYkVxdlVzdThBMEIrSkRuWVNHcURwZEF0U2R0RDNDbGFIdjRa?=
 =?utf-8?B?M045ZnYzRGRuaWd1WG9TbHV0RktzeUdnUVVId1FEaENkVDdzNEJ5ZzR2bFhr?=
 =?utf-8?B?YlpkY2YzVG9OTnBnTlhkTEkxU3BDNTlZRVhoL2xSMmZNRHdTeUpBaDhuMFZJ?=
 =?utf-8?B?b0tzb01UK2xTKzJZL2EvSFBlRk91bzdBenJFdGFXSHc3Y1M4MWlieks0VFph?=
 =?utf-8?B?bVZ1eFk0QmNrdW5sZE0zYk9iaWkrUWNLNWRra2xwRTVRd0djZzBYaUlLa2VH?=
 =?utf-8?B?WGp3djhhUVBMQnFsWjJvV01tbCtHTWZlSkhCS0MwdDVDWjNMaTdVcVdTSlNN?=
 =?utf-8?B?M3RmZ1k1L09vbEJQSlNBQ0Z0K0Zkam8rbytXc2NRbHB6dG1yYkNpMDVwYUF4?=
 =?utf-8?B?cFpDd3Y3U2orY240R1hmZmJyM01TUENuUFFxSzYrYXllQWd3TnFCRVlGRG9I?=
 =?utf-8?B?QUtEaGhGYmdPWFlQTGdvcVFsV0tvcENDR3daNlFBVzFYdURHcTdJYktkdSt0?=
 =?utf-8?B?ZmhCZnFRLytnaDZtU2IwN3ROME90cE5mYmd2NFcraFZKcDJmWFcwRzlDYXh2?=
 =?utf-8?B?YkxnUzA3N0lpQnFyM1JERy9iVHV0VHlSV0N3OTRsdUpCSHdBajFKcFlHUGVW?=
 =?utf-8?B?QlF6R0NHamN6TWhGTWVEcUJxc1lDQVJyZytQNENKKzg4NldJYjl4TFNHaUZs?=
 =?utf-8?B?Z1pjaEtvYnVJZ0RNUUgzdG1WbDlPYm0xeThZZ2FwbXppSDFGaEdhdHV4Vmxl?=
 =?utf-8?B?RzhzWEVwdm9mRU5yT09xbnpQV1RrWlVhaitnOWdwVHRja2MzNEhwOUpkMHUw?=
 =?utf-8?B?Q3I2L2JUTnlOOXpOL20xZ1JMV0tYb0Mwa0ovUUtzQndncGdBd3QyaitjMTkz?=
 =?utf-8?B?aG0ydk5DTzVyVmY4YkFFYWdHNXNLSU5VRFV4SWpNMFFhazhwTjlEU3dPUDQv?=
 =?utf-8?B?N01IQ0dDeks4QWZUSzdxZ0ZyWUxTaWdzbUdabXYyY0p3SkhvSkw4OWdvbVpx?=
 =?utf-8?B?YjBDdlZaMlBnSnJqVFJRY2U2SUNUV05kVTJYbklmV3d1NjZOQmFWNjJpR1N2?=
 =?utf-8?B?WlY2NGErWXl3SUZ6a05TMGpCQ2F0QlZsS1hGQVhLMGpMaEdTUjIvT1k0NGVh?=
 =?utf-8?B?eGx4V0s4b3hUN05yRm5BRm1TUmRPTCs4U3pCT25MNFJGeWU0OEVZSHB0SXFi?=
 =?utf-8?B?djFrdndUL0s4V1F4aHp6dndYdE1oNUxGRjJVRnAvbktuRDNyYkd4Z1FId0Vq?=
 =?utf-8?B?aGFlSmRrUmIwaGwrbkt5Vmpob0ttUXA0Qmo0QUdMNFF4YTVHMHVCVjNxWlIz?=
 =?utf-8?B?RFZiZENjUEpoalpzT25kWWNxZ2hmNmZsNzdFNElPTUZVQ25TcDJkYXpWT1Rp?=
 =?utf-8?B?cWlidkh1eUpUaVJ3VHdXQjJUejlNcHFJWkY3VXk0MUFqT3NsZWlxNGdkb1ZJ?=
 =?utf-8?B?U0o4UDN4V3VyU2dMS280dmFCMWtwblhqOG5BN2JwKytQb0FNMHRSYUd2Sksr?=
 =?utf-8?B?ejc1Y0RPYllTOHBORVhybVRuVjJsMXZ4cFZqVWYxamt5ZjF3cjZreUQ3MWVW?=
 =?utf-8?B?M3kvOGRtdHJNQ1p0Q3N0bVUzWCtmNGVsSk9aVmMyd1JLMDdVZWxMemVLbEtH?=
 =?utf-8?B?bGZBYi92YVhxYjBGUzZlRlFBakYrREFha0s3M1g0RW8xbVh5aGNKU3dZdm1o?=
 =?utf-8?B?VUovSURjaGxLd1hUT1BBbllkMmE3bzFQRHRUK09pYWdwTmJ6M2Fnb3kyOS92?=
 =?utf-8?B?V2RyYjBhRzcrcFl2NG9HVU5OZ0ZPYzlDU2l4eFZiaDA4UUNzN000S0wrSVFN?=
 =?utf-8?B?bU1QbUVUQktSMnBIZFZ2cU1xSDlNdUZwUmlNZEpENE9xZHZzeG5WTnRxWEYv?=
 =?utf-8?B?aGlLbmpNbUI4MnNqWkh4OFh3OWY4aVN5YzN0MVZYU3ZvbjcwZFpvVGtaTWh4?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e5cca21f-1445-428f-86d6-08dc1b767946
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 18:18:03.6181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tVZwmtOXGfbs0tjiw0HYL91g5ZhzocvaovCXx2qF21tg0QmPop7527HjmHss9VlIhTj8fskVGG3uRYEQYg3Wz8pOgncd3fjvjsE2hI5KrKg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4778
X-OriginatorOrg: intel.com

Hi Tony,

On 1/22/2024 10:07 AM, Luck, Tony wrote:
>> I am sorry Tony, this reverse-fir breakage slipped through. I only noticed it after
>> trying to see how best to present all the pending work to x86 maintainers. Could
>> you please send a fixup with this addressed? After that I am planning to propose its
>> inclusion among all the other pending resctrl fixes followed by the SNC work. The SNC
>> work will need a rebase starting with this snippet, unless you see an easier way forward?
> 
> Reinette,
> 
> Thanks for catching this. I can send v3 of this patch right away (just fixing fir tree order only
> needs a compile test, not extensive regression tests).

Thank you very much Tony.

> 
> What are "all the other pending resctrl" fixes?  Since the SNC series is invasive to so many
> files & functions, I'll need to re-base SNC on top of everything else that's happening this
> cycle.

The fixes I have as pending are:

[PATCH v2] x86/resctrl: Fix unused variable warning in cache_alloc_hsw_probe()
	https://lore.kernel.org/lkml/ZULCd%2FTGJL9Dmncf@agluck-desk3/

[PATCH v5 1/2] x86/resctrl: Remove hard-coded memory bandwidth limit
	https://lore.kernel.org/lkml/c26a8ca79d399ed076cf8bf2e9fbc58048808289.1705359148.git.babu.moger@amd.com/

[PATCH v5 2/2] x86/resctrl: Read supported bandwidth sources using CPUID command
	https://lore.kernel.org/lkml/669896fa512c7451319fa5ca2fdb6f7e015b5635.1705359148.git.babu.moger@amd.com/

[PATCH v3] x86/resctrl: Implement new mba_MBps throttling heuristic
	https://lore.kernel.org/lkml/20240122180807.70518-1-tony.luck@intel.com/


Reinette