Received-SPF: pass (google.com: domain of linux-kernel+bounces-34065-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <233ad4e5-4439-4c85-96e6-6d55ec2622ac@kernel.org>
Date: Mon, 22 Jan 2024 12:41:41 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND net-next 2/2] net/ipv6: resolve warning in
 ip6_fib.c
Content-Language: en-US
To: Breno Leitao <leitao@debian.org>, weiwan@google.com, kuba@kernel.org,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>
Cc: leit@meta.com, "open list:NETWORKING [IPv4/IPv6]"
 <netdev@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>
References: <20240122181955.2391676-1-leitao@debian.org>
 <20240122181955.2391676-2-leitao@debian.org>
From: David Ahern <dsahern@kernel.org>
In-Reply-To: <20240122181955.2391676-2-leitao@debian.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 1/22/24 11:19 AM, Breno Leitao wrote:
> In some configurations, the 'iter' variable in function
> fib6_repair_tree() is unused, resulting the following warning when
> compiled with W=1.
> 
>     net/ipv6/ip6_fib.c:1781:6: warning: variable 'iter' set but not used [-Wunused-but-set-variable]
>      1781 |         int iter = 0;
> 	  |             ^
> 
> It is unclear what is the advantage of this RT6_TRACE() macro[1], since
> users can control pr_debug() in runtime, which is better than at
> compilation time. pr_debug() has no overhead when disabled.
> 
> Remove the RT6_TRACE() in favor of simple pr_debug() helpers.
> 
> [1] Link: https://lore.kernel.org/all/ZZwSEJv2HgI0cD4J@gmail.com/
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
>  include/net/ip6_fib.h |  6 ------
>  net/ipv6/ip6_fib.c    | 15 +++++++++------
>  net/ipv6/route.c      |  8 ++++----
>  3 files changed, 13 insertions(+), 16 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>