Received-SPF: pass (google.com: domain of linux-kernel+bounces-34083-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 22 Jan 2024 21:45:57 +0200
Message-Id: <CYLHS5HX5TXF.1CD2QEVLGTHI0@suppilovahvero>
Cc: "David Howells" <dhowells@redhat.com>, "Eric Biggers"
 <ebiggers@kernel.org>, <keyrings@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] keys: update key quotas in key_put()
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Luis Henriques" <lhenriques@suse.de>
References: <2744563.1702303367@warthog.procyon.org.uk>
 <20240115120300.27606-1-lhenriques@suse.de>
 <CYIZP2D9FS0N.1XY2F5VX9STEY@seitikki> <87il3llh8s.fsf@suse.de>
In-Reply-To: <87il3llh8s.fsf@suse.de>

On Mon Jan 22, 2024 at 1:50 PM EET, Luis Henriques wrote:
> "Jarkko Sakkinen" <jarkko@kernel.org> writes:
>
> > On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
> >> Delaying key quotas update when key's refcount reaches 0 in key_put() =
has
> >> been causing some issues in fscrypt testing.  This patches fixes this =
test
> >                                                 ~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~
> > 						This commit fixes the test
> >
> >> flakiness by dealing with the quotas immediately, but leaving all the =
other
> >> clean-ups to the key garbage collector.  Unfortunately, this means tha=
t we
> >> also need to switch to the irq-version of the spinlock that protects q=
uota.
> >
> > The commit message fails to describe the implementation changes.
> >
> > You have a motivation paragraph but you also need to add implementation
> > paragraph, which describes how the code changes reflect the motivation.
>
> Thank you for your feedback, Jarkko.  I'll address your comments in v3.
>
> But before sending another rev, I'll wait a bit more, maybe David also ha=
s
> some feedback on the implementation.
>
> Cheers,

Take you time :-)=20

BR, Jarkko