Received-SPF: pass (google.com: domain of linux-kernel+bounces-34045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240122175204.2371009-1-samuel.holland@sifive.com>
In-Reply-To: <20240122175204.2371009-1-samuel.holland@sifive.com>
From: Sami Tolvanen <samitolvanen@google.com>
Date: Mon, 22 Jan 2024 11:21:04 -0800
Message-ID: <CABCJKueoq-5vMTtWjiDqeMqt3SHM6bfcGyKUO1k7Uu+EN+LyxQ@mail.gmail.com>
Subject: Re: [PATCH] scs: add CONFIG_MMU dependency for vfree_atomic()
To: Samuel Holland <samuel.holland@sifive.com>
Cc: Will Deacon <will@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Samuel,

On Mon, Jan 22, 2024 at 9:52=E2=80=AFAM Samuel Holland
<samuel.holland@sifive.com> wrote:
>
> The shadow call stack implementation fails to build without CONFIG_MMU:
>
>   ld.lld: error: undefined symbol: vfree_atomic
>   >>> referenced by scs.c
>   >>>               kernel/scs.o:(scs_free) in archive vmlinux.a
>
> Fixes: a2abe7cbd8fe ("scs: switch to vmapped shadow stacks")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
>  arch/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/Kconfig b/arch/Kconfig
> index c91917b50873..a5af0edd3eb8 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -673,6 +673,7 @@ config SHADOW_CALL_STACK
>         bool "Shadow Call Stack"
>         depends on ARCH_SUPPORTS_SHADOW_CALL_STACK
>         depends on DYNAMIC_FTRACE_WITH_ARGS || DYNAMIC_FTRACE_WITH_REGS |=
| !FUNCTION_GRAPH_TRACER
> +       depends on MMU
>         help
>           This option enables the compiler's Shadow Call Stack, which
>           uses a shadow stack to protect function return addresses from

Looks good to me. Thanks for the patch!

Reviewed-by: Sami Tolvanen <samitolvanen@google.com>

Sami