Received-SPF: pass (google.com: domain of linux-kernel+bounces-34064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 22 Jan 2024 19:40:51 +0000
From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Seven Lee <wtli@nuvoton.com>, lgirdwood@gmail.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	conor+dt@kernel.org, YHCHuang@nuvoton.com, KCHSU0@nuvoton.com,
	CTLIN0@nuvoton.com, SJLIN0@nuvoton.com, scott6986@gmail.com,
	supercraig0719@gmail.com, dardar923@gmail.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"
Message-ID: <04945799-eded-42f9-b8fa-8907be44c400@sirena.org.uk>
References: <20240122095650.60523-1-wtli@nuvoton.com>
 <20240122-daunting-woof-19fac5689bb2@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cJlmuN7wD9uJzDfe"
Content-Disposition: inline
In-Reply-To: <20240122-daunting-woof-19fac5689bb2@spud>


--cJlmuN7wD9uJzDfe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:

> > +    enum:
> > +      - 0 # VDDA
> > +      - 1 # VDDA*1.5/1.8V
> > +      - 2 # VDDA*1.6/1.8V
> > +      - 3 # VDDA*1.7/1.8V

> I would also rather than this enum was used to have sensible values for
> the enum itself (which I suppose means strings here), rather than the
> register values. Seeing "nuvoton,dac-vref = <2>" in a devicetree is not
> very meaningful IMO.

Do you have a concrete suggestion for how to more clearly write these
directly?

--cJlmuN7wD9uJzDfe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWuxMIACgkQJNaLcl1U
h9A9wgf9GwcA7Ig0ZhctUzcIuOgFXg+HVs2fAzHGak6ySbki+9ticBmi6pSE85Ss
VawLZpUX9H/Gp2cV7U/PV81ax0MHTrvo1QWWmSoS+3BBHxgqCIHMNrM1houNIxle
YrH2Sq3AKOSs8QHUPF7YQu4VuJV7bOCH5C7FaAIXhVNu3l6iwpz4cBXN7Ta49+9Y
qVYxl0hq+Rk4FCA/7idB0c6I+Xahcz9oQ6YAk+vLkVASFAqgPiY+EDundI2abdW0
P3DwApDBdBjH/fYSf8WAu4x/R1VLvSKMj9gZBbYZdBnsM+u0kyx/0o9C1Lgg/iav
WYCEFzYB3Q/cJxIvQi6YFEwLBvty3w==
=l5dE
-----END PGP SIGNATURE-----

--cJlmuN7wD9uJzDfe--