Received-SPF: pass (google.com: domain of linux-kernel+bounces-34102-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 22 Jan 2024 12:10:36 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>, Qinkun Bao <qinkun@google.com>,
	Samuel Ortiz <sameo@rivosinc.com>, "Lu, Ken" <ken.lu@intel.com>
CC: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>, "linux-coco@lists.linux.dev"
	<linux-coco@lists.linux.dev>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 3/4] tsm: Allow for mapping RTMRs to TCG TPM PCRs
Message-ID: <65aecbbce09dd_107423294b7@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240114223532.290550-1-sameo@rivosinc.com>
 <20240114223532.290550-4-sameo@rivosinc.com>
 <1bbf8d3e-aa94-48c7-a1e4-76f9eefc4af7@linux.intel.com>
 <65a72c305291f_3b8e29484@dwillia2-xfh.jf.intel.com.notmuch>
 <5539c533-37b2-4b12-a5c5-056881cf8e3c@linux.intel.com>
 <Za1G9I+tYuIL9ser@vermeer>
 <CF3D8DE1-AD47-4A77-B8BD-8A12A6F7E9DB@google.com>
 <MW4PR11MB5872F46A2089C8C2D8EF7A008C752@MW4PR11MB5872.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <MW4PR11MB5872F46A2089C8C2D8EF7A008C752@MW4PR11MB5872.namprd11.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkZFWWJra3cwS01ocllXRGM3NWpNOFBndG9TWVNRdXlQQkd6YmFxb09sS0dq?=
 =?utf-8?B?TVRiNExaNEQ0Z3FzcXdybU01VkYxY2FuWG9xUmkyNWw5UndLZ3JuM3VOQ2tt?=
 =?utf-8?B?ajlIZUNmZDZDeXNRVk5mNU1BNnZBcGUwbTlUNmRidjdIRm82UC9PbkQ0N1pl?=
 =?utf-8?B?V3hrakthMGFWekVrSzFLeGViWENnY1lEa29yckJhQnFXTW43ZmVJOE80SGJF?=
 =?utf-8?B?a3BDNHQwa0tTVlJMMzVmamhkYzhVRmsvbnFCTHBGSlUwWE9ReWYvbDlvZTBz?=
 =?utf-8?B?U0FReC9kYWZrd01USy91cVFrVFoxQ25NZ0FIVnc5QVdkbXhjNzJzdlppYWx0?=
 =?utf-8?B?NEkydEtGU0Z0SGFTaTZQaGhXVHB3UVN5a2NxcTBhR2RnQUFBNENuUEVsRy9C?=
 =?utf-8?B?TmVmVCtHNmwwZFVWWjJzRU9vaWx4UlFVTlp6czd4bjg0UjJxblBMdDR0OW9D?=
 =?utf-8?B?c2hZUFZibGZtSUZ4TG84MWZLWGp5OEtqdGVWazV3ZzM1SklmT2ZSbEZhM1lB?=
 =?utf-8?B?b3JLc0lCNGhKOVV2dURtQ0dIbUF0TDZsMjNKYk1ack15c1M1NU5jbEQydmhG?=
 =?utf-8?B?SkhVY2RGZFMxZ2VRbkYrSFovNmFSRjRIQ256d0twVzlnNTdYcDU1aVpwT0hP?=
 =?utf-8?B?SXhuQjZQdEVmeUd3LzdJWjlLbjdIUE1oclozSGd3Mi9WVEdWQUdPR1hTYS8y?=
 =?utf-8?B?SEtvcXlZU2RaTUJMNkNCdEpTOHNPOStPdWNBYWhwMWRsYjhUTDBkSkFPNjR5?=
 =?utf-8?B?cG9EblJaQXFyaVBwclVlcmt3TXpYVHMxMmkveXhXOWFjVkpnNXFQK2taV2pw?=
 =?utf-8?B?RHJyc2pPMGY0bmJSTzJ4dW1LTm40U080UkJKclRDZUg3bVQyLyt4SElZTm9E?=
 =?utf-8?B?WDUydU8zOFR4S2lxbzlKT3MxL0pHMmNPTEZ0NWJGc2hxS3ZEZks0djlQZ3JG?=
 =?utf-8?B?bjNSK29udFpnMExzemFyeXVac204NFdwcGhlSzV3cG81WWVyMFBHY2tmNENp?=
 =?utf-8?B?cGk5ZlJJaWpzdnNxZVZUMit3R2FRUnk1VWFaNTRtSTBLQnlGZmQxOE8xMk1m?=
 =?utf-8?B?bDlxbUcvMlMvR0gwNTBZclpETk9WcFdabW8yMjloblNuNC9JTlVJT09rVzFL?=
 =?utf-8?B?MnQ2RnlQUW1VR25qMEVoRVJ3NDExR1pKNjVFSUl2VUNFWXhyUUhXVmNiRlBv?=
 =?utf-8?B?UFlIbTdaU2JFRUZuNXFuUVhUeDQ1bDM4aElUMDJSeVdpeG9TYmEwWmd6Yjdi?=
 =?utf-8?B?SUp1czZab2VpcDFjbzZNQzFKUFRNNkN0R0t6cDVmV0pEdWY2Q016ZHVRODBQ?=
 =?utf-8?B?NjJ1OXk3OVZKTVozMDM1eXh3TFo2UVNxSTlHaGVWZWNkUTd3ME5LcGo0RHYz?=
 =?utf-8?B?S1Fvc0c2dGVFK2srdU5KUEJtbEo4OXU1aUh3bUZEdjJ2a1JjOUI4bHk1UXky?=
 =?utf-8?B?b2Y0SzlyRTViWVFFdHJaNHVZdnR0QnZuWmc2akVaWnN3NENDbWVOdjk0Ni9k?=
 =?utf-8?B?Tzg5QzRObVZQVm9CUDZJd1ozQkQwc05JU3ZkZUEwTkdTVFZaVGthbHEvUmJS?=
 =?utf-8?B?bWx3Ti9OQkZQdVFrQjVBZ0Z4bXFRT09PdlJKZGlkUU9BNzFBWWFmU2YvcGVz?=
 =?utf-8?B?RWZJb3dJSjh4Ymp3NHgyV2hOVWZwbVMrT3QxeEtrWFJoblM5UVNYdk56eFE0?=
 =?utf-8?B?YWljcTg1elVxTTBMenM4dnI2NXFwWi9zZy9zQUl6dHFWejcxOEEvam9GRWJn?=
 =?utf-8?B?ckFabFhpaU5TcFF4c0xHd2ZWb1lmcEhsVUJnYUxWdDJaNHBDL1RMbE1zalM0?=
 =?utf-8?B?dWFUNWNTUEltU3NnUUladEtOYjV1T3NDMjNrbm1zZjBRWG0vLzY1WGRHMmNP?=
 =?utf-8?B?dUppbXI2dVRWcWJQWGhmQm5iMzhhcjZqbWRReWQ5Qm9RNk9maG9KSHgya2Zn?=
 =?utf-8?B?cEd0R0MxQldkV014TjlrQVE4d1Y4Wjk4MGRBVVJzcXd5S3dsOUJvek5LQmpt?=
 =?utf-8?B?aTBaeGJpUmdCaENuOW5ieVA2ek0wTG5uVlNZeFdJdTRZd0JCYzE4dmJ5T01r?=
 =?utf-8?B?dWswTGFSNEZLUHcyTmUwZXhJVEdvK1U1aEF5d3pUQ2Z2Mk9lbjVNa3dvQ3N2?=
 =?utf-8?B?bThOY0FFSVdzS2g0YlVFcGlZV2FRZzJKYW1BMU81aEIvSjd3bFV3bllDb2g2?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 89822853-1d64-409e-e4b0-08dc1b8633f5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 20:10:39.2053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K/DUdVE21pOqMkq/ZUz5T0mWmnyZmcpfoABMJsQo67wYyd7VfoMeBPd0uv/fc78yc15HfishO0jdIgQir34KuhmriJu3k7f+hR3gNRu0ryI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7906
X-OriginatorOrg: intel.com

Yao, Jiewen wrote:
> Comment below:
> 
> > -----Original Message-----
> > From: Qinkun Bao <qinkun@google.com>
> > Sent: Monday, January 22, 2024 10:13 AM
> > To: Samuel Ortiz <sameo@rivosinc.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> > Lu, Ken <ken.lu@intel.com>
> > Cc: Kuppuswamy Sathyanarayanan
> > <sathyanarayanan.kuppuswamy@linux.intel.com>; Williams, Dan J
> > <dan.j.williams@intel.com>; linux-coco@lists.linux.dev; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [RFC PATCH v1 3/4] tsm: Allow for mapping RTMRs to TCG TPM PCRs
> > 
> > 
> > 
> > > On Jan 21, 2024, at 8:31 AM, Samuel Ortiz <sameo@rivosinc.com> wrote:
> > >
> > > On Tue, Jan 16, 2024 at 07:35:30PM -0800, Kuppuswamy Sathyanarayanan
> > wrote:
> > >>
> > >> On 1/16/24 5:24 PM, Dan Williams wrote:
> > >>> Kuppuswamy Sathyanarayanan wrote:
> > >>>> On 1/14/24 2:35 PM, Samuel Ortiz wrote:
> > >>>>> Many user space and internal kernel subsystems (e.g. the Linux IMA)
> > >>>>> expect a Root of Trust for Storage (RTS) that allows for extending
> > >>>>> and reading measurement registers that are compatible with the TCG TPM
> > >>>>> PCRs layout, e.g. a TPM. In order to allow those components to
> > >>>>> alternatively use a platform TSM as their RTS, a TVM could map the
> > >>>>> available RTMRs to one or more TCG TPM PCRs. Once configured, those
> > PCR
> > >>>>> to RTMR mappings give the kernel TSM layer all the necessary information
> > >>>>> to be a RTS for e.g. the Linux IMA or any other components that expects
> > >>>>> a TCG compliant TPM PCRs layout.
> > >>>>>
> > >>>>> TPM PCR mappings are configured through configfs:
> > >>>>>
> > >>>>> // Create and configure 2 RTMRs
> > >>>>> mkdir /sys/kernel/config/tsm/rtmrs/rtmr0
> > >>>>> mkdir /sys/kernel/config/tsm/rtmrs/rtmr1
> > >>>>> echo 0 > /sys/kernel/config/tsm/rtmrs/rtmr0/index
> > >>>>> echo 1 > /sys/kernel/config/tsm/rtmrs/rtmr1/index
> > >>>>>
> > >>>>> // Map RTMR 0 to PCRs 4, 5, 6, 7 and 8
> > >>>>> echo 4-8 > /sys/kernel/config/tsm/rtmrs/rtmr0/tcg_map
> > >>>>>
> > >>>>> // Map RTMR 1 to PCRs 16, 17 and 18
> > >>>>> echo 16-18 > /sys/kernel/config/tsm/rtmrs/rtmr1/tcg_map
> > >>>> Any information on how this mapping will be used by TPM or IMA ?
> > >>>>
> > >>>> RTMR to PCR mapping is fixed by design, right? If yes, why allow
> > >>>> user to configure it. We can let vendor drivers to configure it, right?
> > >>> I assume the "vendor driver", that publishes the RTMR to the tsm-core,
> > >>> has no idea whether they will be used for PCR emulation, or not. The TPM
> > >>> proxy layer sitting on top of this would know the mapping of which RTMRs
> > >>> are recording a transcript of which PCR extend events.
> > >>
> > >> My thinking is, since this mapping is ARCH-specific information
> > >> and fixed by design, it makes more sense to hide this detail in the
> > >> vendor driver than letting userspace configure it. If we allow users to
> > >> configure it, there is a chance for incorrect mapping.
> > >
> > > I think I agree with the fact that letting users configure that mapping
> > > may be error prone. But I'm not sure this is an architecture specific
> > > mapping, but rather a platform specific one. I'd expect the guest firmware
> > > to provide it through e.g. the MapPcrToMrIndex EFI CC protocol.
> > >
> > > So I agree I should remove the user interface for setting that mapping,
> > > and pass it from the provider capabilities instead. It is then up to the
> > > provider to choose how it'd build that information (hard coded, from
> > > EFI, etc).
> > 
> > The UEFI specification has defined the mapping relationship between the
> > TDX RTMR and TPM PCRs (See
> > https://uefi.org/specs/UEFI/2.10/38_Confidential_Computing.html#intel-trust-
> > domain-extension). The current RTMR implementation in the boot loader
> > is “hooked” in the implementation for the TPM.
> > 
> > When the bootloader needs to extend the PCR value, it calls
> > `map_pcr_to_mr_index`  to retrieve the corresponding RTMR index and
> > then extends the RTMR. Considering this behavior, I don’t think we should
> > allow users to configure the mappings between the PCR and RTMR. (See
> > https://github.com/rhboot/shim/pull/485/files).
> > 
> > Add Jiewen (owner of the RTMR changes in the firmware) and Ken (
> > owner of the RTMR changes in the boot loader) for the visibility.
> 
> I think the mapping should be static and determined by the hardware architecture.
> 
> Allowing user to configure the mapping just adds complexity and
> confusing. For example, the user must understand clearly on what is
> Intel-TDX/AMD-SEV/ARM-CCA/RISCV-CoVE, how many registers they have,
> what is the best way to map it.
> 
> It also adds complexity to the verifier. For example, the verifier
> must understand how a user configure the mapping, then get the
> expected measurement register value.

I agree with this, what I have a problem with is that this:

https://uefi.org/specs/UEFI/2.10/38_Confidential_Computing.html#intel-trust-domain-extension

..is vendor specific, especially when the kernel enabling is being
targeted as cross-vendor.

So, yes, the mapping should be allowed to specified by the low-level
driver, but at the same time every vendor should not reinvent their own
enumeration method when we have EFI for that.

In other words Linux should enforce unification across vendors and
consider waiting until the RTMR enumeration is promoted out of the
vendor specific section to a cross vendor standard.