Received-SPF: pass (google.com: domain of linux-kernel+bounces-34154-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Feedback-ID: i47b949f6:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b
Precedence: bulk
MIME-Version: 1.0
Message-Id: <efebd848-c952-41f8-9422-fe2235d92259@app.fastmail.com>
In-Reply-To: <20240117104448.6852-1-arnd@kernel.org>
References: <20240117104448.6852-1-arnd@kernel.org>
Date: Mon, 22 Jan 2024 21:50:56 +0100
From: "Janne Grunau" <j@jannau.net>
To: "Arnd Bergmann" <arnd@kernel.org>,
 "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
 =?UTF-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
Cc: asahi@lists.linux.dev, "Hector Martin" <marcan@marcan.st>,
 "Arnd Bergmann" <arnd@arndb.de>, "Sven Peter" <sven@svenpeter.dev>,
 "Asahi Lina" <lina@asahilina.net>, dri-devel@lists.freedesktop.org,
 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: apple: mark local functions static
Content-Type: text/plain

Hej,

On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With linux-6.8, the kernel warns about functions that have no
> extern declaration, so mark both of these static.
>
> Fixes: 2d782b0d007d ("gpu: drm: apple: Add sound mode parsing")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This is for the bits/200-dcp branch in https://github.com/AsahiLinux/linux,
> the code is not yet upstream.
> ---
>  drivers/gpu/drm/apple/parser.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/apple/parser.c 
> b/drivers/gpu/drm/apple/parser.c
> index 44aad9a64f9a..ea9f40bb7de2 100644
> --- a/drivers/gpu/drm/apple/parser.c
> +++ b/drivers/gpu/drm/apple/parser.c
> @@ -694,7 +694,7 @@ int parse_epic_service_init(struct dcp_parse_ctx 
> *handle, const char **name,
>  	return ret;
>  }
> 
> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int 
> *ratebit)
> +static int parse_sample_rate_bit(struct dcp_parse_ctx *handle, 
> unsigned int *ratebit)
>  {
>  	s64 rate;
>  	int ret = parse_int(handle, &rate);
> @@ -715,7 +715,7 @@ int parse_sample_rate_bit(struct dcp_parse_ctx 
> *handle, unsigned int *ratebit)
>  	return 0;
>  }
> 
> -int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit)
> +static int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit)
>  {
>  	s64 sample_size;
>  	int ret = parse_int(handle, &sample_size);

thanks, patch included in my dev branch and will be in the next pull request I'll send to Hector.

I suppose the recipients are generated by an automated get_maintainers.pl invocation. Is that desired for out of tree drivers?

best regards,
Janne