Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp96589rdb; Mon, 22 Jan 2024 13:11:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGY2j//sY5SK86HjXJkIDE+e+MX6P8rtix36mJs80o2Wk4kwm+w45t1UMDrxIoGcJUJJnv+ X-Received: by 2002:a17:906:6046:b0:a28:e4d3:7b1a with SMTP id p6-20020a170906604600b00a28e4d37b1amr1601634ejj.154.1705957862923; Mon, 22 Jan 2024 13:11:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705957862; cv=pass; d=google.com; s=arc-20160816; b=yYkJsMBi4hV6k+FCCmiCvJbzSyjgHCSrRJcUX2X+Y0F86ti4+vBIOONSf5leffZY3K yM4/eFy7Kt9LJOHlgYaXavcqPABeszWQj9fsVXBZyiHp1PhuD9/mRYAMCdqC2Re/3Ig9 BxWrhqAOfqbkkqiB7vsRYd2QQeV3J1PtkS3HHH+1EVvTaL2FvoCFaWutn/Y/KSRe8b9Y NSnuHQ6iDunbFNH/xlLX+I+M6OODSy7vacCB1BQAr0J3fxiyfEhSPDxima0IhrVUS07v 31nu9aXHLjtBovrOZHVLXqh41xrMt3MhhXvbPFOlrMrmzjnVw4sfooIIjs6ojwgLrGkV 8+wQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=QQuxlIZQ7Oogvx0qykRNuSzmJ0WSw6if2F8B62AR6b4=; fh=PwHwmSk8jPhMJCVDaM6ZrhypswvrcBCc8Iua+haqWVQ=; b=sT0z6pvtqlbpjcC/6LuRfrhu74A6dVUp1R1Ah0Pj2HgE9kRSVG73Gdtlr3pir0jCNi cD5E15VSOF2goYdru0SEMSi1By3wznAQ1MRySCtUMiTt0z93OmJL0rbJUWkfmQfg5fZz 86iYANsJJNBIdsQ54wOfzXyH7sUyhtEvMp7D9G4hL0SCt2dFfh5eg+4v7F4cnvBRWUwA dDkTAsX0zreA1+H+8obEVEv5iPVEDuQJ9EaMYTku0nXWVcdqitxwOj+2L8sekD/IMpZF 0L8IMYhnra95GkvA/DZcWE1/sZzYGrVpTI8hxBtiRNo6b931d2heTaToAzbpiwzquEVj 4r8g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5wjLa6g; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-34171-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34171-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b9-20020a1709063f8900b00a2c8e69ded3si10443480ejj.994.2024.01.22.13.11.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 13:11:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34171-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L5wjLa6g; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-34171-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34171-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AA6631F2945C for ; Mon, 22 Jan 2024 21:11:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DFC5D47F64; Mon, 22 Jan 2024 21:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L5wjLa6g" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 151CF481A1; Mon, 22 Jan 2024 21:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705957852; cv=none; b=Xxfq/V8eY5q5/AtfuN9pfP6FUalxJYoJNzyIaDxcsZapIrNlCCEhGmuKD3tLrKgYm/qt0ZsKHkzMlDsfLpPfdT+GeYV/K4MyIsOOKeya8rmTnBRF3hZzaoax3LS2Y2DveBz6blcPALynA0+MTLk41ixwU667k1gAQpQjoo/bdpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705957852; c=relaxed/simple; bh=TDViGXXDF62YHlJpIBlrEc0F5ODj676gbujRwRqKUtY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dDqAOgtaqVrWTddbT1JaD5GuEKeu3re4NSiaNt4VCzpGedNOyX9f9vPTgksQ6xyL2kWONRp6MUbtopKvuiEuolovB4O6KaXY/JuijCL7YKbkR6AtVrKzvx2bVf9dO/gnXyUO1ihLToBXWFlahb+tp20IkseBoLzkcvXO6kyYF6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L5wjLa6g; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F1D7C43390; Mon, 22 Jan 2024 21:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705957851; bh=TDViGXXDF62YHlJpIBlrEc0F5ODj676gbujRwRqKUtY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L5wjLa6gOcizqQtkvIgi2lycdDBDD1WQZBJR5QPDfYTBF5FHJKR4h3z+x1XnyxSHf +gBBIrzMsUiibgEP7xUUXakoEbnrzasfK6DPRix7wfJbcGjoFHTHoqZWdHohsyMOfB //BfYKXdio7Px8XckjFam7Ko0P2jas24o/UI4r93TPzx5Xxpaf8GtEvlU7ORdwWS/8 XoP4MYf+9KdSUYqMQzqPHazQK4/W7Fvn2R8i5lYJZzTrHWImGB0ANygxK16vYvn/nN TS2OegnnyGrOMjjuhhj4S9BKTfpC6IEDUCjWRx5S/ZBaUzMPme2C61S4+102pwecXi Hn3fMN+zHurKw== Date: Mon, 22 Jan 2024 21:10:46 +0000 From: Simon Horman To: Zhipeng Lu Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Piotr Marczak , Alice Michael , Jeff Kirsher , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i40e: fix a memleak in i40e_init_recovery_mode Message-ID: <20240122211046.GK126470@kernel.org> References: <20240122173633.3843715-1-alexious@zju.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122173633.3843715-1-alexious@zju.edu.cn> On Tue, Jan 23, 2024 at 01:36:33AM +0800, Zhipeng Lu wrote: > In i40e_init_recovery_mode, pf->vsi is allocated without free, causing > a memleak. This patch adds deallocation operations for pf->vsi in each > and every error-handling paths after pf->vsi's. > > Fixes: 4ff0ee1af016 ("i40e: Introduce recovery mode support") > Signed-off-by: Zhipeng Lu Reviewed-by: Simon Horman