Received-SPF: pass (google.com: domain of linux-kernel+bounces-34122-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Namhyung Kim <namhyung@kernel.org>
To: peterz@infradead.org,
	mark.rutland@arm.com,
	linux-kernel@vger.kernel.org,
	mingo@redhat.com,
	linux-perf-users@vger.kernel.org,
	irogers@google.com,
	alexander.shishkin@linux.intel.com,
	jolsa@kernel.org,
	Yang Jihong <yangjihong1@huawei.com>,
	adrian.hunter@intel.com,
	acme@kernel.org
Subject: Re: [PATCH] perf build: Check whether pkg-config is installed when libtraceevent is linked
Date: Mon, 22 Jan 2024 12:36:36 -0800
Message-ID: <170595558511.377262.16675125413548801604.b4-ty@kernel.org>
In-Reply-To: <20240112034019.3558584-1-yangjihong1@huawei.com>
References: <20240112034019.3558584-1-yangjihong1@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Fri, 12 Jan 2024 03:40:19 +0000, Yang Jihong wrote:
> If pkg-config is not installed when libtraceevent is linked, the build fails.
> 
> The error information is as follows:
> 
>   $ make
>   <SNIP>
>   In file included from /home/yjh/projects_linux/perf-tool-next/linux/tools/perf/util/evsel.c:43:
>   /home/yjh/projects_linux/perf-tool-next/linux/tools/perf/util/trace-event.h:149:62: error: operator '&&' has no right operand
>     149 | #if defined(LIBTRACEEVENT_VERSION) &&  LIBTRACEEVENT_VERSION >= MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
>         |                                                              ^~
>   error: command '/usr/bin/gcc' failed with exit code 1
>   cp: cannot stat 'python_ext_build/lib/perf*.so': No such file or directory
>   make[2]: *** [Makefile.perf:668: python/perf.cpython-310-x86_64-linux-gnu.so] Error 1
>   make[2]: *** Waiting for unfinished jobs....
> 
> [...]

Applied to perf-tools-next, thanks!

Thanks,
Namhyung