Received-SPF: pass (google.com: domain of linux-kernel+bounces-34237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 22 Jan 2024 23:31:30 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>,
	Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>, linux-kernel@vger.kernel.org,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH] tick-sched: fix idle and iowait sleeptime accounting vs
 CPU hotplug
Message-ID: <Za7swp31JRzGJwzS@pavilion.home>
References: <20240115163555.1004144-1-hca@linux.ibm.com>
 <0928660b39aea2828a79a87fef57447e657d43b4.camel@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0928660b39aea2828a79a87fef57447e657d43b4.camel@linux.intel.com>

Le Mon, Jan 22, 2024 at 10:19:30AM -0800, Tim Chen a ?crit :
> On Mon, 2024-01-15 at 17:35 +0100, Heiko Carstens wrote:
> > 
> >  
> > +	idle_sleeptime = ts->idle_sleeptime;
> > +	iowait_sleeptime = ts->iowait_sleeptime;
> >  	memset(ts, 0, sizeof(*ts));
> > +	ts->idle_sleeptime = idle_sleeptime;
> > +	ts->iowait_sleeptime = iowait_sleeptime;
> >  }
> 
> Should idle_calls and idle_sleeps be preserved and
> restored too? ?
> 
> Seems like if we preserve the
> idle_sleeptime, and wish to compute the average
> sleep time per sleep, we will need to know the value of
> idle_sleeps that's also preserved across CPU offline/online.

I guess those can be saved as well. Would you like to send the patch?

Thanks.

> 
> Tim