Received-SPF: pass (google.com: domain of linux-kernel+bounces-34283-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Jan 2024 00:05:26 +0100
From: David Sterba <dsterba@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Sterba <dsterba@suse.com>, Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] Btrfs fixes for 6.8-rc2
Message-ID: <20240122230526.GF31555@twin.jikos.cz>
Reply-To: dsterba@suse.cz
References: <cover.1705946889.git.dsterba@suse.com>
 <CAHk-=wgHDYsNm7CG3szZUotcNqE_w+ojcF+JG88gn5px7uNs0Q@mail.gmail.com>
 <CAHk-=wiroGW6OMrPXrFg8mxYJa+362XJTsD5HkHXUHffcMieAA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHk-=wiroGW6OMrPXrFg8mxYJa+362XJTsD5HkHXUHffcMieAA@mail.gmail.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Mon, Jan 22, 2024 at 02:54:31PM -0800, Linus Torvalds wrote:
> On Mon, 22 Jan 2024 at 14:34, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Bah. These fixes are garbage. Now my machine doesn't even boot. I'm
> > bisecting

Ah, sorry.

> My bisection says
> 
>    1e7f6def8b2370ecefb54b3c8f390ff894b0c51b is the first bad commit

We got a report today [1] that this commit is indeed bad,

https://lore.kernel.org/linux-btrfs/CABq1_vj4GpUeZpVG49OHCo-3sdbe2-2ROcu_xDvUG-6-5zPRXg@mail.gmail.com/

the timing was also unfortuate and too late to recall the pull request.

> but I'll still have to verify by testing the revert on top of my current tree.
> 
> It did revert cleanly, but I also note that if the zstd case is wrong,
> I assume the other very similar commits (for zlib and lzo) are
> potentially also wrong.
> 
> Let me reboot to verify that at least my machine boots.

Per the report revert makes it work again and zlib and lzo cases are not
affected.

I can send a pull request reverting all the three until we figure out
what's wrong, or you can do it as all revert cleanly.