Received-SPF: pass (google.com: domain of linux-kernel+bounces-34306-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Dan Martins <dan.martins@zoho.com>
To: ray.huang@amd.com, rafael@kernel.org,
 Mario Limonciello <mario.limonciello@amd.com>
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, Mario Limonciello <mario.limonciello@amd.com>,
 stable@vger.kernel.org, wkarny@gmail.com
Subject:
 Re: [PATCH] cpufreq/amd-pstate: Fix setting scaling max/min freq values
Date: Mon, 22 Jan 2024 18:52:50 -0500
Message-ID: <2263414.iZASKD2KPV@draconyx>
In-Reply-To: <20240119113319.54158-1-mario.limonciello@amd.com>
References: <20240119113319.54158-1-mario.limonciello@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Feedback-ID: rr08011228c4d23cc6ead3bea5099e72db00006c4b3724f29c5bbc477d7a2934471d3702b533a5981206e5b5fa:zu08011226df8b965205c05624cf8859df00007b21fe0c0d763776009e3f1d295e05561023dfd195a9276a:rf080112325c1086f76a58161ee12f58e20000555e5ba39e401679e75548f003e1e0d0261abcd215cdd5ba042258c9479ffa77968a1c7b:ZohoMail

On Friday, January 19, 2024 6:33:19 A.M. EST Mario Limonciello wrote:
> Scaling min/max freq values were being cached and lagging a setting
> each time.  Fix the ordering of the clamp call to ensure they work.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217931
> Cc: stable@vger.kernel.org
> Cc: wkarny@gmail.com
> Fixes: febab20caeba ("cpufreq/amd-pstate: Fix scaling_min_freq and
> scaling_max_freq update") Signed-off-by: Mario Limonciello
> <mario.limonciello@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 1f6186475715..1791d37fbc53 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1232,14 +1232,13 @@ static void amd_pstate_epp_update_limit(struct
> cpufreq_policy *policy) max_limit_perf = div_u64(policy->max *
> cpudata->highest_perf, cpudata->max_freq); min_limit_perf =
> div_u64(policy->min * cpudata->highest_perf, cpudata->max_freq);
> 
> +	WRITE_ONCE(cpudata->max_limit_perf, max_limit_perf);
> +	WRITE_ONCE(cpudata->min_limit_perf, min_limit_perf);
> +
>  	max_perf = clamp_t(unsigned long, max_perf, cpudata-
>min_limit_perf,
>  			cpudata->max_limit_perf);
>  	min_perf = clamp_t(unsigned long, min_perf, cpudata-
>min_limit_perf,
>  			cpudata->max_limit_perf);
> -
> -	WRITE_ONCE(cpudata->max_limit_perf, max_limit_perf);
> -	WRITE_ONCE(cpudata->min_limit_perf, min_limit_perf);
> -
>  	value = READ_ONCE(cpudata->cppc_req_cached);
> 
>  	if (cpudata->policy == CPUFREQ_POLICY_PERFORMANCE)

Tested-by: Dan Martins <dan.martins@zoho.com>