Received-SPF: pass (google.com: domain of linux-kernel+bounces-34297-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d6b7203d11aac2d83ddcd181f05a6074388d32d4.camel@linux.intel.com>
Subject: Re: [PATCH] tick-sched: fix idle and iowait sleeptime accounting vs
 CPU hotplug
From: Tim Chen <tim.c.chen@linux.intel.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Heiko Carstens <hca@linux.ibm.com>, Thomas Gleixner
 <tglx@linutronix.de>,  Ingo Molnar <mingo@kernel.org>, Gerald Schaefer
 <gerald.schaefer@linux.ibm.com>, Alexander Gordeev
 <agordeev@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, 
 linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Date: Mon, 22 Jan 2024 15:33:27 -0800
In-Reply-To: <Za7swp31JRzGJwzS@pavilion.home>
References: <20240115163555.1004144-1-hca@linux.ibm.com>
	 <0928660b39aea2828a79a87fef57447e657d43b4.camel@linux.intel.com>
	 <Za7swp31JRzGJwzS@pavilion.home>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-01-22 at 23:31 +0100, Frederic Weisbecker wrote:
> Le Mon, Jan 22, 2024 at 10:19:30AM -0800, Tim Chen a =C3=A9crit :
> > On Mon, 2024-01-15 at 17:35 +0100, Heiko Carstens wrote:
> > >=20
> > > =20
> > > +	idle_sleeptime =3D ts->idle_sleeptime;
> > > +	iowait_sleeptime =3D ts->iowait_sleeptime;
> > >  	memset(ts, 0, sizeof(*ts));
> > > +	ts->idle_sleeptime =3D idle_sleeptime;
> > > +	ts->iowait_sleeptime =3D iowait_sleeptime;
> > >  }
> >=20
> > Should idle_calls and idle_sleeps be preserved and
> > restored too? =C2=A0
> >=20
> > Seems like if we preserve the
> > idle_sleeptime, and wish to compute the average
> > sleep time per sleep, we will need to know the value of
> > idle_sleeps that's also preserved across CPU offline/online.
>=20
> I guess those can be saved as well. Would you like to send the patch?
>=20

Okay, sent the patch in a separate email.

Tim