Received-SPF: pass (google.com: domain of linux-kernel+bounces-34673-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 22 Jan 2024 22:19:06 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mmap: introduce vma_range_init()
Message-ID: <20240123031906.pwbjuzdpl6hqiptj@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Yajun Deng <yajun.deng@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
References: <20240111021526.3461825-1-yajun.deng@linux.dev>
 <20240122220031.pwiravglee7o7k34@revolver>
 <20240122154031.b710f834b14d9027176f439a@linux-foundation.org>
 <20240123001830.glqdmrv2qc56zfpc@revolver>
 <2a1d6a9b-f486-44c8-6d1d-e6bab4dc3ced@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2a1d6a9b-f486-44c8-6d1d-e6bab4dc3ced@linux.dev>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?qoCeT732zWXWDbV+DNCW4W60LVOjC8IEN439bMpWcDIWAOos+yvELGLKJUWd?=
 =?us-ascii?Q?T7v5zgmcMu4Xx/dkgvfsihW+3ohRyMp76gZBv8hxvl1guwkAjv5NWI884kEY?=
 =?us-ascii?Q?5eBDBMCyKGkbjx3nDo3WJfbz28qU1u+e5CzFUfovpa4z6sEsx/eXc/Fzxc2Y?=
 =?us-ascii?Q?Pm3lIqRzIe0n5btZzSb6ggvOU5p4fnsTPGe36u8ndrRl0LXc6yU+t0N+5uK8?=
 =?us-ascii?Q?6iPIwtZ0T8QoxKxffBoucBQND9a4VpXLh2gg/92H9K15ZzEg42jKqQ6Sn9xQ?=
 =?us-ascii?Q?Yc+0mW55hSFcKLbndGy9y7LtRmGj3/uzA0jTpyffLFmOuibGOlGPdm7cn+xC?=
 =?us-ascii?Q?xfdsYRIG09DnhFFUC/ARJ9Nh0slWnrMmiu0CEk1iRsenG7i99L0B+tnl6Ysj?=
 =?us-ascii?Q?G/VhWrj/SnFjhJnfV2ppyoQF6YZpGOgFU6DZXI5FQhrjoJO8qVJEPf+MQkAG?=
 =?us-ascii?Q?lI4ODTn17nukhgd2s5hOvE/Dku1denP3Jjgcyh251ny2OIeTZNZNKHh/7w0/?=
 =?us-ascii?Q?LRhu/zFLjHEy+mikYnBMTlMJBTRpm8RspjvjNd2AMIUCwyHbseNK1Gk/pXY9?=
 =?us-ascii?Q?wU8mhyHX8G3nC5vsZBFqw5fkK/ZEMpKhjA30SMRUc5+0gCypuLDEE6Hd94V1?=
 =?us-ascii?Q?N8CDUqn3HKv2TOm9lFZBqdM+8ArTm3tsoNw7nREuVE45fzqajRSwblJsq/Lw?=
 =?us-ascii?Q?3ZG8es90QHWaNKNghYu0iYZMKSXGWhHdQ1ghIZHzR6hLaQ02nUaFRhwNve0V?=
 =?us-ascii?Q?5pt3yqVryFoe4nmjLI0vx7Qu8VKY0PWbS5mC3pIdKKK3MRLrKefco495pPWA?=
 =?us-ascii?Q?o0FAa8iYDV20bTvxEGDV7KEYaXWc8OKV9VmuvC/8ExmH+cGz9ebE9DEsZuR/?=
 =?us-ascii?Q?ndygViLuYBT+QthIgJ26c3E1JKMgMza/NRYyvfdcbG7K/Z4+sGo8wk7CG89o?=
 =?us-ascii?Q?FuiRBisTIH8kA8ZgJmKcBlBxQe8TMpsRMJj15xZr/QK4Q0t3NN/j/f8mMCbQ?=
 =?us-ascii?Q?DDzl+ESGGKAIOw3URJm8jXOkBS4ZmRZ8Enm9Y13czI0R9iV+Lm5fLqVMvWHm?=
 =?us-ascii?Q?PCNB/AAobHCQaqJLQG8lmqI8cNRn7LdHg1inr5UqvhnYrxYauFjNIwIoqMOv?=
 =?us-ascii?Q?6WBmqlvs+uRKW8p6Zr8CYHtxIVVUWQ50aYtbF3pL1eWW4fxY2+hNoZYNdNJF?=
 =?us-ascii?Q?1zy07Y48rea1Aox+W0XVXpHDzG5GZ67Q+nv/XlsVYsS8PZXrPk7TNkvJGDqT?=
 =?us-ascii?Q?9eCqW2d99tzVRjjSM2pSIgHhwBtTbDKWHtOWg/rmy0HDijn5DxxOjDeAbJ7q?=
 =?us-ascii?Q?PjDpNy2WLTfq5rhdRkqOtVsGugD7kRuPQ2D+NZQlp8SpimWR9KZ1YKXcaJpC?=
 =?us-ascii?Q?r0g4MlF3sdkK/oOaQs0pLw2qUx+QpU3myUEH2UtzkOYNPHIjUXHa9a/Klbki?=
 =?us-ascii?Q?Thy9DmJNOUL5hivvb2QuH6Rjs4W1UJ+4qAPsCRy/KVm7OA2TcBrxMi1DcB5Q?=
 =?us-ascii?Q?pPWKqNF2UYcA1IGxLzXPHkZaPR1NBvRPkw78FpXSr9mQG7u+HoVtK/CH8yIQ?=
 =?us-ascii?Q?LCbnEJTT2j8CN1OaVBy1NW0OdX1SfAOpiLkw6s7i?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	5p806tWECKOOgp1HZ2MHPJvE62GVYLMGlCUXNK8UvlGRQn0NAfobigUMVk6ew67zJ2EJyigeqh9bci6WrvcXxn4tVf/z24QXiAwsytpUienQRMuasixXLA/29BWwUqXFTDxCyiNE8bQ50qWYObhY+Jo+vVM4RAyH1CGijzOY89uQ2raoiUb5HTQFa4Ky83zgqm4Ttet4bKLQ0MzS50NazW8uMtxSCpuWFWIQlOMPp8l0FXj1DGmZnSOqRXSc2OKRDO6yLuRuWyf97EotX//rm8QoPLeysWElA4KHbKDrwOjFmtW6/RpSENJ2df58dd/jgMfRzy7KNAqgLhdHyDIZ6ZhfCUoI5hyBP25aaNaAb1NQlKnwewg1WcFmHm1roznL1X21cLR5g1N9MBV3i70OuKXr4N5QAHoRNuSi5dbgLiBnaGvBr3nxH63eaG/k3aJ92C2LSlZjilrTi/6zCjt9e00fdy/ghRE2hhleFs7SmU1zX3gM12r6GH8YWuIHRrZtXNyVnDx5vLc4Pi6A1awk6Z7SHHTov+63NRQu+pnJgc26NEQSbz3UDIDUGkvSz/VWe2F8oQGBZsyMTfmerhRrYwTQh5PSxpCaIgrwgmdncIA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af9e1759-67b4-4301-b4ef-08dc1bc20fa0
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 03:19:08.0495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zi2IWU85mFDJU0yzSa2o4yGn13lNGOZ3rRsJmV8RBsnarsdSXsHG5HuZZZvYKWyIMFIOaPSbElfAwZG1hb74AQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5019
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-22_12,2024-01-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401230021
X-Proofpoint-ORIG-GUID: 2dg9c8bsfBlkbovXV01qx73vqDnU8bOk
X-Proofpoint-GUID: 2dg9c8bsfBlkbovXV01qx73vqDnU8bOk

* Yajun Deng <yajun.deng@linux.dev> [240122 21:23]:
> 
> On 2024/1/23 08:18, Liam R. Howlett wrote:
> > * Andrew Morton <akpm@linux-foundation.org> [240122 18:40]:
> > > On Mon, 22 Jan 2024 17:00:31 -0500 "Liam R. Howlett" <Liam.Howlett@Oracle.com> wrote:
> > > 
> > > > * Yajun Deng <yajun.deng@linux.dev> [240110 21:15]:
> > > > > There is a lot of code needs to set the range of vma, introduce
> > > > > vma_range_init() to initialize the range of vma.
> > > > > 
> > > > > Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> > > > > ---
> > > > >   include/linux/mm.h |  9 +++++++++
> > > > >   mm/mmap.c          | 29 +++++++----------------------
> > > > >   2 files changed, 16 insertions(+), 22 deletions(-)
> > > > This isn't a whole lot of code, are there others?  We're losing code
> > > > clarity in favour of saving 6 lines?
> > > > 
> > > Oh.  I thought it was a nice cleanup which made things more clear.
> > I'm not totally against it; that's why I suggested the changes below. I
> > think a name change would go a long way for clarity. It's not as much as
> > I though it would be though.
> > 
> > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > > > > index f5a97dec5169..abb4534be3cc 100644
> > > > > --- a/include/linux/mm.h
> > > > > +++ b/include/linux/mm.h
> > > > > @@ -3516,6 +3516,15 @@ static inline bool range_in_vma(struct vm_area_struct *vma,
> > > > >   	return (vma && vma->vm_start <= start && end <= vma->vm_end);
> > > > >   }
> > > > > +static inline void vma_range_init(struct vm_area_struct *vma,
> > > > Any reason this can't be in mm/internal.h ?
> > > That would be good.
> > One other thing, do we trust this to be inlined correctly by the
> > compiler or should this be __always_inline?  I'd expect it to be okay as
> > it is, but I've been proven wrong in a perf trace before..
> > 
> 
> Okay, I would take __always_inline and put it in mm/internal.h in v2.

I'm not confident in this suggestion as the rest.
Please rename the function when you move it.

> 
> > > > vma_range_set(), vma_set_range(), or just vma_range() might be a better
> > > > name?  My thinking is that some of these are actually modifying the vma
> > > > and not just initializing it, right?
> > > I'd vote for vma_set_range().
                      ^  This part, use vma_set_range() please.

> > Using vma_set_range() leaves vma_range() or vma_size(), which could be
> > added for the calculations of vma->vm_end - vma->vm_start.  Davidlohr
> > suggested such a beast a few years ago, but that one would need to live
> > in the include/linux/mm.h as it occurs a lot more.
> > 
> > $ git grep "vma->vm_end - vma->vm_start" | wc -l
> > 198
> > 
> > .. for just those named vma.
> > 
>