Received-SPF: pass (google.com: domain of linux-kernel+bounces-34703-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3ce78854-e941-47e5-933e-38b18d5203d9@infradead.org>
Date: Mon, 22 Jan 2024 20:16:49 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 46/47] tty: vt: fix up kernel-doc
Content-Language: en-US
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240122110401.7289-1-jirislaby@kernel.org>
 <20240122110401.7289-47-jirislaby@kernel.org>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240122110401.7289-47-jirislaby@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 1/22/24 03:04, Jiri Slaby (SUSE) wrote:
> selection.c and vt.c still uses tabs in the kernel-doc. This misrenders the
> functions in the output -- sphinx misinterprets the description. So
> remove these tabs, incl. those around dashes.
> 
> 'enum' keyword is needed before enum names. Fix that.
> 
> Superfluous \n after the comments are also removed. They are not
> completely faulty, but this unifies all the kernel-doc in the files.
> 
> Finally fix up the cross references.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/tty/vt/selection.c | 30 ++++++-------
>  drivers/tty/vt/vt.c        | 86 +++++++++++++++++++-------------------
>  include/linux/console.h    |  6 +--
>  3 files changed, 62 insertions(+), 60 deletions(-)
> 

-- 
#Randy