Received-SPF: pass (google.com: domain of linux-kernel+bounces-34816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 23 Jan 2024 12:45:59 +0530
From: Vinod Koul <vkoul@kernel.org>
To: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
	yung-chuan.liao@linux.intel.com,
	pierre-louis.bossart@linux.intel.com, Basavaraj.Hiregoudar@amd.com,
	Sunil-kumar.Dommati@amd.com, vinod.koul@intel.com,
	venkataprasad.potturu@amd.com,
	Sanyog Kale <sanyog.r.kale@intel.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 03/13] drivers: soundwire: amd: refactor amd soundwire
 manager device node creation
Message-ID: <Za9nrtvDtCT_SLzY@matsya>
References: <20240110094416.853610-1-Vijendar.Mukunda@amd.com>
 <20240110094416.853610-4-Vijendar.Mukunda@amd.com>
 <Za4f1rwAXAiJU-j5@matsya>
 <d8f5ee8b-466e-4069-b06b-41cdc7fa9e40@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d8f5ee8b-466e-4069-b06b-41cdc7fa9e40@amd.com>

On 22-01-24, 17:18, Mukunda,Vijendar wrote:
> On 22/01/24 13:27, Vinod Koul wrote:
> > On 10-01-24, 15:14, Vijendar Mukunda wrote:

> >
> >> + * @count: link count
> >> + * @num_slaves: total number of devices exposed across all enabled links
> > should this be not per link?
> No, this will be total count of peripheral devices across all the links.
> This variable will be used in? snd_soc_acpi_sdw_link_slaves_found()
> API.

yeah noticed later

> >
> >> + * @link_mask: bit-wise mask listing SoundWire links reported by the
> >> + * Controller
> >> + * @ids: array of slave_id, representing Slaves exposed across all enabled
> >> + * links
> > this does not tell us which device to expect in which link..?
> sdw_extended_slave_id structure contains information about link id as well.

ok

-- 
~Vinod