Received-SPF: pass (google.com: domain of linux-kernel+bounces-34877-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1c36c4bc-b3ad-4a8a-834d-241d424dbe65@prevas.dk>
Date: Tue, 23 Jan 2024 09:14:20 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 03/82] overflow: Introduce add_wrap()
Content-Language: en-US, da
To: Kees Cook <keescook@chromium.org>, linux-hardening@vger.kernel.org
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
 Bill Wendling <morbo@google.com>, Justin Stitt <justinstitt@google.com>,
 linux-kernel@vger.kernel.org
References: <20240122235208.work.748-kees@kernel.org>
 <20240123002814.1396804-3-keescook@chromium.org>
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
In-Reply-To: <20240123002814.1396804-3-keescook@chromium.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UWs4V0JlM2l5QzFJNUZzbXFHMi94aVBoUFA3cWlzN0tzdWYrMU1zdDlIQXpo?=
 =?utf-8?B?ZE0wSTMrY0k1cmJZcGNnVHFlL21jdERDSE90OC9WVkUzUmFoL081TFdUbHhh?=
 =?utf-8?B?cmtJZ21Ub1VuNWtUc3pvbHBmb3g4ZnJFcHR1aU9rU2x0NTRIZ0VMemdQSkFt?=
 =?utf-8?B?cW5EK25ONlltK1dzUjRaNTJBOVh4c1Z3NTBXb2ZMTTZBeG9RV3dLQVRvbVVJ?=
 =?utf-8?B?emdvVjNPVWVTUWQ2TmpOUFlNd0VRbmI4R05IUFVyQW1LKzdzQnJoRXMvaStJ?=
 =?utf-8?B?T1BKT3BDdXdTM0hpWk82YlhDMmpnQnJFbWdjTkcyeTdtcklEREd2NFFEMzJO?=
 =?utf-8?B?RXQvOXhiQzMyRnRleWZvbEFRaFYvSkRxQ1JTNlZXWTVVS1Zndm5VZjNxQTZE?=
 =?utf-8?B?VW1PMFZIVk1XZnE4VDVQeDdnMHBrSzlnTG9ndmxvemI1ZVYrSnZNSjcwckN0?=
 =?utf-8?B?OUU1RUwvMzF5NFkzc1dxMjJRbHJ3MUNFa2sxK1dUUzFBV2Q1c3AzeG9GVWMw?=
 =?utf-8?B?WGVEUlJrcUw1Z2lzVlJrZEFoOUlpaUtJVnNEZjFsRnQwNzl5aDBxei90Rytt?=
 =?utf-8?B?bnVaUG1raCtGOFZQd3JPK0xkSEp3bFNQMXJ5NmFjL3ZhNzBnZzdkSzE0N0Q4?=
 =?utf-8?B?OGJHZ0lJQ2pLRk1xVDh0UFYrQjB2dFVJK1BlNlRZbkk5aHl5R3dUVDNvaTla?=
 =?utf-8?B?dlJkNWJkSVRjRXZTckpBRDVDK3lzRVdUbjh2TWV4TUt1RXdpN2xKUmZIdFVJ?=
 =?utf-8?B?MmpEM0JyNjJJdE5TWTdsaVV3QUtYcEhZQ1crYlpWV1EvVXlZU3lSZmFYaGt3?=
 =?utf-8?B?SHhSaFNzUUZJQkZ1eGRNelZtYkVwSFVnN3BsOFRuVlYyVit3cTN1amZkRHBO?=
 =?utf-8?B?bXRTNm9YWUk2REwvU204K1BsUER2QlQ3MzM5Q2V3N0VWM0pVd1ZKZ3MxZzBm?=
 =?utf-8?B?UWFHcVpyTkY4MWR2bjlWOTlVcVhQeDZKMmFWalV2YlRaQWFvVTk4Uk9IZzA5?=
 =?utf-8?B?QjhTdUZPKytYTk1QeUgzNnF1eFpTSitLNGJJRHBZdTFtT0tsbzVscVk4dy9C?=
 =?utf-8?B?clBiSS9WSk1yeWhHYXBZV2gxVGVXZ0p1dWNlLzRxU2M2YWY5VWdEeC8zRjVW?=
 =?utf-8?B?UExNajdtUnQvZ1lLaWF5TkRUNHZKRWE2cG1rdWpUY2Fnb0QrR1YwQmRWZGpS?=
 =?utf-8?B?all0ZnFJOVJ0RlY5WnI5SDU1M0Fibit2d211T25scjE1UVFKQmZMWlU3OWhI?=
 =?utf-8?B?MzE3blBNalV6MjUxUUYvUFhvMm5wOXE3TWhLc2hMWkpVbFp6T1cyTkF0Smh6?=
 =?utf-8?B?UktTWGQ4U2tKcjU3QU9yQjFoRU5IbU9KaDdIY2RhVEwvRTE2dzBWb252OXVi?=
 =?utf-8?B?aG1Ld2hEVEFtM3ljZHVZODZnVzgyalNNbkVYZHp1M3liOXVpVVJMVlVPaW56?=
 =?utf-8?B?TTRtUVplRDVoNUtVb0h0aDVEektNWGg1Y3BqbjhnWER6eXhpN3RYUkRZQ2JH?=
 =?utf-8?B?OG55YjdCaENXQ2JYWTl3dDE5Z25aUWw1M2E4aFJuL0dyaG5sSzFBWURMODNE?=
 =?utf-8?B?LzJXUXJaQkpxc0JMNDJLK21STmlEYkRjaSsrTEUwcW82QllLbWR5b29Jcm9W?=
 =?utf-8?B?TUd0N2JOUXBBbWtmNXVJeVFrYnA1ZVZYMXBpTW0wVE9HMGZtWG5IdVlzMWsy?=
 =?utf-8?B?bEZ5c1N2dS9HMlY3WEV0eXhNdTYwK0laK1lZUURxRGFmNkxJVE1hRTlmbk41?=
 =?utf-8?B?b0ZVeHpFOUtjL0pydUNVTFRodE9WcGJxdFc2cU13K2JqbTJvaGdyaVFsWXkw?=
 =?utf-8?B?Z2FIVGd0M3BQSWUyeVhzelBaZW1VZmxJV1hPaFRwQlpMb1ZQNWk4NHpaRXdQ?=
 =?utf-8?B?akNVRDFhRVZQd2JuZ29DYUFwc3c4d2xhdm5zZisyVWFtL1NQKzMrSnhtVVpq?=
 =?utf-8?B?RG5NRnFxYzdPdEQvRmNyVUFqcTVMTWJMemNyeTh3Zk56ZEJxSEJ5ZUdSMEhK?=
 =?utf-8?B?dTBQM2ltRmprYjZIWGNnYy8wMTYrbFgvUmY1TDMxOXkwcGRqY2EvNEdQbm5o?=
 =?utf-8?B?cnR2NTVCekVrN1J1S2VWUVpkVHRWLzAwZFNQMkU1TjN4WTZXSFRYQ1licUg5?=
 =?utf-8?B?MUptZkxlUDYwblRRQUNqSmpoTkNXOUhPc1FTc2kvdWtSb3d4dStuL055QlY5?=
 =?utf-8?B?Nmc9PQ==?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: d1243bf1-2642-4d97-e767-08dc1beb4ea2
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB7100.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 08:14:23.1392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +fseUI4hGjws2pDInFtwExmIV4KCmcLFNGFI+dnhNxqBNBaPM4ih7N4u3biYeMApFSbtjxPAES/D2YBxuP467LY5sw721GYkEp68j+cQCfw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR10MB6617

On 23/01/2024 01.26, Kees Cook wrote:
> Provide a helper that will perform wrapping addition without tripping
> the arithmetic wrap-around sanitizers.
> 
> Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
> Cc: linux-hardening@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  include/linux/overflow.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/include/linux/overflow.h b/include/linux/overflow.h
> index ac088f73e0fd..30779905a77a 100644
> --- a/include/linux/overflow.h
> +++ b/include/linux/overflow.h
> @@ -124,6 +124,22 @@ static inline bool __must_check __must_check_overflow(bool overflow)
>  		check_add_overflow(a, b, &__result);\
>  	}))
>  
> +/**
> + * add_wrap() - Intentionally perform a wrapping addition
> + * @a: first addend
> + * @b: second addend
> + *
> + * Return the potentially wrapped-around addition without
> + * tripping any overflow sanitizers that may be enabled.
> + */
> +#define add_wrap(a, b)					\
> +	({						\
> +		typeof(a) __sum;			\
> +		if (check_add_overflow(a, b, &__sum))	\
> +			/* do nothing */;		\
> +		__sum;					\
> +	})
> +

I don't know where this is supposed to be used, but at first glance this
seems to introduce a footgun. This is not symmetric in a and b, so both
the type and value of the result may differ between add_wrap(a, b) and
add_wrap(b, a). That seems dangerous.

Rasmus