Received-SPF: pass (google.com: domain of linux-kernel+bounces-35056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1359cab8-9459-826d-4f7b-b5ffef44bebc@quicinc.com>
Date: Tue, 23 Jan 2024 15:28:11 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v7 4/4] arm64: dts: qcom: sm8650: add missing
 qlink_logging reserved memory for mpss
Content-Language: en-US
To: Neil Armstrong <neil.armstrong@linaro.org>,
        Andy Gross
	<agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Rob
 Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Manivannan Sadhasivam <mani@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-remoteproc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240123-topic-sm8650-upstream-remoteproc-v7-0-61283f50162f@linaro.org>
 <20240123-topic-sm8650-upstream-remoteproc-v7-4-61283f50162f@linaro.org>
From: Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20240123-topic-sm8650-upstream-remoteproc-v7-4-61283f50162f@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/23/2024 2:21 PM, Neil Armstrong wrote:
> The qlink_logging memory region is also used by the modem firmware,
> add it to the reserved memories and add it to the MPSS memory regions.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

LGTM,

Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 2df77123a8c7..7a1cbc823306 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -525,6 +525,11 @@ qdss_mem: qdss@82800000 {
>   			no-map;
>   		};
>   
> +		qlink_logging_mem: qlink-logging@84800000 {
> +			reg = <0 0x84800000 0 0x200000>;
> +			no-map;
> +		};
> +
>   		mpss_dsm_mem: mpss-dsm@86b00000 {
>   			reg = <0 0x86b00000 0 0x4900000>;
>   			no-map;
> @@ -2627,7 +2632,8 @@ remoteproc_mpss: remoteproc@4080000 {
>   					     "mss";
>   
>   			memory-region = <&mpss_mem>, <&q6_mpss_dtb_mem>,
> -					<&mpss_dsm_mem>, <&mpss_dsm_mem_2>;
> +					<&mpss_dsm_mem>, <&mpss_dsm_mem_2>,
> +					<&qlink_logging_mem>;
>   
>   			qcom,qmp = <&aoss_qmp>;
>   
>