Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp368483rdb; Tue, 23 Jan 2024 02:05:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgXMYROTaGfOPLP2bAXCpLBBj0KdTOrsIRBFBOHtRSDjOGYDpMI83mz0ji4GIkfWSnX+gb X-Received: by 2002:a9d:68d0:0:b0:6dd:e259:9d88 with SMTP id i16-20020a9d68d0000000b006dde2599d88mr6034758oto.69.1706004319105; Tue, 23 Jan 2024 02:05:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706004319; cv=pass; d=google.com; s=arc-20160816; b=0687Ulv+lI8pYT1+/eTyz9Vqzlxlfm6Myi9CMwfHXmmeynSGXui0vCE0zEuSQOKxP2 iV3sZbFDxZBs3zYPBcHBQLgjhQsKBhc3+C6U4b3HrIfJ9rTvYDfJ/+dwS9VmaHClEo3R e6ko6nNHS7FGtONWVISkdgs1Ns4wEE5iJw9HwV4+iN+wbvABJr7QMyt0qw64TkVc19iP S11nf2qdR9C0dH76LeJ8x4w/EXJfiJuGQ3SyR1MQIpfCahXJGxPdZMjDGAwzmfbf99qX P/soNe69pugGy4w9+D/A360t/IjoLwwY3ZS17MWafnXyNoq7nvAuCRSkAL2T96mbEoBj ulWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fSTvLztS7719yyFEnMvAe2uObBUKHJdWLKe1j3LT2Iw=; fh=oaDKkD4M+Y9TqzSUqWHt6QJZ/02dBHR3TBxGZwBdi5s=; b=wGg2apKis0xxfc7aNL6/jswD+DU4qBpTW8s1fhFZPNYdBds/jKpk3DYn0eBWK/a0S7 jljBNFLZfZnu/t8ZY6mu6ZMS5SWPyLs1MmOdCVqhtE8QE53sJN2hL5YC3PfeUbZlJDYY RpyYYwwVvdN8+vJtMwGXCJ0NVewLMy1V9ufO/oekqjFt7rxVDYZUQBtPteSDFuOflg5k EQ7osZE2eaDFH/dmj0a4BPqyRNFKCbkC6cW2G7YWtxvCrFh2qaYQZpDfW6eGHbjDEIH+ 3//yEj307hnA0N6b1Zcrk85yogi1Uv0QY57RDDuqpu5m9hI+YigNmK2B0Ag7BApS9vjO cvwQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WYbEiRNQ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-34935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34935-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id z7-20020ac87f87000000b00429d0dc308dsi7577396qtj.62.2024.01.23.02.05.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 02:05:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=WYbEiRNQ; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-34935-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34935-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7DFBD1C22710 for ; Tue, 23 Jan 2024 08:47:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55CCF57892; Tue, 23 Jan 2024 08:47:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="WYbEiRNQ" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 614B557860; Tue, 23 Jan 2024 08:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705999664; cv=none; b=d5GsMPFFTlftmX8lrH4ot49Ha7O9VdMxa5YAWisaeDnE31MmC4UKMhstoWsVIxnRDbTLtAdp2oCPgm4iJM6YtU7gEF9lg4AZbhjtq8HQ/4LXemo7oCSw1vHvhZrVveedHOn9QW1EXtFvDzuo+0DLfXq+ri5kmaUp2VPRprNk7XE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705999664; c=relaxed/simple; bh=8RQY7arEYehD1BOniNMroVFilVaiSnwq/CgGVP3ThIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TEh68BOuBaLKmZhCH0jN4kWlwxhmvsWx1Iwiz1ATzOPUIaVUYqvcpMmwJlEqsN0b07iRvkXjqy+T8dO28vTKKnwiXOAbP4X7dH1FsxJE+wHXCeF4Bs8MMrYa7oBj6Gk1xcrebnKgwF5yRrRKeNdLR2Nk3WiyDAX0SFLn5U/XsQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=WYbEiRNQ; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fSTvLztS7719yyFEnMvAe2uObBUKHJdWLKe1j3LT2Iw=; b=WYbEiRNQwbZ4vG/wMXl1gMSx1+ 0k17q4Gx+7d7CfXLBjK8+kYuiB26pdCXTopSWlMoMezp2bZatP6vbW+rkpyLLoqgJJ7eN3Vsco30M LRGxHDPLBdrSwC4x0Iu+gy6GZ+bv2T13wWlXM2ZdqG71/XQ56Eewzxwv9f6AAxKd+ZdDFQEnVIdtC TFrSoMOFqjqfzPccY/64LeywGv42iXLyOIvOyqwOsKNkY7BbZ6KxBbMFPE5BPrZZgZUxG4yHdHyyu snrJ1b4oMX9owN++IGdrZ+fFm3eXpyK4nyFOrU7pFKlV4TA+Wmj18jXLDyx7+BLxcuDX/bpSIyTEK vSWze7tg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rSCRY-00Fcoj-0I; Tue, 23 Jan 2024 08:47:40 +0000 Date: Tue, 23 Jan 2024 00:47:40 -0800 From: Christoph Hellwig To: Qais Yousef Cc: Jens Axboe , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Sudeep Holla , Wei Wang , Jaegeuk Kim , Bart Van Assche Subject: Re: [PATCH] block/blk-mq: Don't complete locally if capacities are different Message-ID: References: <20240122224220.1206234-1-qyousef@layalina.io> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122224220.1206234-1-qyousef@layalina.io> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Jan 22, 2024 at 10:42:20PM +0000, Qais Yousef wrote: > The logic in blk_mq_complete_need_ipi() assumes SMP systems where all > CPUs have equal capacities What is a capacity here? > + return arch_scale_cpu_capacity(this_cpu) >= arch_scale_cpu_capacity(that_cpu); oerly long line here. Also pleas split patches for different subsystems.