Received-SPF: pass (google.com: domain of linux-kernel+bounces-35059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Elad Nachman <enachman@marvell.com>
To: Rob Herring <robh@kernel.org>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo
 Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net-next] net: marvell,prestera: Fix example PCI bus
 addressing
Thread-Topic: [EXT] [PATCH net-next] net: marvell,prestera: Fix example PCI
 bus addressing
Thread-Index: AQHaTWjekYS38TgPe0usgBWB/YnaQLDnI/lQ
Date: Tue, 23 Jan 2024 09:59:46 +0000
Message-ID: 
 <BN9PR18MB4251944C1AE34057DACD7556DB742@BN9PR18MB4251.namprd18.prod.outlook.com>
References: <20240122173514.935742-1-robh@kernel.org>
In-Reply-To: <20240122173514.935742-1-robh@kernel.org>
Accept-Language: he-IL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?qjhs1+cGGdhozVv6vlPvpDo9Z5+8Lr8SB6SsbN9/eCKZuyVig1aao8s0OpKi?=
 =?us-ascii?Q?4npiFYED+hQQO6+qjPKclR0ooCyaixjJelbigQBy+4zXbYkq82Pwt5ognHPm?=
 =?us-ascii?Q?VywzY632ctp0gpkOkoWW+ZeJOxaDeMNgn9gTzQv9dzuMHvA3wXBoBVR052xO?=
 =?us-ascii?Q?duZeepciTobIMEr4G/uKuV4Bs3PlWBPuRBkKBFW9OZ0qE6jM8j5V6obvdFgB?=
 =?us-ascii?Q?bxjbLdOD6hQLrCyiMqiEyCzJwtoyaDlnqCjj2cyEskt0tvTysjGTTESEOLd3?=
 =?us-ascii?Q?uToReMx10/HlO3l1rz1MCna7ntxARzKAQ+76qspW/JcNf0PAi7FtY6ap5x6H?=
 =?us-ascii?Q?stgkanzk7N1b7tPMtE5uSGFdSAAv1aeCUVtA/+T+Nj23vo2dmWnFbTvkJ+ym?=
 =?us-ascii?Q?2S5FQEBuwB53jmQzZW3iUBmD4kDp6Q+F8w7pJAqJpj57rZyzMB1glfX8q+Q9?=
 =?us-ascii?Q?tV6rGPwxapDNI92xGRYCgxdAB6qLRfPKGk4bzPl3QlkLjuBnvarM1oZpjPTj?=
 =?us-ascii?Q?NyEnoukc/IO/QpXmMuPBMc4HtK1zLH26Z/2RsC0Qw5uUP7aPRH8nBtYTf5jV?=
 =?us-ascii?Q?NeCohAKWoKOiJB6zclFrrdpMU/MFqX/T7zZaRnCflggXPmhVbEstbUpNPaGj?=
 =?us-ascii?Q?Gws/q6QAPDnepOrbfioCZvS7fM0dJ7aYMiRy6l9HU1XR0rciEOdZ4KwJ3bpl?=
 =?us-ascii?Q?t+yyVsfpmMKjsdr5hb28gqj6x0OCQp0MolxJwllO2y8GnViH+dz6q4yxoxV9?=
 =?us-ascii?Q?a52Thvj3/lvvXLqoGyZhcS7iAMjJcBWS/jZH2xO+UrbryQvgUL/Zb0NMG3Uj?=
 =?us-ascii?Q?1qgiQRhItlsKsjbH0qmfIgZii1EhRdcXmRmXMs2WX7L4/UeKONgQMwNjL+n1?=
 =?us-ascii?Q?LqveN6kr3W45fSzlSOEf8dJxesnWXorgK8Pabv2Tvjk8uU0YZhNp2tSmJcNz?=
 =?us-ascii?Q?EnxYQTdshIeHK8Vow0HQkDgBDhKEz/aJnt9aCfBhZ5Da3pDfIgYSlqBBR30a?=
 =?us-ascii?Q?xbi6kZ3SSffKaBNPgkz/IY5QKRt3ZDX1WToJ9zkMYWe8eydJTV3cjZEDZtmh?=
 =?us-ascii?Q?z8cXA9A0sLQ+x5j2fQCFmXzRNFTsqhsrrovsphCCo0wX7U7/DC+wvDHRd72t?=
 =?us-ascii?Q?a2eW6Kahhp7nWMVqIX6SquhYU7EnaSevArUzHOP20sX2R/E96SVvmJwcG996?=
 =?us-ascii?Q?kK2rRRuUMb98OjQXyypPNSg/3cpizitCfLPcVAXWAAeVvYp+TrT6Zq62vkm3?=
 =?us-ascii?Q?LYHKeadCiLOko2/I6XFwtM7cjhYKztSqr1Bn3ENSPGoKmVNBPkyY3tPKqsHq?=
 =?us-ascii?Q?ZBueqjorehyDhJWl3lgxG22UgbaAY9W9FTs6Pe/bivvKwoDU2xoVm96hiVdf?=
 =?us-ascii?Q?uSuQr4xqb3Db4sDWVkm7eGXsp0pUuTmrcCRD/eCJSRHiMCeWGdRhAIcbooC0?=
 =?us-ascii?Q?hxMJMVMI5oZFPgV/X+jc8L1av/LiFPH/ONPnac37kpOsiJxVK3RXeKO8yacx?=
 =?us-ascii?Q?Gq/RwwDIldVVQ1TFNy2FK+1HOQ7BFWaFbpLBqTU7QcIVTkLleT/lDDfrdjlK?=
 =?us-ascii?Q?AULLcon8iFh6L1PR5+jR/cDgt5pcQLxnFLzMfT4l?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4251.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d8463f0-ff27-4845-251d-08dc1bfa0788
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2024 09:59:46.1472
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mWi7LXmk8ekuoT7KfNJowD/jWuZ3azb8EltADIcs4A5brL5eCoonuwPLsJ2iyT4PZC6gh/FVPAe7JBymQv21Qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR18MB3536
X-Proofpoint-ORIG-GUID: kofLRl3dciAvnwhGNGbz4u6HPKEUs9Nh
X-Proofpoint-GUID: kofLRl3dciAvnwhGNGbz4u6HPKEUs9Nh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_05,2024-01-23_01,2023-05-22_02


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Monday, January 22, 2024 7:35 PM
> To: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [EXT] [PATCH net-next] net: marvell,prestera: Fix example PCI bu=
s
> addressing
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> The example for PCI devices has some addressing errors. 'reg' is written =
as if
> the parent bus is PCI, but the default bus for examples is 1 address and =
size
> cell. 'ranges' is defining config space with a size of 0. Generally, conf=
ig space
> should not be defined in 'ranges', only PCI memory and I/O spaces. Fix th=
ese
> issues by updating the values with made-up, but valid values.
>=20
> This was uncovered with recent dtschema changes.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/net/marvell,prestera.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/net/marvell,prestera.yaml
> b/Documentation/devicetree/bindings/net/marvell,prestera.yaml
> index 5ea8b73663a5..16ff892f7bbd 100644
> --- a/Documentation/devicetree/bindings/net/marvell,prestera.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,prestera.yaml
> @@ -78,8 +78,8 @@ examples:
>      pcie@0 {
>          #address-cells =3D <3>;
>          #size-cells =3D <2>;
> -        ranges =3D <0x0 0x0 0x0 0x0 0x0 0x0>;
> -        reg =3D <0x0 0x0 0x0 0x0 0x0 0x0>;
> +        ranges =3D <0x02000000 0x0 0x100000 0x10000000 0x0 0x0>;
> +        reg =3D <0x0 0x1000>;
>          device_type =3D "pci";
>=20
>          switch@0,0 {
> --
> 2.43.0
>=20

This yaml has a mix-up of device P/N (belonging to AC3, BC2) and PCIe IDs (=
belonging to AC3X, Aldrin2)
Looks like a part of the yaml was updated, and another part was not

There is a reference here of actual usage of prestera switch device:
https://github.com/dentproject/linux/blob/dent-linux-5.15.y/arch/arm64/boot=
/dts/marvell/accton-as4564-26p.dts

So actual ranges and reg could be used instead of made up ones.

But the actual real life dts places the prestera at the top level of the dt=
s, not under pci.

I am not aware of any dts/dtsi using such kind of switch node under pcie no=
de, similar to the example given in the yaml file, and did not manage to fi=
nd any under latest linux-next for both arm and arm64 dts directories (plea=
se correct me here if I am wrong).

So the question here is if this pci example really necessary for the preste=
ra device, or can be removed altogether (which is what I think is best to d=
o).

Elad.