Received-SPF: pass (google.com: domain of linux-kernel+bounces-35107-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <cfee57f3-5940-44c3-a93b-3a5160dc8351@collabora.com>
Date: Tue, 23 Jan 2024 11:38:42 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change
 watchdog reset boot flow
To: Chen-Yu Tsai <wenst@chromium.org>,
 Matthias Brugger <matthias.bgg@gmail.com>
Cc: Hsin-Te Yuan <yuanhsinte@chromium.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-mediatek@lists.infradead.org,
 =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= <nfraprado@collabora.com>
References: <20231228105717.719624-1-yuanhsinte@chromium.org>
 <CAGXv+5H-mpXZ_0H_HchDWeTgx+4Nkxh6651DEs1C62mrXczTkA@mail.gmail.com>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <CAGXv+5H-mpXZ_0H_HchDWeTgx+4Nkxh6651DEs1C62mrXczTkA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Il 23/01/24 05:03, Chen-Yu Tsai ha scritto:
> +CC Nicolas
> 
> On Thu, Dec 28, 2023 at 6:57 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote:
>>
>> The external output reset signal was originally disabled and sent from
>> firmware. However, an unfixed bug in the firmware on tomato prevents
>> the signal from being sent, causing the device to fail to boot. To fix
>> this, enable external output reset signal to allow the device to reboot
>> normally.
>>
>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> 
> Friendly ping?
> 
> Also wondering if you folks hit this, or if you haven't triggered the
> watchdog at all.
> 

I have never seen any watchdog timeout on Tomato R2.

In any case - this commit misses a Fixes tag...

Cheers,
Angelo

> ChenYu
> 
>> ---
>>
>> Changes in v2:
>> - Limit the effect only on tomato.
>>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
>>   3 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> index 2d5e8f371b6d..a82d716f10d4 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> @@ -23,3 +23,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> index 2586c32ce6e6..2fe20e0dad83 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> @@ -43,3 +43,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> index f54f9477b99d..dd294ca98194 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> @@ -44,3 +44,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> --
>> 2.43.0.472.g3155946c3a-goog
>>