Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp425917rdb; Tue, 23 Jan 2024 04:11:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0WKAn8IHKlbY+1JyA/1rMInJuGOFdKtosIu9bH6gAwvd2f47KYNsPHbPxMgVBVmRKN2PI X-Received: by 2002:a05:6a21:a599:b0:19b:4582:c7ce with SMTP id gd25-20020a056a21a59900b0019b4582c7cemr7056839pzc.54.1706011905525; Tue, 23 Jan 2024 04:11:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706011905; cv=pass; d=google.com; s=arc-20160816; b=gaBQeQV93x9t05OY1IB2GKf2BhAYNeY3S7P1CapLn9kZ6nkij1fDmj8IGfRY85DuOJ Nc1rjiXYJafjzhpHJvZ5mwOBpQbvvgCPn8FbsL2Jn7hoUJEKYSklYm2i8pjyxbcTV54J bZVGiDe5EhgBI1wryEBVASKoQFTlVXDgxSdBDUCN+F3Wxcj2+Xp4GZ9mCd3/t/ZPFfa3 hzXb9M6J6Fi7pz1ndKfMIVRFj0Qmib3WVffvSErgQ/tixhNV6R+iqBvxs2mlNIFLV1NP 93BLCUnaSY2YMdLKTANRvo2ExT8M3lwdB9m7Imcs7Agx1ZigAkgWUyizR83cj7z2G+V7 mHzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=/+1BDwHJnbrAZhBlYSe1wZMRPanHDDMr02vP/6SuvQU=; fh=j2I8GDh4aa0GE3PD3Ag5/DIEI0qDscPSrUbY0wEr90g=; b=AABnhFss2XCA8ZBJKPW2Td0Bc1jXTJTK9oQ9sAmn3Ppw+4SeHP8g9o9AHvouGe0j8c fh8AYBwDkPwz5fklqnxiyTIzo4WXqOPlPZD/um6k5FRO5Iene6PTjyo3rP2oWGqGpMtZ tQPP0I6hbmi7E3y3WRFIaYT37Oi1RjFC34Pb9/z+iUwKxQkX4AVDre4CBH/riEwlQauv jCYTSwItTCFO00FYfoY5K5jlqzBJ8zbW6SvxQ3FzHG82rnsprvG6ntotSkalCPESfSNg UH1acbyxv2sxfnK8t8YeHbzKfLdOKSL8BgD5ME2wOgUBHWChacCPiVWXZf6BVdxi1Vo7 wR7Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=B1cDTipr; dkim=neutral (no key) header.i=@suse.de header.b="rSkTzEX/"; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=d8BrprTY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-35231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h14-20020a62b40e000000b006d9ada3dc74si11768370pfn.263.2024.01.23.04.11.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 04:11:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=B1cDTipr; dkim=neutral (no key) header.i=@suse.de header.b="rSkTzEX/"; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=d8BrprTY; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-35231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3D7BDB22132 for ; Tue, 23 Jan 2024 12:09:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E3805DF12; Tue, 23 Jan 2024 12:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="B1cDTipr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="rSkTzEX/"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="d8BrprTY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="akPQxMhy" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04CD5D917 for ; Tue, 23 Jan 2024 12:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706011784; cv=none; b=W7W75v3tE+ajB6DbeiQ7/qvGKcyiuqUH4rsB6eEe8yynHguixOYM81cD3+t8Su8ezf/RWMQNn0WzNRJyZhnvplKQKaWSg8ldjWuYq8ZVkdZyiKhj/g2yZHnvI9iB0Uil0qOMkhqbdRaCsLUyDdtYOIo5lz2oGDeAA79A3KQCvyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706011784; c=relaxed/simple; bh=pDZYxDOT18/AZF6D6YMd8wpC3QRkUUbr09SS2lZLElU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Goe+AmZ7Pm/0GMFLJ3aabdrKr9N42zQvCrQmnO5kBY1p1+jepRD0tC5ajdlPBXxx2V91+FSR547kKX+GzomQZ6U1vfjU/DEoquQtA91w+aTlO+XKFktZy5cpj27sWhSpXf7w2JlkYHfWjyFd0hOit/LxEjGztAE7MNMRhixIRhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=B1cDTipr; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=rSkTzEX/; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=d8BrprTY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=akPQxMhy; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C579D21DBD; Tue, 23 Jan 2024 12:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706011781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/+1BDwHJnbrAZhBlYSe1wZMRPanHDDMr02vP/6SuvQU=; b=B1cDTiprfahudrxoImph/fwM/kqG0wrxbI3Eep72sjZSbh1avyjXgD2VVIlHqcR5t+yytA +c4B8lRY4t8TzapW8BYJkk6ET80laQ6BTbf5NO4FA7gRg8pjpuvQ5bNpECr2zYaRuy39gb j9LEcIKhFh3j+QpaNTQUk4BvAKQThzo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706011781; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/+1BDwHJnbrAZhBlYSe1wZMRPanHDDMr02vP/6SuvQU=; b=rSkTzEX/gwn29cDxjtf/iR//xik4AJ7BVAEeCbhubPR9IfJK6DJv+EkLWamFyG0psfYheh iQ7gLf5FQ0AMXVDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706011780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/+1BDwHJnbrAZhBlYSe1wZMRPanHDDMr02vP/6SuvQU=; b=d8BrprTY8ViLJy7Me6f/fUc9mexEb89wcEcOyCAKRaKRrRlu5AueuQ/LAGZxte4/rokRdH M9nzwq77i16PmyRlMdVv8ZBzFSxmfayYK8k9ISYFEJVOL2nz/5KhJeRnP5icT+touWuEM4 YksK44+cSc7YT7UsXbr9YzPVhzv+fXY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706011780; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/+1BDwHJnbrAZhBlYSe1wZMRPanHDDMr02vP/6SuvQU=; b=akPQxMhywd5JLeBxICmRJ9ihEhNX5OUXuedQuYvLvBMCo8+ekYORqo4eppuU7QjVKTCLrv teCpTH08foE+Q+Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8611813786; Tue, 23 Jan 2024 12:09:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Fa12H4Ssr2V7OAAAD6G6ig (envelope-from ); Tue, 23 Jan 2024 12:09:40 +0000 From: Thomas Zimmermann To: javierm@redhat.com, chenhuacai@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann , Jaak Ristioja , Huacai Chen , Thorsten Leemhuis , Jani Nikula Subject: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync" Date: Tue, 23 Jan 2024 13:09:26 +0100 Message-ID: <20240123120937.27736-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Level: * X-Spamd-Bar: + Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=d8BrprTY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=akPQxMhy X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [1.49 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_MISSING_CHARSET(2.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; BROKEN_CONTENT_TYPE(1.50)[]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[29.76%] X-Spam-Score: 1.49 X-Rspamd-Queue-Id: C579D21DBD X-Spam-Flag: NO This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4. Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync") messes up initialization order of the graphics drivers and leads to blank displays on some systems. So revert the commit. To make the display drivers fully independent from initialization order requires to track framebuffer memory by device and independently from the loaded drivers. The kernel currently lacks the infrastructure to do so. Reported-by: Jaak Ristioja Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t Reported-by: Huacai Chen Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/ Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133 Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas Cc: Thorsten Leemhuis Cc: Jani Nikula --- drivers/firmware/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/sysfb.c b/drivers/firmware/sysfb.c index 82fcfd29bc4d2..3c197db42c9d9 100644 --- a/drivers/firmware/sysfb.c +++ b/drivers/firmware/sysfb.c @@ -128,4 +128,4 @@ static __init int sysfb_init(void) } /* must execute after PCI subsystem for EFI quirks */ -subsys_initcall_sync(sysfb_init); +device_initcall(sysfb_init); -- 2.43.0