Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp438287rdb; Tue, 23 Jan 2024 04:32:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IHADIoNKBlguS3JgKjw5+NM2OacEzpDwzYfBiiKYHXZQ15VgT68rAFtxJdx1XSZWLwsE/vB X-Received: by 2002:a05:6214:622:b0:685:727a:bf32 with SMTP id a2-20020a056214062200b00685727abf32mr914697qvx.73.1706013133055; Tue, 23 Jan 2024 04:32:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706013133; cv=pass; d=google.com; s=arc-20160816; b=V/jBBNuFRn8bEzxZ5tQHOSgC1V6mIgBFcKuN8PtvncwS9ClFvj8LK8lxHmaijaVjFq WWnROgo07kAZox7U24QN8SDZx/mZcBEkag/TXT6h85M2GIsNM/27/j0xIZzJGbn3PnZ0 nFbWyFD6U4QxlkQJlsDV4odKThuAZxm4yumrcDXRbMhWAxyr8cu+BH41PG67wFkd+Tma TiQIyf0ZFjx7rn5eRtQr33tyqotYu5VI/SA/2jWBXBzv+kQE+/Y0iHYkcOnuT0WxbLM5 E7MMQ80ltM4jnQYzbo5kNKo+WDSGP+H3AHgQq6OB172IpH+/uIG1H/SAzQqXPdmpCkH6 wnbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=X8+URA4n+eSW1Nx+EXerBLZ8CM+KAD4dLGFiJh3bnMw=; fh=WuqMOUtKdwUwv3vyDzq82/P81OBR/mSP7dxltLQZuQs=; b=QOzXAMehExjCty0STOmYtQKdWZIB2wvywfeCW6OmyoK6YEIDEHO8FzNSq3miPqgPQG RLOZsv/WYbVkxkhp7zL+l36omZaXGHfM/h6Ahw8EN4UkuKaKM13VkqBlyRNdr5ibxg5+ Qq+8YJunuuFsEgxThBXbM8aNHWgkjgBHysqyJSeLI+y8OgAJqNiK2QD/Ho4kiuLjcOlg QJJbz51/thIC6pmDtDXxJYS9rV4NMEcuXci0HibvEu0BSs4KsMv05d2jSnwjiR9SrSoX iVc6C7HqunyabviZlZy+WOoILilQKNyOntYsXO3dhpTNi2+BE6BMwOm5Dl7+uka+bKy2 PWDQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wlc52oS6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-35250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b18-20020a0cc992000000b0067f32e92d37si7951971qvk.31.2024.01.23.04.32.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 04:32:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wlc52oS6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-35250-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35250-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CBC661C220C2 for ; Tue, 23 Jan 2024 12:32:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6A9455DF34; Tue, 23 Jan 2024 12:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Wlc52oS6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9427A5F540; Tue, 23 Jan 2024 12:32:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706013125; cv=none; b=LSFqvGoAqNNtGpbrI5MBbY5OwjAuV1lq2U0nwTs80uUE7rZbkG2RVmOr3C9t+/XVe4tqIxpTuk0aNg65KV+cEt07Q7UQ6hAdlWmmBodYzMynZa47ghCVDzelY6pJHt2GsVU9VqQ4xn8JL6FDgzFutR70XbA4ovLPvw2V9/9zung= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706013125; c=relaxed/simple; bh=d4c8ZHsXz70kQqHT+wAs67wpSpeSuJtNg6++BZ/o6sI=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=q2/BmOKLaM5P7mqM6omShpJ1FplfxXRZcGmLd47UUAfQ64IutvYZ41SIcYCknWlT4Kpeay6uS8wkeS4Iw9Zi21kfmvp0Y8uBiDZNLyyDTD6eRNnt1/anzaxcOMtu0LBe0SXPOU1XUTkLp/0Ur9fjcsgdziIysfxrH82e5kBMpQc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Wlc52oS6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 469B8C433F1; Tue, 23 Jan 2024 12:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706013125; bh=d4c8ZHsXz70kQqHT+wAs67wpSpeSuJtNg6++BZ/o6sI=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=Wlc52oS6+s8GcWNgx7vWTuHU4SAxi/gQYyGslKJr1BqcbHnwCKGCCB3BVduBMe3/+ ZiWBIBtpr71gbg4lCodlRQonDSeYb20dG7hu1k9/SFPV7qvhMeiVX8vwERXMUayldv vtep65X456exwJwase9LYTq+vX0E7EocOthJdUk1gbdxLdzviMsSqw31fqqAOsE+lw H7o2YAxYIMwHoFvuqyrYRShk5TiPzIQWSDJ8t9XZAOvw+5kgfVig/AT+2O5l0GkHfN W1uOWGHULnyIsPj0gzyIcj7z/yXWY6pL7vhbAPqRKun5amZ5zH0sV9TXFZPOG1utuw yW0P0VX93JpDg== From: Mark Brown To: Amit Kumar Mahapatra Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com In-Reply-To: <20231218090652.18403-1-amit.kumar-mahapatra@amd.com> References: <20231218090652.18403-1-amit.kumar-mahapatra@amd.com> Subject: Re: [PATCH] spi: spi-cadence: Reverse the order of interleaved write and read operations Message-Id: <170601312400.19682.11415116408445396292.b4-ty@kernel.org> Date: Tue, 23 Jan 2024 12:32:04 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-5c066 On Mon, 18 Dec 2023 14:36:52 +0530, Amit Kumar Mahapatra wrote: > In the existing implementation, when executing interleaved write and read > operations in the ISR for a transfer length greater than the FIFO size, > the TXFIFO write precedes the RXFIFO read. Consequently, the initially > received data in the RXFIFO is pushed out and lost, leading to a failure > in data integrity. To address this issue, reverse the order of interleaved > operations and conduct the RXFIFO read followed by the TXFIFO write. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: spi-cadence: Reverse the order of interleaved write and read operations commit: 8715c23b6540d142b955efe64f91b8bc2d3cf623 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark