Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp442190rdb; Tue, 23 Jan 2024 04:38:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6jc9VAiQUnHNP48IWrQ6jfvxuxVjT0e1kzGi6h6p0kvMLHbA2K11hDcXX92RbTyPYK2QR X-Received: by 2002:a17:906:2604:b0:a2f:6486:3a79 with SMTP id h4-20020a170906260400b00a2f64863a79mr1667005ejc.192.1706013511425; Tue, 23 Jan 2024 04:38:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706013511; cv=pass; d=google.com; s=arc-20160816; b=LNokfG+t2s3oWI+wlaIH5rW6vZ2TJhzysn5/WUr+f/Wkk3uHLICNb6TPmD+P16tXum DLm8/GM96SQcCV/tp6MybntvZ5OoWYiqMpssy9jnnYC29UcYBbxafRLcXmpRQ+YkwO6t mj+Nro0O6tO8GmMuYNdFMZwBC/AZavbL96y0seZYiLxnRr7mFBTjZQSnXclkGT5KFDKj TEjFPqahshyGwW76kgi9Dv19r1Cs3eCCqON85Ma/LGLcbTUPHBksQ09NgOxrV/OMv39/ mFqcjB5ItkPN04kPueJqiInrlG8J8ZJvD+fWcdKmeFqhNGNoVDUmo6niEoyXPOOECc9/ pD9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=b0Aht4Z16P8L5ltKdjULPwhLp0+Y9JoWi3OkWohTfrU=; fh=5uM1nNUIYN0XFxYATJtGtx7lDT9rUptd3gS0EAjjdIo=; b=Dv/fcIPwuaSnmMt/rOBMMjS/A34Z79rjzHlsXgkH0Sareu/2aNa8LR8XstiXfpMNBW alKCTZEoOhjXF/y/z37uqk3y5HWD2r3B+MwtMdL0goJPtItul1xr+A5md4aVbORgI4JS cCYp68vOFQdfqXZmQlNOvOaC0hkFtGABYxN1aCriD95PQy1rw9/4YqnanVv+Lksv8xxj N2oB8/pRMBy5N44efcEQrgrZ3NLMUvrno121btnlsG3rTnp5z1TQrki7RLzVUMWMFC8h IWatuTiUzNB7IhxlsBBJQB2CsOjgVY++gKaYeMkSXLt/PbYvawWs6T0RQq9IWQH38Y0i TR9Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y1xJnaPu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-35255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id mj10-20020a170906af8a00b00a30d5c71d17si370996ejb.977.2024.01.23.04.38.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 04:38:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=y1xJnaPu; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-35255-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35255-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 2D6B71F22416 for ; Tue, 23 Jan 2024 12:38:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58FF05EE69; Tue, 23 Jan 2024 12:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y1xJnaPu" Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E1A95D906 for ; Tue, 23 Jan 2024 12:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706013502; cv=none; b=lOFxS6gUFWTgiosVYXja5Cy6IR63FX/Cl85FweZeoUJIJpruruLbtiM4ZGWbE3sD7ZoL+9SlG3wRjpmQh6t3G4loRB08QmsSa7HaAsWiq44psN1AmyGMKdhGwZNwEEt2KGNDmneGQsTBMJ0dO6+q1KGxpX/bi25TVx2FdHrzdQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706013502; c=relaxed/simple; bh=WBQDTNBTK9sdRRuBTkFzcjNllsxW2QS/rV8OG3A6y6U=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=W5ehhEsZvRTBksjx5HqcUxzgmy7Pz5ZNOWlQEl36NHHYj+IB3hKGspxJ2SHhMFw5u7HpFfv0dwrhJdaAz8PqrbnPggTUnTrnc1pup638PmnzdXtuHK9ljhr9E61Rw8TozsMSAxR27smoQzJH2Pb5zX8GZ9VPQ65pMlmQFLrZg9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y1xJnaPu; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-5ff7dc53ce0so31230847b3.1 for ; Tue, 23 Jan 2024 04:38:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706013500; x=1706618300; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b0Aht4Z16P8L5ltKdjULPwhLp0+Y9JoWi3OkWohTfrU=; b=y1xJnaPuWp2atV6P14a9WHO0DEDzDqqaFQjOJhABoM9HEZgIAA7h/FQw2EYKEo2j8Y QcGlzyugWSOtZDWjdB3/+cb5bAbvjT4jUXWYuXnBDa0+0mJWpGkCktP7/u5l5/QxrrF+ LJtANgl+8BjmeCHxXl0UjwkgqGxLhMdBZWFj4zvieKZZNy2IYFnImWfEnvZDf1PeP0ov +7tYWBdA+v9zxeTUkCLZWcXGm7lxQabns0EutJtxdlWuNfwemytn3o6yG7L64DvYMcuW mPbxGOfmevdoQ2knoKISALT1jScuIf444motd8lM9KDEz5r3SwHdNsOjz2HKcIBkptMN 1sXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706013500; x=1706618300; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b0Aht4Z16P8L5ltKdjULPwhLp0+Y9JoWi3OkWohTfrU=; b=c0N2OU10Yrraf+dBCE8btsDvwMPJ1NwQ4LQ8r3BZSqQ+ng76FtWGE/gnSZcNxl9yzF Cdyof5WH99OdBt4Fibi27zcNALL2a/Yr4txW4f9r0d4J3M8cd6FjFQ+AO6CeBXzFvipl knAM6ZqCyzqVDCSgUB6W7lfxwTgXbitosoIAREYCbc2WUzr7pHVfl1B3Uk1dYvn08aOx gqbriA3RYfDOHwh229iGk+KyHKJggmuanqg2Vf4/C2gV/2xGhLmOotGL4o0AnztnsJRi 1P5e4Mlz2zvxpLk46k19d3QGRXmLel6HkDrnKfRMc+2oAfJWJB0DlMNkknCq8leMNggd EsDg== X-Gm-Message-State: AOJu0YyDXGNUwtVE17MHDPnGl1mHyVPWf6XzyqcUK8ZokbM14Hw1HNJE WUxDuiwg2X+vikpoQ8g2cbAA15a7vmu8qrRSWAgmekid/dJdRzaY6NheMgIvMtnlRZTbg/GXF53 /HwrgI65PxKBH7G/22zwDGJSL/SBn84GJJgvsew== X-Received: by 2002:a0d:de07:0:b0:5f7:a3bf:6071 with SMTP id h7-20020a0dde07000000b005f7a3bf6071mr3324304ywe.105.1706013499919; Tue, 23 Jan 2024 04:38:19 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240105160103.183092-1-ulf.hansson@linaro.org> <20240105160103.183092-4-ulf.hansson@linaro.org> <87801f3e-b7ce-46ba-9856-1321635a11b5@nxp.com> In-Reply-To: From: Ulf Hansson Date: Tue, 23 Jan 2024 13:37:43 +0100 Message-ID: Subject: Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list() To: Mathieu Poirier , "Rafael J . Wysocki" , Greg Kroah-Hartman , Iuliana Prodan Cc: Viresh Kumar , linux-pm@vger.kernel.org, Sudeep Holla , Kevin Hilman , Konrad Dybcio , Bjorn Andersson , Nikunj Kela , Prasad Sodagudi , Stephan Gerhold , Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-media@vger.kernel.org, Shawn Guo , Sascha Hauer , Daniel Baluta Content-Type: text/plain; charset="UTF-8" On Tue, 23 Jan 2024 at 02:27, Mathieu Poirier wrote: > > On Mon, Jan 22, 2024 at 01:02:08PM -0700, Mathieu Poirier wrote: > > On Mon, 22 Jan 2024 at 10:51, Iuliana Prodan wrote: > > > > > > On 1/5/2024 6:01 PM, Ulf Hansson wrote: > > > > Let's avoid the boilerplate code to manage the multiple PM domain case, by > > > > converting into using dev_pm_domain_attach|detach_list(). > > > > > > > > Cc: Mathieu Poirier > > > > Cc: Bjorn Andersson > > > > Cc: Shawn Guo > > > > Cc: Sascha Hauer > > > > Cc: Iuliana Prodan > > > > Cc: Daniel Baluta > > > > Cc: > > > > Signed-off-by: Ulf Hansson > > > > --- > > > > > > > > Changes in v2: > > > > - None. > > > > > > > > Iuliana/Daniel I am ccing you to request help with test/review of this change. > > > > Note that, you will need patch 1/5 in the series too, to be able to test this. > > > > > > > > Kind regards > > > > Ulf Hansson > > > > > > Tested-by: Iuliana Prodan > > > Reviewed-by: Iuliana Prodan > > > > > > > Thanks for the leg-work on this. I'll pick this up in rc1 later this week. > > Looking at the other files in this set, Ulf of perhaps Bjorn should take this > set. Yes, all patches in the series depend on the new helper function that is introduced in patch 1. I can certainly take the whole series via my pmdomain tree, if that's fine by everyone. Note that, there is also another series for genpd and qcom drivers that might make it for v6.9. It may be best to keep all these things together to avoid conflicts. Let's see what Greg/Rafael thinks about patch 1 first though. > > for: > > drivers/remoteproc/imx_rproc.c > drivers/remoteproc/imx_dsp_rproc.c > > Reviewed-by: Mathieu Poirier Thanks Mathieu and Iuliana! [...] Kind regards Uffe [1] https://lore.kernel.org/all/20240122-gdsc-hwctrl-v4-0-9061e8a7aa07@linaro.org/