Received-SPF: pass (google.com: domain of linux-kernel+bounces-35313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 23 Jan 2024 13:06:45 +0000
From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Seven Lee <wtli@nuvoton.com>, lgirdwood@gmail.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	conor+dt@kernel.org, YHCHuang@nuvoton.com, KCHSU0@nuvoton.com,
	CTLIN0@nuvoton.com, SJLIN0@nuvoton.com, scott6986@gmail.com,
	supercraig0719@gmail.com, dardar923@gmail.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"
Message-ID: <185f3912-5a92-4ef2-aac4-0df8363d8727@sirena.org.uk>
References: <20240122095650.60523-1-wtli@nuvoton.com>
 <20240122-daunting-woof-19fac5689bb2@spud>
 <04945799-eded-42f9-b8fa-8907be44c400@sirena.org.uk>
 <20240123-bottle-elevating-9fbba5424014@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="o44Jj4pPrxHSXHhI"
Content-Disposition: inline
In-Reply-To: <20240123-bottle-elevating-9fbba5424014@spud>


--o44Jj4pPrxHSXHhI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 23, 2024 at 08:34:03AM +0000, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 07:40:51PM +0000, Mark Brown wrote:
> > On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> > > On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:

> > > > +    enum:
> > > > +      - 0 # VDDA
> > > > +      - 1 # VDDA*1.5/1.8V
> > > > +      - 2 # VDDA*1.6/1.8V
> > > > +      - 3 # VDDA*1.7/1.8V

> > > I would also rather than this enum was used to have sensible values for
> > > the enum itself (which I suppose means strings here), rather than the
> > > register values. Seeing "nuvoton,dac-vref = <2>" in a devicetree is not
> > > very meaningful IMO.

> > Do you have a concrete suggestion for how to more clearly write these
> > directly?

> I would use what's been given as the explanation comments for each of
> the current enum values in the patch.

Given that none of *, / nor . are usable in defines that's going to need
a bit of massaging...

--o44Jj4pPrxHSXHhI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWvueQACgkQJNaLcl1U
h9AZZQf/ao209hI/MDFLL8V01uYpIbpZZJHJhmCnoIqQZI9Zf1saVE9CfUT01pBI
HeitK8MA1WM/3YMh0JT57EQ2XMFSYCHmv8clDtVnqqVun+zD5xXS6PFHIzzqlWJZ
uZwcjyxs1vssOWrJUOeHyZHSoV6QIuEY5HfOSFo98n3QG40P88AoCFNafMKgbk3I
8uoAB5TIpDVbLMF+c/ETEi5zxzcYjEQ4B2s7rCxEFPuvQu32ErAsYW3PCpRbzun9
adZUG89VeomjC/gs1Vp+0nqm5jFC3fJfTXrHFrK+ty5HgGUUGPxlUgolFxljV69a
d4bjft12qN7vACIxCZYBBPRYmq1MXA==
=Vsnr
-----END PGP SIGNATURE-----

--o44Jj4pPrxHSXHhI--