Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp489810rdb; Tue, 23 Jan 2024 06:03:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHy9GjnIBekiJPa8jIXGUvboD2qOkll7zOtHBwHtkUXZSIUGg1bkfM2Fqfw6deXInL7/oo3 X-Received: by 2002:a17:906:c112:b0:a1e:997a:574f with SMTP id do18-20020a170906c11200b00a1e997a574fmr155107ejc.122.1706018591675; Tue, 23 Jan 2024 06:03:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706018591; cv=pass; d=google.com; s=arc-20160816; b=bSh64sb93Rve0QxI7U1XU4t8JBoVewWAKLob24BwEKzzVZdKcsvnx21NZGAOZifgYV b2CODDNtPB7a5PQ2xcnJ5eU4lVkAJuhmOrfoBow3BK1RMHxPGg4qY2nAaH5+adAT2tzb FXdS30BijTiNrcFjZgXuqsqlFd3J/6rGRPChm1HIw5sKBRcwOutgS7sDGpt6Oy8R6ik9 rRLRMjkE7FnBUOi0yHk/LAF0ZQLBjTJHcIGeNwinlRTp76jcp27TSKIOuWaJ9q3f5Vab pI29Z8AJdhUWKB+en9WRt2Ts4MxzEJErr/t5bdaOvj1B4TguaVKKn8PbDB8RxBBXhkey B61A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6p9Rl+LZVeUbFT5hNdgcUqVQFz8vLrdtTXkglEVJ9Y8=; fh=XVBKcof/CkhdWatJ/BZvFhMShpYGwC6r3OPjeJm6+j8=; b=0YKS8MkdHdlWwVKMKi9j27FYAA6xZrdEsef0yRpB6CEUW2iEX8PidDUSbcb7jB2Skx xb4ZP7Au+XXUILlxfgU/6+7thdIXzHs4DSXELnvJzu4NA0uk5fgK6AndWZl/wXXhMJin r+dqyQ7PTHbQzmo4tA8jF+RpZOvoLQwtwOgnMLac0L224I2sXqPlhAhB2uIhuFeKNs3L hhB+17o9hXczEBJK6QGneHk5Aat482kowNuU2jpsHao7DRQorE4ZW/G/a6Ik3e6uzFNX ct3o4DrtB4nXDkuTf3XyY60WqcbW8wkNDUf3cSOSlluizssU3fN494MyPOwz638hXth2 HLUA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6lL8PmE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-35419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35419-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id fy24-20020a170906b7d800b00a2af139e667si10098572ejb.137.2024.01.23.06.03.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 06:03:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l6lL8PmE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-35419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35419-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6CA331F22C8C for ; Tue, 23 Jan 2024 14:03:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F45F5F864; Tue, 23 Jan 2024 14:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l6lL8PmE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34D2B5F841; Tue, 23 Jan 2024 14:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706018579; cv=none; b=fgxxe5kJLWshHn0eIXSMCWAtIhY51Ol6x0gCWj+Nd+bR5IExgkj2gy6/OeDorMXXaNYCre3NjJrYNWcW8MPAXaealgWGrEIf4RxMSWFh8+bfHngCtd90tauj6XvMHnMN8z8jbQ+0wKovpFlmN55DS4nqwATdo+hinka7YAyGWjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706018579; c=relaxed/simple; bh=07J5vk8WrZtMUgfX9yUoEbt1L1ydDJvsXfEiWtN8rKU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=laCBR53BRXXYShYAPeWhfrA344Pis92cB2wFGohpwn8pqT/E/wv7z/y3PjGbxUz9KKdgnSxMrI3UD9cNS6ygs2z5pdpXK/ZMTeMbG949nT7STKX0zuoM4EGMm6ycQomaxrdSg6WHHQ7Z1bXYy/xokjkR9O2mNz7SZ2cNnXEYJmE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l6lL8PmE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E53B4C43390; Tue, 23 Jan 2024 14:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706018578; bh=07J5vk8WrZtMUgfX9yUoEbt1L1ydDJvsXfEiWtN8rKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l6lL8PmEhiPnkg3AaFYGvj4tEwYmxSUxj/M9olDGO5c+2bydQkvUmIdqo825Gr4Ge r9Dji7LWBvIzsKzsw8ivu/rtRyeT6upVnAmsdFdw5F7fAdO1UOH3M4yFvGEwqsbY2w edkV42ClQlkuaeU6BiHNs9RMb0RNl+a99g0Usyfr6WX7X+J428aYct34DXH56asG7R 2Qk0okBICHwgmhLN1EM3igCXkPbTkW7u/BXbaZXgAoLxjVuVDDfXUwc7NmgOBhgMXq 310/wBYOzv7hSleYDkp46A3WVSHgZoTKYM8+GCyq1u1wJb8H+1vUC9Z5II9ueFg/JC D9NZ5HjbldLLw== Date: Tue, 23 Jan 2024 19:32:54 +0530 From: Vinod Koul To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Kishon Vijay Abraham I , Philipp Zabel , Tom Joseph , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH 05/14] phy: ti: phy-j721e-wiz: make wiz_clock_init callable multiple times Message-ID: References: <20240102-j7200-pcie-s2r-v1-0-84e55da52400@bootlin.com> <20240102-j7200-pcie-s2r-v1-5-84e55da52400@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 23-01-24, 09:20, Thomas Richard wrote: > >> > >> - ret = wiz_clock_init(wiz, node); > >> + ret = wiz_clock_init(wiz, node, true); > > > > You are calling it one once? So what am I missing > > In patch 6/14, wiz_clock_init is called in resume_noirq callback: > > ret = wiz_clock_init(wiz, node, false); noticed later, I think this would be useful to mention in changelog -- ~Vinod