Received-SPF: pass (google.com: domain of linux-kernel+bounces-35460-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b7bd8769-5f97-4c9a-be80-8d1acac92b19@amd.com>
Date: Tue, 23 Jan 2024 20:07:53 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86/amd/pmf: Fix memory leak in
 amd_pmf_get_pb_data()
Content-Language: en-US
To: Cong Liu <liucong2@kylinos.cn>, Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240123011147.6843-1-liucong2@kylinos.cn>
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
In-Reply-To: <20240123011147.6843-1-liucong2@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VHdSQ3pHejBielNhc1FKaEdCY29RdGZVYW80Q2ZmNVdUeVZoOGg4MTlVSS9P?=
 =?utf-8?B?RXUxOUd6QnU3R1NYVlc1TW5wY0oxQ3lIaWg4Vlo3UHpmODMyV3prYk5WeXBS?=
 =?utf-8?B?bVl3dHFXQ3FtYi9qVStSbWJ3L21TZmdBSzVFek92MmUwVnFRckg1OWVjUjNh?=
 =?utf-8?B?ZkhzcjJTdWpuRTE3SHNZVkU3VmRDT0NnaStlWGR4OTAvanVkOHpveGVaRm41?=
 =?utf-8?B?RUxweUpZYXdUNm0yNWNJbjQwWFlMUVpkWEFrUkU2NS9VVm56UnVKZ1pBM3pz?=
 =?utf-8?B?czdMdDZZQkNTa2tHTkppa0RFYWhqSzFaaFRqd3hyZ012YW54Ni9nMUNqOEhp?=
 =?utf-8?B?N2ZRU1FCUTJ5dTVTWFFwbDlLR3J3VStWNXVXbURZb1Z1UFdEZzJOdTZEOHBM?=
 =?utf-8?B?VEw1RVB6MWloRndEK0daYlpqTlpCSHJuM2g3M2JtNWFuSkpuOHRPVnU1NjZD?=
 =?utf-8?B?VnJWRzA4bS9GaTZzcTJjZTE1d3YxTUtYcEtqMk5GUTlKYTQ4L0t2Tnd2WTRU?=
 =?utf-8?B?cXhsVCtIVSs2cXB6eVh0Q2FnSEJWWHpoRXZqRm1mY0NSWUJra0hYd0VCd25y?=
 =?utf-8?B?UUJYRzJDeW10czFMbkZFSDQ0RDJtdUhFRkowSWpqTTc2WE83U3d3WHFSZ3l6?=
 =?utf-8?B?V2NkK0kzbDY4ditkY05CaTg1Y3lhWkRzdE52dVdQbWIxbVIxcVZ6ZGwxMndB?=
 =?utf-8?B?amxCSnVKTmtVeGw4cWZZelJKb09VaGduVEE5V3gzQ1ZWZDNYNmk5MGJWNGU1?=
 =?utf-8?B?U0tkeUlIaGhuY2tjNDdLeGdMYkRLenhIeWR0eHYrcDdGYzVYbWViaFp5RGo4?=
 =?utf-8?B?a1N4ZkxVdmplbnBvU2lGNmhjbDdSSXR4dHk1L1NnTnAvdXFSZGpvaE9qTE11?=
 =?utf-8?B?ODd0aUZtS21YcVgyVzRsYmloYXZyWU5xeHhDOWE0WmUvUTY4dlVLcWVtaTMz?=
 =?utf-8?B?MEpjTGRvRERoYmtwNkFHNGZIdkppVHp1K3pJYWNHdittY21TekxhdVJnY29D?=
 =?utf-8?B?MTlQenI2UVBVams4UHV5VmNMWHhSTVI2T0hJSFlHb3JCOEh6STYwNTJvYmdG?=
 =?utf-8?B?b3JsNnA1VzNQYXk0ZFJ0SjQ0VzVQZWtiZENUdUs1TFlBQllkTXZGLzB3T1VQ?=
 =?utf-8?B?NWZzTWhGdld6YWg5RTV3RitoUy9QemR6QkNJS3c5MitxYnpOUEh4aXhjci9W?=
 =?utf-8?B?RjNIVjUvbDZtMUVQOGJKWWFFV3M3K1NXb1dkRTZNYWJIcDFoNlFiV2x6Q21v?=
 =?utf-8?B?OStmYkNSNytCUlhwM3dkSFJkSlg1NHQvOGVoRlgzaDl0M08zcldvL1E3UWRF?=
 =?utf-8?B?TVhoME9NUm5ZVWFYZ0d5VXkyUDgwdk16UkpxLzBybXJCUjNEVElLNHAyYUg1?=
 =?utf-8?B?cjQ5TGNqeGhhRXRrdVkrbXNwejlEY1lyOGJsTjNQTFhUb1dMVEVTMkZ0WjdU?=
 =?utf-8?B?MURiVm96Sk5yMmZkSzJPbHR1QWZNSFExYmpSdXJtYnd5V1JJVWpqeTZlYWYv?=
 =?utf-8?B?UktrK0pyOFNQQ3VHTjUydzNBNTFod2NBT0tOYWZFYWZ4QmRCQTIxM0JhWWxj?=
 =?utf-8?B?Y0dHc0xMUE9jRWkxSkNQNXJ4Y2ttTzJmY1UwQlBITGZ1dGY3RnZVN2YxeU11?=
 =?utf-8?B?UkEvK0hYa0pOWXVlTmcrNHVIMjBqa0pCL1QwRGo0NnRBV1RpRktGcjRsVVhu?=
 =?utf-8?B?ZVQzYVBySStyL2J2bXh2MVJDckpqOEYvcDlqbENES20yQnlXdzJRbnlwZmZw?=
 =?utf-8?B?TTNMVVoxbnRKd3o0MjJYMlhFUndvL0ZnRXF5aC9wS1M0K0dONEMwOXVIV05w?=
 =?utf-8?B?QmpJZGJSNXpXOVE1UmZYcUtKaW5XM0w2bTRIZ0VhYUVjYjhYQ0FoMVNvNUJM?=
 =?utf-8?B?bWlMUWxGY05jMmN4Si96K2RVbDFDZzBkOGVUb09aNWFVNlV3dHU2ZXZUVThI?=
 =?utf-8?B?YzJtZ3ZGUVpYbDg3WHBadVpNbGMwMzZQdlRvUDRnc0JBMDhKckNCdXlyVHJN?=
 =?utf-8?B?cWw2WFowNUxqWk1oMTJaY1liME5WNXd4WW9jWldFMHVOUklhb1E1VW1jcExW?=
 =?utf-8?B?QmFVSGdBKzZQNmxhZXBJSkxYWWNVeCt1eTJScTVnSXpRcm10WWNOZXNiOTBt?=
 =?utf-8?Q?R15M61AK++Q8pXO4gMwQB/VKK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a474caa-b82b-4dc3-f482-08dc1c20e635
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 14:38:00.9758
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hFbdfY7KStR0xMtNyto8/QZ6PcUjJltMF+DOISIB2/y9O6aI30iBX/54+uXR8jPjRHM4pVr9kWAL8HCZUM3MUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4385

Hi,

On 1/23/2024 06:41, Cong Liu wrote:
> amd_pmf_get_pb_data() will allocate memory for the policy buffer,
> but does not free it if copy_from_user() fails. This leads to a memory
> leak.

Thank you for the fix and looks good to me (just a valid Fixes tag is
missing.)

Fixes: 10817f28e533 ("platform/x86/amd/pmf: Add capability to sideload
of policy binary")
Reviewed-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>

Thanks,
Shyam

> 
> Signed-off-by: Cong Liu <liucong2@kylinos.cn>
> ---
>  drivers/platform/x86/amd/pmf/tee-if.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
> index 502ce93d5cdd..f8c0177afb0d 100644
> --- a/drivers/platform/x86/amd/pmf/tee-if.c
> +++ b/drivers/platform/x86/amd/pmf/tee-if.c
> @@ -298,8 +298,10 @@ static ssize_t amd_pmf_get_pb_data(struct file *filp, const char __user *buf,
>  	if (!new_policy_buf)
>  		return -ENOMEM;
>  
> -	if (copy_from_user(new_policy_buf, buf, length))
> +	if (copy_from_user(new_policy_buf, buf, length)) {
> +		kfree(new_policy_buf);
>  		return -EFAULT;
> +	}
>  
>  	kfree(dev->policy_buf);
>  	dev->policy_buf = new_policy_buf;