Received-SPF: pass (google.com: domain of linux-kernel+bounces-35464-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 23 Jan 2024 09:39:57 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mmap: introduce vma_range_init()
Message-ID: <20240123143957.ce6h5cqx6yusds5w@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Yajun Deng <yajun.deng@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
References: <20240111021526.3461825-1-yajun.deng@linux.dev>
 <20240122220031.pwiravglee7o7k34@revolver>
 <20240122154031.b710f834b14d9027176f439a@linux-foundation.org>
 <20240123001830.glqdmrv2qc56zfpc@revolver>
 <2a1d6a9b-f486-44c8-6d1d-e6bab4dc3ced@linux.dev>
 <20240123031906.pwbjuzdpl6hqiptj@revolver>
 <11da8b32-9946-9f7c-95fe-f6254b4f6e99@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11da8b32-9946-9f7c-95fe-f6254b4f6e99@linux.dev>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?fm2rjZfqY+C32cvd5Aet9Ay0RYgHAFGhKidMvny0Md3vG+b/doI4LmWzShRX?=
 =?us-ascii?Q?DWZcvK6myHZ4oLRZ3xAxVpvHIVjuccrPKjCVoo52vxeXGqH2UtWFI1hOBZ3c?=
 =?us-ascii?Q?QFxv4RJM+ns5j44QbG1XKD8vf9D2wBHuc9YYcjJxupzBfkiz0h/gw92Lfhea?=
 =?us-ascii?Q?Um3Pk5xmTwyLYB80ZMhmfqa+lyIACpjbG0qzxV0uCpdzHpwZ/pmHLwU2VOh1?=
 =?us-ascii?Q?6FbhFWue8kdeoG923ov+Ut1WusIqueZTpCnBdDt0+q61ysoOASYIkA666OhW?=
 =?us-ascii?Q?fkJ42hHR+413/cmsaaXIH9zXiwnpjxEdd+lqCov85ZOJh874RQq2SfUJceT8?=
 =?us-ascii?Q?MTFLtenIwaoZ742m2+B7RRXiR+eI3HCzAW15DADG+ZfhT5DaR23kP5sdkmu0?=
 =?us-ascii?Q?3XHfEJ5HEJg92prH0FLDnySZcMyAEdoSSl4VV6MyM9bMpqW78zZou4XhiyoQ?=
 =?us-ascii?Q?wXFVndLjEyGSwI2wLOOxwCM014WfCmcHiliovdVIge3f85GSrPJgLd5h46LZ?=
 =?us-ascii?Q?+O0uEG5co+NF1wbmTEl5XhnIl8ecRJHL6tu4dQgCb5VqS2NPj6pn/4FYsIyW?=
 =?us-ascii?Q?HWFCkrOXP93twjRSnPf1mIpZnoiQ5A4MANVAoD55Rj+zaCZDBvdXjxLonef0?=
 =?us-ascii?Q?7ouLZnN8c9N5rPEpCE1N/lIT3RhJINvQtkEBfsTFZoh5XGRjAMtMQui3Pk91?=
 =?us-ascii?Q?am78yO0t/9TT8vd0w2vFC/h2NAltdeUpdV+0IblrTqjPRU3eyFgR6Ehc6B3A?=
 =?us-ascii?Q?k7Vc/R/8P3lRy4SpgAIcyHE9HGPHkbgwzgWjjKDPsgRsXYiMYoMy4Qswoxux?=
 =?us-ascii?Q?8yDJ529F+zFH9kw0EW8LXMyufDg6dKnWMMZpfMzuQpMcto69UIMyd8n9ZvBD?=
 =?us-ascii?Q?mcGT8VozhARj0qHNFwKO8GTMkkIqRrZSejCDfq0AgYRqjVVmXtYwkcup8arL?=
 =?us-ascii?Q?vcoRZpZHzX13ixPLgIG0XsEyzl4rEaJjADgx8DrIia8WIaBfKglSvBx4B6SX?=
 =?us-ascii?Q?Vo47YqHLoLAfYgg2GBk2vf3AWmcu0whyYsubTGwHr/iaZ/Ep0KA9hP31XoE7?=
 =?us-ascii?Q?YGPGymqds7vw/ZjSEfxhSwRjWPTroQPbwos9tEnlpik9jJlSGk5aMCQskctr?=
 =?us-ascii?Q?KmeoG6ozJbkvgFOzErR5lHjWlYla0rtVE/QCRXV/4PPmOdHYyn9jHk+/2wT7?=
 =?us-ascii?Q?NyO6RfrZtvDMnnso+MV5qCaAB0qhvU4BC8b51t06wEV//AN/Z+mJ57DjabTu?=
 =?us-ascii?Q?ZSONt1IostnzX2m+8AIAgs/rykUhA9fN6m3V5TCN5m/lnyfs0vTEzVMcEX/z?=
 =?us-ascii?Q?FPoGzCYT3nn1yT6HqpGnJGPp/WW4xGed1Fp9LDPKgcz9B/ieOPQpIuBYIy1S?=
 =?us-ascii?Q?nvBBgqbEzowr3t36ztsJ3RlQutXke9EaCh3rEoXGapLx57Nb1SapVjt6rQ8R?=
 =?us-ascii?Q?gNeO3aZFW+feE/IoAkt2KRN+res/QM28+GAO4TtBV9ZYBWfkQALwBC3Q0HhB?=
 =?us-ascii?Q?Nk8zrbqrWsGvdOf9PHzWppfX2X/NMHxZZ43P3CD9T655ImXbeUoK+enOjTX4?=
 =?us-ascii?Q?l7jELPqu0ul5mfQJdXyU3ylD7amyAfCGPeWyH27L?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	wgP5VdNj0RjoxgX8Vlr88r56+7SCHAr27Othy/X6ko2dDqhsMAiohJvWxBsGbgDjYi6kFGQrEOLxsn94qtRI+zdlkuECg9lZS6wJlsN1y8i06RXTMBxUaf1xJimBgkbq3aspawPI1rldN8uSP49vQWBB/ZQVva4oerRQ7BHx7NM7rhAJB5W7fSCtXFIJTh7Jkow4yj5F9KShFNOB5MGnzPiQ/yoQ3H4d6JIB/aL+WhqS2PMNSwKhY1rq/7BtHNK72Zblm2FJgmwzCZFuPV8lL7aaEpaKC6dSsa/SEGOpSNr7rtsgVlAMG9apoVryhh65FY0y7bzpGoXg50wfrzluJbi9sTwlEjJDLnGSdkAQHyXVl9+NwF6FQe0vtwRgAD7fxQ19yPaqyykI8OLI20In1XkhhOBvbd9vGYrnNXVRxeQHipUta/38f7ygTVnPJhQgKMbJcGS9qxPyfTO7I5+/W7LcpZRaQX/6mSOcJc/kugD6hMDJaVidjpJ48+Zif7O4JcRswEHcSBulDrn3iCZjNg4Q/z88CCTRaXfzVwhkY7yCvEKqj+k+ou5oCifVDTAYVa4DzSJRi7nQSha4i2UYicSCpp7oXnkttmszFHlFDiM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2314e11e-6836-4cec-ab03-08dc1c212cc8
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 14:39:59.2226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4XYtRHGIUfw4LW4O7AEI6ayZdcZfErV53Ksr7Mawr6RIlMBcuwE2e2fOAeNmQdABYgfjmfHBVU45CM1iPRJ01w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6133
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-23_06,2024-01-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401230106
X-Proofpoint-GUID: GRPgeYTcvUxgn9DQSqIo6Z-2tl7rUD5O
X-Proofpoint-ORIG-GUID: GRPgeYTcvUxgn9DQSqIo6Z-2tl7rUD5O

* Yajun Deng <yajun.deng@linux.dev> [240122 22:41]:
> 
> On 2024/1/23 11:19, Liam R. Howlett wrote:
> > * Yajun Deng <yajun.deng@linux.dev> [240122 21:23]:
> > > On 2024/1/23 08:18, Liam R. Howlett wrote:
> > > > * Andrew Morton <akpm@linux-foundation.org> [240122 18:40]:
> > > > > On Mon, 22 Jan 2024 17:00:31 -0500 "Liam R. Howlett" <Liam.Howlett@Oracle.com> wrote:
> > > > > 
> > > > > > * Yajun Deng <yajun.deng@linux.dev> [240110 21:15]:
> > > > > > > There is a lot of code needs to set the range of vma, introduce
> > > > > > > vma_range_init() to initialize the range of vma.
> > > > > > > 
> > > > > > > Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> > > > > > > ---
> > > > > > >    include/linux/mm.h |  9 +++++++++
> > > > > > >    mm/mmap.c          | 29 +++++++----------------------
> > > > > > >    2 files changed, 16 insertions(+), 22 deletions(-)
> > > > > > This isn't a whole lot of code, are there others?  We're losing code
> > > > > > clarity in favour of saving 6 lines?
> > > > > > 
> > > > > Oh.  I thought it was a nice cleanup which made things more clear.
> > > > I'm not totally against it; that's why I suggested the changes below. I
> > > > think a name change would go a long way for clarity. It's not as much as
> > > > I though it would be though.
> > > > 
> > > > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > > > > > > index f5a97dec5169..abb4534be3cc 100644
> > > > > > > --- a/include/linux/mm.h
> > > > > > > +++ b/include/linux/mm.h
> > > > > > > @@ -3516,6 +3516,15 @@ static inline bool range_in_vma(struct vm_area_struct *vma,
> > > > > > >    	return (vma && vma->vm_start <= start && end <= vma->vm_end);
> > > > > > >    }
> > > > > > > +static inline void vma_range_init(struct vm_area_struct *vma,
> > > > > > Any reason this can't be in mm/internal.h ?
> > > > > That would be good.
> > > > One other thing, do we trust this to be inlined correctly by the
> > > > compiler or should this be __always_inline?  I'd expect it to be okay as
> > > > it is, but I've been proven wrong in a perf trace before..
> > > > 
> > > Okay, I would take __always_inline and put it in mm/internal.h in v2.
> > I'm not confident in this suggestion as the rest.
> > Please rename the function when you move it.
> 
> inline is a suggestion, __always_inline is mandatory.
> I think __always_inline is better if we're demanding.
> 
> > > > > > vma_range_set(), vma_set_range(), or just vma_range() might be a better
> > > > > > name?  My thinking is that some of these are actually modifying the vma
> > > > > > and not just initializing it, right?
> > > > > I'd vote for vma_set_range().
> >                        ^  This part, use vma_set_range() please.
> 
> Okay.
> 
> 
> By the way, I sent another patch with ("mm/mmap: simplify vma_merge()")
> subject a few days ago.
> 
> Please comment if you would like.

Oh, okay.

Can you please Cc people on these?  I almost missed this one and I know
several other people will be interested in the vma_merge() patch
changes.