Received-SPF: pass (google.com: domain of linux-kernel+bounces-35484-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sudeep.holla@arm.com,
	cristian.marussi@arm.com,
	jdelvare@suse.com,
	linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH V2] hwmon: scmi-hwmon: implement change_mode
Date: Tue, 23 Jan 2024 23:05:26 +0800
Message-Id: <20240123150526.3615901-1-peng.fan@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AS8PR04MB9206:EE_
X-MS-Office365-Filtering-Correlation-Id: 5c97c1a9-dd97-4610-4157-08dc1c242235
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	twLi7Ef0qEhAcIorvnhaZ9+OrepcQv9pcNQg7De5cWOZKYXJLXJeBQfLq6Yi6D+y2K07L98lOR4xlLG3JDhH99HBpnpOnA6fmEToBQfVIvCNAdTvzu98PbWGPwUeaqi7WjDFbn1JsXDNz+4/NdAwKHr268vqWfYnl4fXO9YIgd4K8ix2KwH6XCx7mmW5nKNR71A4IfjAjZ7r6Sku3mws6GJ4UfVnFghTOB4tZY8+mwqsRd6cR93fsScuT+b9DFTlrU1S6nND9ska1D48AZQFD79ea7MzeW+FZta5fYtU4tikXoOqmaE9huOW4UdUAApzB8C6gkC+O7rpeFWffRceJwS5Z558Qi+khqZij+zZXqLtG4wPfQuuyyGKRTgEN5ZwsyHLq+n8/szljj5CkNAbChsDFKhXdpdNNGGZkTPcGfWIXgglLH8g0IIMLX9rgMQDBSOTQVnwkA3TOigXgvoXqSjaU+GboWYX7o6wuAnX3ObH0HvtjbeMCXDRbwi0B0uSDSSR56ompUBqS11qtPiRiQrSr5+JdYMUhlNuFisP1yBvW7eu8jx661cnZ49LzG9XOW+U39Z6OKF2ZNC8cyKeKqihf/lFeUYvb2uhLvXbw1kvqVF6+QcFlUqMmcdE1O7e
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(376002)(136003)(396003)(39860400002)(230922051799003)(451199024)(186009)(1800799012)(64100799003)(1076003)(83380400001)(26005)(4326008)(8936002)(8676002)(5660300002)(66946007)(66556008)(66476007)(316002)(86362001)(38100700002)(478600001)(6486002)(2906002)(6512007)(2616005)(6506007)(52116002)(38350700005)(41300700001)(6666004);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CHOQqHHCr467MIRzCrR1HMLrtUXPx/5JsHA0NqDmLpeNUYtL0PwHwHBXINu8?=
 =?us-ascii?Q?lw1K3jI1Z8jQxvy67gQw9M/u8hQSgFoXhQqzC+evw4SAHK1ofUE1BSuXy77l?=
 =?us-ascii?Q?aAqj03HlAtyvc5MUjxAzjNMzGqSdSLf/xuqKlmXqPAc1XTg8Zr/iV+U5WS2X?=
 =?us-ascii?Q?ILBJdoai5YspF4C3p94UgF3a0CTmzt4Hun/qXjCrY0edn3irZSnDoBrGl+Pk?=
 =?us-ascii?Q?HE1F5YN4r8tZNTCIshk2GJe+7paZwsw8lqQf3Aw9wLIDorsPkebi4hXcBg9k?=
 =?us-ascii?Q?07o08k1sjTQ6vh6Ch7dTdCSXSTWUh4uqlo0VNZ/la0tF1hD9H2AEFLBDUo3o?=
 =?us-ascii?Q?GdMjt3HbnDIjiGO98S5Ac1JC2TKp+IPZCZ+RGe0OX6p8uMLIqxRoTJqFendM?=
 =?us-ascii?Q?tdTo6hlA1e4ey7GE0JGMAQSmcw46DYasj/RtGQzMAwajQJlQ8cDRKeGmUA/k?=
 =?us-ascii?Q?gptx9mg2RIbHwcYT2oXv1QFw8VWXjEwEvQWu3WjobYO4U7pp0loYCgGV0gsF?=
 =?us-ascii?Q?5ymsvCLExCqUnAruKrffZQPfzMSFtispDYjC36H9y9Gy2kNXEMip6f7xf7Bn?=
 =?us-ascii?Q?aSTuQ8bozL3BE0PGtQ/i8gC1aJYWBALVezq8Q9zEbRN0ZtwQUbo2j7CCV+HA?=
 =?us-ascii?Q?CT1ABmRsXKVPtBDI9heybpwd2L2U5p1d78rkx2D3o/zM9wuk4u/w1UHdWW5N?=
 =?us-ascii?Q?hP9BAJvb6y2M1oGGOg/LqdVQwYTvzztjZroWMM3+asWfqZX2xdcxPep+ZR6L?=
 =?us-ascii?Q?b2FDMw32dNf0/MvKCC0oS5aakKr5GzVvFsyN9rEAZG0+povrd5yZfq0JIJPk?=
 =?us-ascii?Q?kEp1i4HL89WuiMjbimnPrM7VRh/JPxcWxgFQwV6wsJJ14X947QoSJ0FatXZS?=
 =?us-ascii?Q?GWtzhvPYbAoZHjyIwLaGvqmYpDsWPNVjKzvBOmIEju36som4f6gCHt+ac9wj?=
 =?us-ascii?Q?iaZPVHXdgcXJ+3aue7QBFPyj21tnoDApelFy7x+/74P28fbjnbeSv0Au6MmJ?=
 =?us-ascii?Q?eJ1Jgj9OFoCykLzFAgagYshCjVpForkfe3Hf/JBsMlMoVJgw4pZedJ8FZ0En?=
 =?us-ascii?Q?r2mjnZZjmIxcx8Yz25FcUmtRbGc3uu0Yk7nAixT6TRccIiaJcCAMWMEzTsMv?=
 =?us-ascii?Q?dAPKZoIQ86heiXZrAg26Gl8h/HX7dqFMezWuk9lnyDpTzVBTpjXpHDhXMlT3?=
 =?us-ascii?Q?3FUky5snES8hk3x+IotBevQh43f1nUijcI0eYtTZvMfRn79IabMT6x3yrMeO?=
 =?us-ascii?Q?4j5jvdaMkrCLx8agok3UPefwSi5kXzSjWdqIIRFsykvcOvW+hKJnkoZaeT6T?=
 =?us-ascii?Q?TXBBnt6RKSxj4HKTVTGEaL+bPsRamYqVGcAI+mQ8hydsKIM1reD29Ef6U6JN?=
 =?us-ascii?Q?OPWWCjUaUL5N1aVrKf3Na8sYBuYJeLTl8rNGyd7sjKWupRKG6kzl/TOHynam?=
 =?us-ascii?Q?X4hUB239Kl5Y7y6hL3EYOwMuveaVTacL7O9xSYHACZBQi3cp/S/IUtQZlSdl?=
 =?us-ascii?Q?7ST9Jz3dzV+NmCdKIiMRWsNqKZK+IkjwQiZEuLU3YTjr2Bx458TMf2X2FRPv?=
 =?us-ascii?Q?VjWFsK1JVKPsBRsnb5k7TKLS+Imvm8mEM1VdrbZX?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c97c1a9-dd97-4610-4157-08dc1c242235
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 15:01:10.1689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tmU7V+pO3neIX91TTdWnUCAu8mZfJrT3ooHXlh1DLv9qrIlaZNhwgtaOYRxjU80hZoPySRQu7ElEvf0F8qDp+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9206

From: Peng Fan <peng.fan@nxp.com>

The sensor maybe disabled before kernel boot, so add change_mode
to support configuring the sensor to enabled state.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Use SCMI_SENS_CFG_IS_ENABLED & clear BIT[31:9] before update config(Thanks Cristian)

 drivers/hwmon/scmi-hwmon.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index 364199b332c0..913acd1b137b 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b/drivers/hwmon/scmi-hwmon.c
@@ -151,7 +151,39 @@ static int scmi_hwmon_thermal_get_temp(struct thermal_zone_device *tz,
 	return ret;
 }
 
+static int scmi_hwmon_thermal_change_mode(struct thermal_zone_device *tz,
+					  enum thermal_device_mode new_mode)
+{
+	int ret;
+	u32 config;
+	enum thermal_device_mode cur_mode = THERMAL_DEVICE_DISABLED;
+	struct scmi_thermal_sensor *th_sensor = thermal_zone_device_priv(tz);
+
+	ret = sensor_ops->config_get(th_sensor->ph, th_sensor->info->id,
+				     &config);
+	if (ret)
+		return ret;
+
+	if (SCMI_SENS_CFG_IS_ENABLED(config))
+		cur_mode = THERMAL_DEVICE_ENABLED;
+
+	if (cur_mode == new_mode)
+		return 0;
+
+	config &= ~(SCMI_SENS_CFG_UPDATE_SECS_MASK |
+		    SCMI_SENS_CFG_UPDATE_EXP_MASK |
+		    SCMI_SENS_CFG_ROUND_MASK);
+	if (new_mode == THERMAL_DEVICE_ENABLED)
+		config |= SCMI_SENS_CFG_SENSOR_ENABLED_MASK;
+	else
+		config &= ~SCMI_SENS_CFG_SENSOR_ENABLED_MASK;
+
+	return sensor_ops->config_set(th_sensor->ph, th_sensor->info->id,
+				      config);
+}
+
 static const struct thermal_zone_device_ops scmi_hwmon_thermal_ops = {
+	.change_mode = scmi_hwmon_thermal_change_mode,
 	.get_temp = scmi_hwmon_thermal_get_temp,
 };
 
-- 
2.37.1