Received-SPF: pass (google.com: domain of linux-kernel+bounces-35494-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 23 Jan 2024 07:02:59 -0800
From: Breno Leitao <leitao@debian.org>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: mingo@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86/bugs: spectre_v2_user default mode depends on
 main default
Message-ID: <Za/VIwfxh+dyyfb8@gmail.com>
References: <20240118173213.2008115-1-leitao@debian.org>
 <20240118173213.2008115-4-leitao@debian.org>
 <20240123000431.rqs5g6gjpq5uckcs@desk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240123000431.rqs5g6gjpq5uckcs@desk>

On Mon, Jan 22, 2024 at 04:04:31PM -0800, Pawan Gupta wrote:
> On Thu, Jan 18, 2024 at 09:32:13AM -0800, Breno Leitao wrote:
> >  static enum spectre_v2_user_cmd __init
> >  spectre_v2_parse_user_cmdline(void)
> >  {
> > +	int ret, i, mode;
> 
> mode is being returned, it is better to match its type with function's
> return type "enum spectre_v2_user_cmd".

Agree. I will update. Thanks!