Received-SPF: pass (google.com: domain of linux-kernel+bounces-35247-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 23 Jan 2024 13:34:19 +0200
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Michael Jamet <michael.jamet@intel.com>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Remove usage of the deprecated
 ida_simple_xx() API
Message-ID: <20240123113419.GN2543524@black.fi.intel.com>
References: <7fce4c8c4345d283dbfadd3cea60fdc49f9ca087.1705007397.git.christophe.jaillet@wanadoo.fr>
 <20240122112922.GH2543524@black.fi.intel.com>
 <d11852b1-6d9c-4ced-83cb-96e753edd45d@wanadoo.fr>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d11852b1-6d9c-4ced-83cb-96e753edd45d@wanadoo.fr>

On Mon, Jan 22, 2024 at 06:57:42PM +0100, Christophe JAILLET wrote:
> Le 22/01/2024 à 12:29, Mika Westerberg a écrit :
> > On Thu, Jan 11, 2024 at 10:10:21PM +0100, Christophe JAILLET wrote:
> > > ida_alloc() and ida_free() should be preferred to the deprecated
> > > ida_simple_get() and ida_simple_remove().
> > > 
> > > Note that the upper limit of ida_simple_get() is exclusive, but the one of
> > > ida_alloc_range()/ida_alloc_max() is inclusive. So a -1 has been added
> > > when needed.
> > 
> > Looks tood to me but wanted to check if you tested this on a real
> > hardware or you just build tested?
> > 
> > 
> 
> Hi,
> 
> It was compile tested only.
> 
> Transformation has been done with the help of the cocci script below.

Okay that's what I thought too. I ran some testing on a real hardware
and did not see any issues.

Applied to thunderbolt.git/next, thanks!