Received-SPF: pass (google.com: domain of linux-kernel+bounces-35614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Jan 2024 16:02:34 +0000
From: Conor Dooley <conor@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Seven Lee <wtli@nuvoton.com>, lgirdwood@gmail.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	conor+dt@kernel.org, YHCHuang@nuvoton.com, KCHSU0@nuvoton.com,
	CTLIN0@nuvoton.com, SJLIN0@nuvoton.com, scott6986@gmail.com,
	supercraig0719@gmail.com, dardar923@gmail.com
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"
Message-ID: <20240123-brewery-roving-b9ebc70468f4@spud>
References: <20240122095650.60523-1-wtli@nuvoton.com>
 <20240122-daunting-woof-19fac5689bb2@spud>
 <04945799-eded-42f9-b8fa-8907be44c400@sirena.org.uk>
 <20240123-bottle-elevating-9fbba5424014@spud>
 <185f3912-5a92-4ef2-aac4-0df8363d8727@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="CZOKZjrI+J1e9HlH"
Content-Disposition: inline
In-Reply-To: <185f3912-5a92-4ef2-aac4-0df8363d8727@sirena.org.uk>


--CZOKZjrI+J1e9HlH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 01:06:45PM +0000, Mark Brown wrote:
> On Tue, Jan 23, 2024 at 08:34:03AM +0000, Conor Dooley wrote:
> > On Mon, Jan 22, 2024 at 07:40:51PM +0000, Mark Brown wrote:
> > > On Mon, Jan 22, 2024 at 06:00:14PM +0000, Conor Dooley wrote:
> > > > On Mon, Jan 22, 2024 at 05:56:49PM +0800, Seven Lee wrote:
>=20
> > > > > +    enum:
> > > > > +      - 0 # VDDA
> > > > > +      - 1 # VDDA*1.5/1.8V
> > > > > +      - 2 # VDDA*1.6/1.8V
> > > > > +      - 3 # VDDA*1.7/1.8V
>=20
> > > > I would also rather than this enum was used to have sensible values=
 for
> > > > the enum itself (which I suppose means strings here), rather than t=
he
> > > > register values. Seeing "nuvoton,dac-vref =3D <2>" in a devicetree =
is not
> > > > very meaningful IMO.
>=20
> > > Do you have a concrete suggestion for how to more clearly write these
> > > directly?
>=20
> > I would use what's been given as the explanation comments for each of
> > the current enum values in the patch.
>=20
> Given that none of *, / nor . are usable in defines that's going to need
> a bit of massaging...

At the end of the day, if it is too painful on the driver, then I'll
live with another enum. This is one of the worse cases of this sort of
enum that is clearly a bunch of register values, given there's not a
"nice" explanation for them.

--CZOKZjrI+J1e9HlH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZa/jCAAKCRB4tDGHoIJi
0rzSAP9jk8KYC7hIX1HdXqnBFVDfINXYg5zeasUhnLdvnkiJNwEA63S74iCvYyqD
L2y649pIe19v3rQ2TUGetH88CEsCxgI=
=VtcS
-----END PGP SIGNATURE-----

--CZOKZjrI+J1e9HlH--