Received-SPF: pass (google.com: domain of linux-kernel+bounces-35613-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <23c5fac1-ebf1-4e5d-9691-7b87060b0df3@nvidia.com>
Date: Tue, 23 Jan 2024 21:31:38 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V4] PCI/MSI: Fix MSI hwirq truncation
Content-Language: en-US
To: bhelgaas@google.com, rdunlap@infradead.org,
 ilpo.jarvinen@linux.intel.com, tglx@linutronix.de
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 treding@nvidia.com, jonathanh@nvidia.com, sdonthineni@nvidia.com,
 kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20240111052814.713016-1-vidyas@nvidia.com>
 <20240115135649.708536-1-vidyas@nvidia.com>
From: Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20240115135649.708536-1-vidyas@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RkRjK1hQeGZPOXNZeml5QW11MkVza2hodFFnTURaZk81VlNOSlJ1WGtyQktS?=
 =?utf-8?B?WjJjU2U4VzFnZC9RNGhqV0craEFzbVNCRlhoK05rRW9Wb3RidUFRY1YzYlhY?=
 =?utf-8?B?dDJkTnRzRFhONTkvQUptbVh1cGlzMVgrQ0sza1ZQd1U5dUNlRzlaMmRuYloy?=
 =?utf-8?B?N3g2Z00vWVhIa1ZsL05HWmFrVDRuVmtMRW93Y2ZwblkvK1N1eHYvK3N2eW5I?=
 =?utf-8?B?Y0YvODBCK3IrZDFCeHN2QUt0dkRIaFFLYW5ZREExSi9RTjhUYXUrNy9VL3FO?=
 =?utf-8?B?L1NFckFENit2c0RvQnlqVG1qOXBKY0hPQVhzdEFOOVNnTVNxVmhjdUMyS056?=
 =?utf-8?B?M04vQ294WkNZdWdIQnRZaUpKdis4ZExQdjAwSnpyVkV5NDN6QjJiempZNlpJ?=
 =?utf-8?B?eFAxdytZTExYam1VU212bExYMEJnWGhicmpiTkVIbHp2SXJoV0lyVnhkQ2Fw?=
 =?utf-8?B?eXJDR2ZpVDZHNkQ3cU9WZUczVi9iNUNKNDNkOTg3UVgyMDBuS3kxRFdrWnpo?=
 =?utf-8?B?VzBZelJ6V2F5bFRYa0xlT0ZnbkMvYkR1Rk5ISkVtTFZrK0JHNitxa1Rsam1z?=
 =?utf-8?B?U1dDV0FtQ3Zwa3JiMnNhcnU3YmZ4Z1VpVXlTRytlTHk4R1ZUVGxkaXE3eElq?=
 =?utf-8?B?STdYMC85YjlRaEVIdWFibFByZ0ZYZktvenA2eHZtenFOQmhFZk11R2w0dWFk?=
 =?utf-8?B?WVM0aEJsQVZoY3VtSFhqaDNDSnJDRzV6ZEtlOE9TNlNSdzdsa1FkRHBmRGZ6?=
 =?utf-8?B?dVZoVGgzaXpNYVpxKzhNQm1BUUNEQUd5UlF3ZVdGd01kWXdhdlN5dW04U1BN?=
 =?utf-8?B?WWh6VjJCcHRsa1dacmJubStNVXNnZmJqOHZkUU9waVFaM2RuK1lNYnY1a0xB?=
 =?utf-8?B?dkYyR0t0Uy9JaEtCUGROWTAzeXhFZUNjMXRNeVg4NlpCNXRWVGNCckhFTVdH?=
 =?utf-8?B?em5YRlYvRURuQXRQWTFVdGJRaDNVd2x4emdzZ1JCSFVxMytpV1ZKemRpNTc2?=
 =?utf-8?B?bGZEQWprWHVrRDJCVnR3V3hsUmVkM3lyRzNpZzFBZi80Z0JLYXZtaVhRTXZD?=
 =?utf-8?B?VWprZmhoZXBrV2MvTGF5bVFvZHM4TGhORjVId2dRcjljdGJtdE9VZGM4dDBq?=
 =?utf-8?B?Y3VKYmMyZGxMM0J0U1lveWl0aTVJVkFpbER3S002OFJNTXhtUFZZckIzOUZa?=
 =?utf-8?B?QXlzdXlsZUxOeUZFTUxPTW9tU0JabmdXcUVsalJZblFKMzdrd0x1WjlLVGth?=
 =?utf-8?B?NTZ0c3RwU09pNkQ3NnVMZnV2WVFJUWxKUEFWL1FTU3pUSmxrSFUrQW92cFBO?=
 =?utf-8?B?SytPdXRDQWlBS2lxRVlhK2xSbDJQeURKM1pqNm9IbG83VWlWcWNGVUNIM3I5?=
 =?utf-8?B?Ym13UWFCUEdQWEdlQmdhWnZBR2p3bTI4dVRFQ2VvbFhJMXBHbThMR2tTa2hP?=
 =?utf-8?B?MnhtWG52eGMzczJVYzdITXp2Y0VvN3Bldm41bW9xS1M1TnNzQWJVdlNhRnhC?=
 =?utf-8?B?ajk1VHExbXRJeWZlTXFKOTZ6WVV1WHE0RXp1RW1ibkp1a2V4d01CT3Z1YVlo?=
 =?utf-8?B?NnUxbVo5K2cvZS9UakdKenRMR0RIZk5RdzV5dnNadHZCSEViWWE1N1k2Qitt?=
 =?utf-8?B?eHJOdDZWVWh0ODdNdDdsQmJFcWZzd2VacEp5UTJ4WmFYcmJuYS9PUDJPaDM5?=
 =?utf-8?B?UjhsRm9PRTBhaTZKNUNuUjVkVVJiMXNHQ0tnMTdLaG0waWVsaHJKOWprNFFO?=
 =?utf-8?B?bXZ5djR0NU84YjBMcEtZcXN2U3Vjb1R2RDBUUzhZK294YTNheDhERU5YQmtv?=
 =?utf-8?B?TkhwS29ISXQxUGZlYlltQ09zV0ZJVy9qbzRwdmhOYzd1WDJrd1NCOVlsNWFh?=
 =?utf-8?B?U2l1TW0xc2pWbTF4cFRTZ1NsQlovemtBbUN2RWJsbFU1cGlyUGgxUnJZU1Bk?=
 =?utf-8?B?d0JMak0yUjVHUENodDU3L3dXM1VTeVU1T09kYXlNMHVoYy9lQnlZcEFnSmYy?=
 =?utf-8?B?eFljTWZreVQvNU5VTjVhOE0zTVBaQmtUeEkwVmZOVnY4bGIzUnc5WUg0bjdL?=
 =?utf-8?B?YUswcXFxdXR4enAvREJZdUtPa21BY05aeVZuZlRBMWkxTUZMN2lZNUp6a1Yw?=
 =?utf-8?Q?oRQsxzV0ebqFaX3YFudnd61iJ?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d211196-73a7-408b-71eb-08dc1c2c99d7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB6674.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 16:01:46.9263
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LI/gLgw+6oaGkj42CUtskThIEpsenxWOpje1ggmiQR4Tg0LVAtg6C+ZyxfmM7955C9shHd5WCl5TIC9Im50yDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5375

Hi Thomas,
Does this patch look fine to you?
If yes, would you mind giving an Ack?

Thanks,
Vidya Sagar

On 1/15/2024 7:26 PM, Vidya Sagar wrote:
> While calculating the hwirq number for an MSI interrupt, the higher
> bits (i.e. from bit-5 onwards a.k.a domain_nr >= 32) of the PCI domain
> number gets truncated because of the shifted value casting to return
> type of pci_domain_nr() which is 'int'. This for example is resulting
> in same hwirq number for devices 0019:00:00.0 and 0039:00:00.0.
> 
> So, cast the PCI domain number to 'irq_hw_number_t' before left shifting
> it to calculate hwirq number. Please note that this fixes the issue only
> on 64-bit systems and doesn't change the behavior in 32-bit systems i.e.
> the 32-bit systems continue to have the issue. Since the issue surfaces
> only if there are too many PCIe controllers in the system which usually
> is the case in modern server systems and they don't tend to run 32-bit
> kernels.
> 
> Fixes: 3878eaefb89a ("PCI/MSI: Enhance core to support hierarchy irqdomain")
> Tested-by: Shanker Donthineni <sdonthineni@nvidia.com>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> V4:
> * Added extra information in the change log about the impact of this patch
>    in a 32-bit system as suggested by Thomas
> 
> V3:
> * Addressed review comments from Thomas Gleixner
> * Added Tested-By: Shanker Donthineni <sdonthineni@nvidia.com>
> 
> V2:
> * Added Fixes tag
> 
>   drivers/pci/msi/irqdomain.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/msi/irqdomain.c b/drivers/pci/msi/irqdomain.c
> index c8be056c248d..cfd84a899c82 100644
> --- a/drivers/pci/msi/irqdomain.c
> +++ b/drivers/pci/msi/irqdomain.c
> @@ -61,7 +61,7 @@ static irq_hw_number_t pci_msi_domain_calc_hwirq(struct msi_desc *desc)
>   
>   	return (irq_hw_number_t)desc->msi_index |
>   		pci_dev_id(dev) << 11 |
> -		(pci_domain_nr(dev->bus) & 0xFFFFFFFF) << 27;
> +		((irq_hw_number_t)(pci_domain_nr(dev->bus) & 0xFFFFFFFF)) << 27;
>   }
>   
>   static void pci_msi_domain_set_desc(msi_alloc_info_t *arg,