Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp591756rdb; Tue, 23 Jan 2024 08:38:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBqwrD0EbE7EuRm4X+vN+wbocgkBWs1odPsPIA5GR29KNmNoACDRGWccCqB/lcWjPypr3l X-Received: by 2002:a17:90a:6407:b0:290:4cff:ab07 with SMTP id g7-20020a17090a640700b002904cffab07mr8105492pjj.42.1706027896841; Tue, 23 Jan 2024 08:38:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706027896; cv=pass; d=google.com; s=arc-20160816; b=ni4NhTjznPH020Gc2L113tXn5B33NrZEL6eV94tSWsdREV+r7NUJHzNSl2i5GMuxKA YkA4hP1+sW8w7DYCIbJoLNOGlujgJmALEDhv8BDQGQNlYQtX4Qi0VSDyIuaw8oeNCUNV tqlXcCiI946G9qOjrewcyPkzEXiCmjanDdf/pLFmZEHqO6z7fcsV8Uw62Ubpqg0QBJRh NsgfwRzTlLFPe6OElQt4BQjrTWBGWjDlzHuqO3SVfpbrSDiNYPPoIjBJxGugkhTcpX+Y 5x+ffOQjelRzkYRzd4OxHc/7X+nc/EJ8hBf/4FttrNvUYeroxcM0E95on1UI3F9YPX/Y /Q5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; fh=hFszAG3EAJn0PIbm+FFEwn7FKzHwcLkv0stmir3vaHo=; b=D0XuX/iOKNix+vt8ViMIuQWG7Jc8ctSHYpZA2SMwjdutCi6ZDxFvEbMz1Xc+d3QXzM MvYkqNetdfK6E4I4FTJfxLGGPtgz/Xf5+1W60ibf6bLSK4F6gjKvl2X/+V1ZkJUmgWWo 4g8SB2arT5SqA8tdltKAKESbdKsJi383D4lXP1UDslaBMKIzHg3rkrch8F5n3a91avzc 6rP8eTdW5q7oXr64L4BPhuXTFIJzdJd+ELPZGIFGq/YX40PluFnGRaanZRwgMvW1MQ8Z r9rl2rAJHjx641iYwe7J0wdAbsDIQJ4hBUdUFPlpMAYOT0ssEooOErZjacteZ07u3wNe K1EA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=D6iyN1EW; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-34932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34932-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o16-20020a17090ad25000b00290cfa8871fsi1421930pjw.122.2024.01.23.08.38.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 08:38:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-34932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=D6iyN1EW; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-34932-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-34932-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C281B2839F4 for ; Tue, 23 Jan 2024 08:46:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ACE6E58102; Tue, 23 Jan 2024 08:46:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="D6iyN1EW" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B0DD57316; Tue, 23 Jan 2024 08:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705999592; cv=none; b=tBaOg/gjdD4spUkomwDo0crrZSV5nvIJOaAj8zka+Zr3eD8QiAzBOVU2Qa87EmT6Xqy1wjCLtM7GqNBElVZMbkvTWK/f3+S1poD4LJ9PCXrIt2kPwr4/Hmr8gbYmcTqwvDti6yw1LCEjhMlMgKzIXbBmouTHAspk6khvlREsTZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705999592; c=relaxed/simple; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UWBy8pbdEEmDg8RNgLS+4SVuvLd8AJzCueNDX+wZVcvBFKUzy5QRNHNrbYv4zulYimSngSu80kzHn3S6hizWCjbkRa5EMv+S/pVzMBqBSZIrFE+Q69mMVAIhOh8LY4R4QrTT/qi5Qck9t8vq00Pk/diQTMgDjE0fMYsA2HoQIsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=D6iyN1EW; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=D6iyN1EWmmMw2R0pqSUNme4xDL UvmpKetVaKS+eeWapPSFD8YqOeYMaPf0jCnW8rL3M9hnqG/ekImj2UsO5xS4EURLl7X4aWzAoMq3G EfWx2xDrVAT4Vv3kmgLmiNNvNEcchk5bKbhonvH/qij/dQOZVybk0ILxMM/EXeFoYMrK+7Gf5NKYI x1lbZx/tHMW716TCozDMR3ZN3xlwhXdPg3OTBfCk/SMiT3vu+YEnCQ2Q/FM+k1wZs9M5hsd14uakV NUI+Ruxe0VFn8AsBpHFONAGvBln/97K+cRbLm0lMttUVm+ZsbksRn7QX2is1jzB48BXqTUSNXCeLx YZX8xsiw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rSCQO-00FcWD-0C; Tue, 23 Jan 2024 08:46:28 +0000 Date: Tue, 23 Jan 2024 00:46:28 -0800 From: Christoph Hellwig To: Tang Yizhou Cc: tj@kernel.org, axboe@kernel.dk, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, chunguang.xu@shopee.com Subject: Re: [PATCH] blk-throttle: Eliminate redundant checks for data direction Message-ID: References: <20240123081248.3752878-1-yizhou.tang@shopee.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240123081248.3752878-1-yizhou.tang@shopee.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Looks good: Reviewed-by: Christoph Hellwig