Received-SPF: pass (google.com: domain of linux-kernel+bounces-35645-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 23 Jan 2024 10:31:05 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: David Gow <davidgow@google.com>
CC: Rae Moar <rmoar@google.com>, <linux-kernel@vger.kernel.org>, "Brendan
 Higgins" <brendan.higgins@linux.dev>, <linux-kselftest@vger.kernel.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	<kunit-dev@googlegroups.com>
Subject: Re: Re: [PATCH v2] kunit: Mark filter* params as rw
Message-ID: <gi2oosfohy3jjjvuazlg76se6m4w76ys5gxtmj5ngquxwqzz46@s7vgxulxzhao>
References: <20240122171408.3328510-1-lucas.demarchi@intel.com>
 <CABVgOSmjyCf5DSh+LJtaLubHN3F_mrFo=ZRk23u2PEmmkLBUjA@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <CABVgOSmjyCf5DSh+LJtaLubHN3F_mrFo=ZRk23u2PEmmkLBUjA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?423i4K2mAkKemSk67baOUQXGJ1GtzDSTHyKF/IN/dQ9Rrd0Q7rkJOuM/wyyk?=
 =?us-ascii?Q?E4OwnDInYnfw3HXESSL0lu3W+Ko08Akz6H/OKu/DABC0gagNRSZk/9yx8O0p?=
 =?us-ascii?Q?BExUFg2tHsGL12nlTVqVUfbCBsbMMd/nxFXMCwqxhS6KocVurX8ypBthlYdM?=
 =?us-ascii?Q?Mj8o2g/p7W0EtxcfQKLQO3/sDlax9zjw7tm+V6ihvX2uY28KceBgV2XxrfLY?=
 =?us-ascii?Q?5+p2ZiJ/dWO4IafX4fP+nGKla9H8KmjYjWBGE72BkNLYfA3Ew3sqGTVYKB3L?=
 =?us-ascii?Q?FZj8HxWeZkfkdhVKBddbugg3tPDA0NZWDkqeF25L4lzPf7ECdmm+PT+C5Qv5?=
 =?us-ascii?Q?u0qtchpkvpsTjhx40ScO0NYovkhS+b7ok9D/C01CdsVmWf9tAxmVUbjEhhxe?=
 =?us-ascii?Q?Pda6fjgw2b1C5WPkmEgu473En/NDPzneVkkV6ZzeeThvsLz9sjFo0sqy1i7Y?=
 =?us-ascii?Q?flcE3izfnl86Gdg2zqpOd1FDq0D0UTZEg4iPTr9dKb9hy6a9Vhd7oXIpnqOn?=
 =?us-ascii?Q?P9DMhDCogtEp7idIVCkqWK5J/4gOTzVG+ZeojxY+oXQI6oBbmzC20a61GhAY?=
 =?us-ascii?Q?1MSIpmtWwcvJRoD92UNSs8rW+BvJTwd3Y6ebYrpZ0ZbbItRPy6W0qJZ8Gi0z?=
 =?us-ascii?Q?lCqef0SI6GWpL29QNY98uYDv+0cYCHSLzeW7dP51YkGzYgAsbcqiXjJTam0a?=
 =?us-ascii?Q?+9i0RhJfSkUHq1JpqgNfnYBE70duw+My0f/b6sprP9qX4VfCLNR/T1f5g4dA?=
 =?us-ascii?Q?7brwwDCTsKmHh0ro0KIoposZK88erOOs6esxmaREy7lgJMhS6dTqNQogWR6V?=
 =?us-ascii?Q?Bv/F4UCYa4aYsTO+JYxpDNXc5EiuH67YS497jdhXiWOOKvL7PwtqwROm3jdD?=
 =?us-ascii?Q?mOywYb+8ctjRxXAoHpgdeSyhnUaVUB7qsDdZ5r/TnWTwbidu5b9uNisp2Q7j?=
 =?us-ascii?Q?jNHkZeFMq/sDaBA5C2bNTayaKCB5vvZKBl0ASlFvMT7oIxU8sfehz2lGWRuj?=
 =?us-ascii?Q?DjELT8TlH/SWSePM+0o6Y0HgnklVl53bJYizE911AbRtWxkw1j4rXU3DagGf?=
 =?us-ascii?Q?FCd4twvVtS0f/UD4A0nYkUe+Z9lMf8bgPgG7GTkqLIbksDQ4Athgkyvj+5cB?=
 =?us-ascii?Q?hAPTZEsIXl/DG13OsBjjPrRTQWl3IKTmddyDuAtmatmUbto1fIh9KR7FNp/L?=
 =?us-ascii?Q?loFg1BoHOtEtpqc2G1VCYvYUZ4ei95loF6lIJB/p3G+eP/tngKweWUVi+4Wa?=
 =?us-ascii?Q?nm+4/8HaLL9GGzHGnjfjVzwExGNtOwY8Yv328lN+VzFu29b/hqD1wibaI2jC?=
 =?us-ascii?Q?Hz27/+go5OO9K3z2hf47puB33BC2jgUaFxERj3TqfCQtf2UdSqj1qNz51QHU?=
 =?us-ascii?Q?sM5WdDgJtW+oe4XIYX2Go3D4+ffCpVlhLDzWw/oXNKNew1GQeuw0vaZfoTFW?=
 =?us-ascii?Q?mcx9vJgaH/j57qh/tS4MnAwLP0Y2MqS7xRwhAJ81Ug7rIZWKIuOUGoJX0zDh?=
 =?us-ascii?Q?FOW8wsXhbqG6qJB0npfpS4BLEhhcpSd+IXr3dAtCUC4BVLC2hjqBMW3040z0?=
 =?us-ascii?Q?LPwWtgOVeKTxawjl+bmCRPqSgtmw7sotxVBG6H7hdcKUVXzzcCYanlsiTau3?=
 =?us-ascii?Q?Cw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd3e55e0-926c-4d13-ace4-08dc1c30b3c4
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 16:31:08.1398
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZQsbagcwYKfrMActeOOx9csV56PTy/wlvnmVZrS4F1RHrk7CuLuBtAcBcnQ3GUtQ7TGZ8AV+72wLFMMyqrXR7//UBBHNuNnWjreghqSvqzM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8120
X-OriginatorOrg: intel.com

On Tue, Jan 23, 2024 at 04:01:49PM +0800, David Gow wrote:
>On Tue, 23 Jan 2024 at 01:14, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
>>
>> By allowing the filter_glob parameter to be written to, it's possible to
>> tweak the testsuites that will be executed on new module loads. This
>> makes it easier to run specific tests without having to reload kunit and
>> provides a way to filter tests on real HW even if kunit is builtin.
>> Example for xe driver:
>>
>> 1) Run just 1 test
>>         # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob
>>         # modprobe -r xe_live_test
>>         # modprobe xe_live_test
>>         # ls /sys/kernel/debug/kunit/
>>         xe_bo
>>
>> 2) Run all tests
>>         # echo \* > /sys/module/kunit/parameters/filter_glob
>>         # modprobe -r xe_live_test
>>         # modprobe xe_live_test
>>         # ls /sys/kernel/debug/kunit/
>>         xe_bo  xe_dma_buf  xe_migrate  xe_mocs
>>
>> For completeness and to cover other use cases, also change filter and
>> filter_action to rw.
>>
>> Link: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sjn56jqpk@vxu7sksbqrp6/
>> Reviewed-by: Rae Moar <rmoar@google.com>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>> ---
>
>This looks good to me, and works here.
>
>Reviewed-by: David Gow <davidgow@google.com>

are you going to merge this through kunit tree or should I carry it in
drm ?

thanks
Lucas De Marchi

>
>Thanks,
>-- David
>
>>
>> Rae, I kept your r-b from v1 since the additions are just what we talked
>> about.
>>
>> v2: also change filter_action and filter to rw, testing with the xe
>>     module to see if filter=module=none filter_action=skip produces
>>     the result expected by igt
>>
>>  lib/kunit/executor.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/kunit/executor.c b/lib/kunit/executor.c
>> index 1236b3cd2fbb..371ddcee7fb5 100644
>> --- a/lib/kunit/executor.c
>> +++ b/lib/kunit/executor.c
>> @@ -31,13 +31,13 @@ static char *filter_glob_param;
>>  static char *filter_param;
>>  static char *filter_action_param;
>>
>> -module_param_named(filter_glob, filter_glob_param, charp, 0400);
>> +module_param_named(filter_glob, filter_glob_param, charp, 0600);
>>  MODULE_PARM_DESC(filter_glob,
>>                 "Filter which KUnit test suites/tests run at boot-time, e.g. list* or list*.*del_test");
>> -module_param_named(filter, filter_param, charp, 0400);
>> +module_param_named(filter, filter_param, charp, 0600);
>>  MODULE_PARM_DESC(filter,
>>                 "Filter which KUnit test suites/tests run at boot-time using attributes, e.g. speed>slow");
>> -module_param_named(filter_action, filter_action_param, charp, 0400);
>> +module_param_named(filter_action, filter_action_param, charp, 0600);
>>  MODULE_PARM_DESC(filter_action,
>>                 "Changes behavior of filtered tests using attributes, valid values are:\n"
>>                 "<none>: do not run filtered tests as normal\n"
>> --
>> 2.40.1
>>