Received-SPF: pass (google.com: domain of linux-kernel+bounces-35718-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240122-spi-multi-cs-max-v1-1-a7e98cd5f6c7@kernel.org>
 <20240123120430.75c7ace0@bootlin.com> <cefafa30-b78d-471b-83e0-b05060d806d4@sirena.org.uk>
 <93385fc2-7596-4f66-b0c1-07d7d5c9ed8d@csgroup.eu> <49b52941-6205-48bd-b2ae-e334018ac5cd@sirena.org.uk>
In-Reply-To: <49b52941-6205-48bd-b2ae-e334018ac5cd@sirena.org.uk>
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Tue, 23 Jan 2024 17:50:22 +0100
Message-ID: <CAOiHx==FzSyyqP3NzLTeOSVxUQYy3ZhypZrDLsc-OjGCdSzvUA@mail.gmail.com>
Subject: Re: [PATCH] spi: Raise limit on number of chip selects
To: Mark Brown <broonie@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>, Herve Codina <herve.codina@bootlin.com>, 
	Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>, Guenter Roeck <linux@roeck-us.net>, 
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, 
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, 
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, 23 Jan 2024 at 14:56, Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Jan 23, 2024 at 01:26:04PM +0000, Christophe Leroy wrote:
> > Le 23/01/2024 =C3=A0 14:18, Mark Brown a =C3=A9crit :
> > > On Tue, Jan 23, 2024 at 12:04:30PM +0100, Herve Codina wrote:
>
> > >> Moving the SPI_CS_CNT_MAX value from 4 to 8 is not enough to handle =
my case.
> > >> Tested moving SPI_CS_CNT_MAX to 16 and it was ok.
>
> > > OK, I've also heard 12 as a number which this would cover.
>
> > By the way the comment in include/linux/spi/spi.h is confusing. This
> > SPI_CS_CNT_MAX is really not the max number of CS supported per SPI
> > device but the max number of CS supported per SPI controller.
>
> Well, it's a combination of the comment being confusing and the
> implementation being a bit broken - we simply shouldn't be limiting the
> number of chip selects per controller, the per device limit is much more
> reasonable.  So ideally the code would be changed to reflect the
> comment.

At a first glance at all places using SPI_CS_CNT_MAX I don't see
anything being broken / reading out of bounds if a controller has more
chipselects than SPI_CS_CNT_MAX.

So I think the check of ctrl->num_chipselect in of_spi_parse_dt() is
bogus/unnecessary and is in the wrong place, as this is for parsing a
spi device node and not a controller node. The following check for the
amount of chip selects defined for the spi device should just check
against SPI_CS_CNT_MAX instead of ctrl->num_chipselects.
__spi_add_device() later will ensure that any chip selects are valid
chip selects, so no need for of_spi_parse_dt() to check that either.

But I didn't do a very thorough read, or even tested it, so I might
have easily missed something.

Best Regards,
Jonas