Received-SPF: pass (google.com: domain of linux-kernel+bounces-35771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 23 Jan 2024 17:23:40 +0000
From: Conor Dooley <conor@kernel.org>
To: Philippe Schenker <dev@pschenker.ch>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Woojung Huh <woojung.huh@microchip.com>,
	Vladimir Oltean <olteanv@gmail.com>, linux-kernel@vger.kernel.org,
	UNGLinuxDriver@microchip.com, Marek Vasut <marex@denx.de>,
	Florian Fainelli <f.fainelli@gmail.com>, devicetree@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next v1 1/2] dt-bindings: net: dsa: Add KSZ8567
 switch support
Message-ID: <20240123-atlas-dart-7e955e7e24e5@spud>
References: <20240123135014.614858-1-dev@pschenker.ch>
 <20240123-ripening-tabby-b97785375990@spud>
 <b2e232de11cee47a5932fccc2d151a9c7c276784.camel@pschenker.ch>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="puDO/bicEa8XZtpY"
Content-Disposition: inline
In-Reply-To: <b2e232de11cee47a5932fccc2d151a9c7c276784.camel@pschenker.ch>


--puDO/bicEa8XZtpY
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 05:17:53PM +0100, Philippe Schenker wrote:
>=20
>=20
> On Tue, 2024-01-23 at 16:06 +0000, Conor Dooley wrote:
> > On Tue, Jan 23, 2024 at 02:50:13PM +0100, Philippe Schenker wrote:
> > > From: Philippe Schenker <philippe.schenker@impulsing.ch>
> > >=20
> > > This commit adds the dt-binding for KSZ8567, a robust 7-port
> > > Ethernet switch. The KSZ8567 features two RGMII/MII/RMII
> > > interfaces,
> > > each capable of gigabit speeds, complemented by five 10/100 Mbps
> > > MAC/PHYs.
> > >=20
> > > Signed-off-by: Philippe Schenker <philippe.schenker@impulsing.ch>
> >=20
> > This device has all the same constraints as the other ones in this
> > binding, why is it not compatible with any of them? If it isn't, the
> > compatible should mention why it is not.
>=20
> Hi Conor, Thanks for your message!
>=20
> I need the compatible to make sure the correct ID of the switch is
> being set in the driver as well as its features.

Are the features of this switch such that a driver for another ksz
switch would not work (even in a limited capacity) with the 8567?
Things like the register map changing or some feature being removed are
examples of why it may not work.

> You mean I shall mention the reason in the commit-message, or where?

Yes.

Thanks,
Conor

> > > =A0Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml | 1 +
> > > =A01 file changed, 1 insertion(+)
> > >=20
> > > diff --git
> > > a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > index c963dc09e8e1..52acc15ebcbf 100644
> > > --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > @@ -31,6 +31,7 @@ properties:
> > > =A0=A0=A0=A0=A0=A0 - microchip,ksz9893
> > > =A0=A0=A0=A0=A0=A0 - microchip,ksz9563
> > > =A0=A0=A0=A0=A0=A0 - microchip,ksz8563
> > > +=A0=A0=A0=A0=A0 - microchip,ksz8567
> > > =A0
> > > =A0=A0 reset-gpios:
> > > =A0=A0=A0=A0 description:
> > > --=20
> > > 2.34.1
> > >=20

--puDO/bicEa8XZtpY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZa/2HAAKCRB4tDGHoIJi
0iK5AP9Rxz/Mwx+CVYnGDVHIuqf+Y0VRbXv4MLXFsmG1xnO9wgEAkK7LkNWYo2x/
8DecwgALjn0eGXmhJXFDg8p2At5CsgY=
=KMN+
-----END PGP SIGNATURE-----

--puDO/bicEa8XZtpY--