Received-SPF: pass (google.com: domain of linux-kernel+bounces-35789-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0b2bccfb-d1a3-4c2e-b1d3-159630edf21a@web.de>
Date: Tue, 23 Jan 2024 18:38:42 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org,
 Frank Rowand <frowand.list@gmail.com>, Lizhi Hou <lizhi.hou@amd.com>,
 Rob Herring <robh+dt@kernel.org>
Content-Language: en-GB
Cc: LKML <linux-kernel@vger.kernel.org>, Kunwu Chan <chentao@kylinos.cn>
From: Markus Elfring <Markus.Elfring@web.de>
Subject: [PATCH] of: unittest: Return directly after a failed kasprintf() call
 in of_unittest_pci_node_verify()
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:EEXap3aLt3M=;C/95zT7YksgzcT6MP9G9p9xmZei
 DASbxD436h1QydtkXQyROSGVV5xEXam1Yd9yzAqJW9ROwU/q2aBew0s4Hwqy8mtH6mgMHw2Tl
 KqiMoBwK6r3XiaOrijeRkXE1nLR0VrgXO3jjRfkKXyhsRSXNHr263qGi00xQXu+5BNYZMWxvv
 JVF4c/R+GVBIHyGSM5xL92x7kOsyha+zH1u7CFM1RsfA+L9Eir90TyRFdpz3cXBO6xqIgJ1o/
 aeV9OLSFvjPwb4kub+nLLePpOezeRBZYjNqqYQg8u+fKMPypczMOeRCs0MgHaWnKUMzFpPR/Y
 n65GEiAtWtEw+loJqfOboFqxpcz532UGGP7XxT6tm/RjTf7tCpffpVjhxRhEm9YYX4PAJ176Q
 EUb1EGMGKdwT24gff7zlbLMgT7cmc8p4iWcel22FjN2uq0VWoCE3gHyIEkAvHOQakSK6Vwigd
 i6YoJe0Rq6m4t5Da7W2zjB2p9OPDWAx3DFQvEUh07WtyoP6Ld7rGYuwB6FgoJtEdWDqLKebdt
 eT4/9QylULvP3uiIxklSszotDGNW/Njyjn4o7ITkn2QpavdAZ14YHcO1uHBVQ97jxoJTey7uq
 axoo62QKRBoo3UPX5fVvRz99n2Gl9PSKBSmyAhrXnBZfPwDfYnCVbnoc3dqlBSmrijyQh6Cke
 Fm3e4l3N8yGK03jN0kOZaWvjHOyjuOsW4/RM2firIHTx/sp0eEOVhacOZMoeA3YqnUZ0zylkv
 YOc5nLL0SeyMZoSl3QqKRymSu2PnUI8NM1y5Fa7fPNm2KMdBtubmTl1bF0Y0ugGehfxFTIi7X
 HoxfK6ZmcUrLIukBKhFvdKVJu6KDKWR1UuHjNORT0GeoF+BEtGa7En5KNJs0rv9+mQQAJT+Gk
 XqFzjn8Tx4FtDORsSn+CLBmEUGas1RZlOCyLcGJh0Pp+KxXahOp4pOzMEfP2xZKpAZChlg1ir
 cflSnA==

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 23 Jan 2024 18:24:53 +0100

The result from a call of the function =E2=80=9Ckasprintf=E2=80=9D was pas=
sed to
a subsequent function call without checking for a null pointer before
(according to a memory allocation failure).
This issue was detected by using the Coccinelle software.

Thus return directly after a failed kasprintf() call.

Fixes: 26409dd045892 ("of: unittest: Add pci_dt_testdrv pci driver")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
=2D--
 drivers/of/unittest.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index e9e90e96600e..a46268fe8d2a 100644
=2D-- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -3990,6 +3990,9 @@ static int of_unittest_pci_node_verify(struct pci_de=
v *pdev, bool add)

 	if (add) {
 		path =3D kasprintf(GFP_KERNEL, "%pOF/pci-ep-bus@0/unittest-pci@100", pn=
p);
+		if (!path)
+			return -ENOMEM;
+
 		np =3D of_find_node_by_path(path);
 		unittest(np, "Failed to get unittest-pci node under PCI node\n");
 		if (!np) {
@@ -4003,6 +4006,9 @@ static int of_unittest_pci_node_verify(struct pci_de=
v *pdev, bool add)
 			rc =3D -ENODEV;
 	} else {
 		path =3D kasprintf(GFP_KERNEL, "%pOF/pci-ep-bus@0", pnp);
+		if (!path)
+			return -ENOMEM;
+
 		np =3D of_find_node_by_path(path);
 		unittest(!np, "Child device tree node is not removed\n");
 		child_dev =3D device_find_any_child(&pdev->dev);
=2D-
2.43.0