Received-SPF: pass (google.com: domain of linux-kernel+bounces-35813-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 23 Jan 2024 12:49:27 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: thinh.nguyen@synopsys.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	balbi@kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	mark.rutland@arm.com, mathias.nyman@intel.com, pku.leo@gmail.com,
	sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add system bus request info
Message-ID: <Za/8J8MDJaZEPEKO@lizhi-Precision-Tower-5810>
References: <20240123170206.3702413-1-Frank.Li@nxp.com>
 <20240123-poking-geography-33be2b5ae578@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240123-poking-geography-33be2b5ae578@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Gbb3blD7wgG94BD3/4Z+niu9iul6LQmu13B3Xb8+FlhAT4HoztsS2xjF+6C7?=
 =?us-ascii?Q?eR/K5ie2zzzKhXOPNusWJGfywZb89xnBftadTRxbq5n22Viv4f33kisqlnZR?=
 =?us-ascii?Q?G/lhd4FGNoVPObJR/jiCJlqlW7YChHvsmp3StkO8cF3HKN1kCcEwtshym8ts?=
 =?us-ascii?Q?oEnHfbVtNalcZchmVgOyvzAZS70io3bsh+rNhNq+922C6Ig94uPsK8BE1RFE?=
 =?us-ascii?Q?6WyE/WQNRkCR8ygS8awsKip6Veyw3qZcFDJaammPwgZ2VJ6102OmJPCUX92/?=
 =?us-ascii?Q?l+tAyONbywifNxaALMFwHNkKVuUklp75TnzoxsVMUa2iEnbeY1gi8wIhJNEH?=
 =?us-ascii?Q?qRuwyveux/JsIfrqhn20UlMVi6LU7806JSCMrvqdzKpiDKXeEyq7YqFw8w7h?=
 =?us-ascii?Q?gllNysOUgcEtlU24WFeFxiJINoJpQ6ubiC0XKl0JsVQKBQ0PZ94DqgiZBzhK?=
 =?us-ascii?Q?eMARq4vMg41rW79+ubirGLqZWmL7atwxVBGAJccgSeMeSjw4Q9K0cDhmeAjP?=
 =?us-ascii?Q?l7SQ/FfThomH6TNce8F3+krPVpZ4oXxqVGWQOTswynZ398Bq6qBz4MOClzFu?=
 =?us-ascii?Q?P+nCKZBH2FAbM5SlooLh7UH7H5iG8D3sm5UQZktbKyzWyQWP7vwPUTkq2YPi?=
 =?us-ascii?Q?TcJ9UdcyqSB9fre0o8LtB8LtvCDxLjTC9PmKURGmfBlerhb3wR3tT/4znUmF?=
 =?us-ascii?Q?T7JzH9+5Y7wf+KAQ0mVRALporWJiEINCbdQLN/ywDI+5pkhQ9d2m1XZ+1yWK?=
 =?us-ascii?Q?vSAScha1TRcMIZEQbHYPfCgb1EzfrLCPw+lqZcBAqJ5V2lfUiU6EGWXJmvdu?=
 =?us-ascii?Q?sAsK2Fojn7F2HG6gyqWheRs2F2xP+iPlpZ5NHL+rnC5x+uZDljhMa/dSvtW1?=
 =?us-ascii?Q?Uvo7xTFiX4gnYSwIf9iPn5Pq2xTfzARKWmPwaM6t2kM9lOgj/2iP/ifuqYMC?=
 =?us-ascii?Q?s8j8fROlsAvLmy90FNtwa20BUjVF+dJQfd43learSD+qFkWFd/LfvBB4JpGG?=
 =?us-ascii?Q?JOSmY9lAyl/Lx9XhjprO9jKsyPTF6VqdqRu+99tuVXr/1Yx5T/YgQNwcpwl1?=
 =?us-ascii?Q?s5FOVuC1oy+pdYFQqw7dCF1pRsi+vFLODpt23CbGqcVlLdaX7xQB+DeIGARp?=
 =?us-ascii?Q?wXuNyJamQAE0wanYy48qR9Ro2KLjymH6xEgBW8GDvfXzizTeOT8JXisNBqSt?=
 =?us-ascii?Q?erzaqgNzzYPHIuLUll9pGCf6SvCE/ALbG6tegIY0G0NGmQ6+zqpu94mDqLkq?=
 =?us-ascii?Q?PAbQf3xQkGF73QXbVJPCE/4CgoEzfb/LG87/o+CeeM5qqo9xMFgzWEILs7nS?=
 =?us-ascii?Q?vI84YcWBBTR7fMv/eIzCSuvGQhv7EkCmXjL26KuPTaEUhbVH8cuqyE6xwDp1?=
 =?us-ascii?Q?FEOtoFme6ll7Rii5WvWKBfAaSxMKD9urWnHmxoQlv/9gcWxoz1/i0eXLxlWi?=
 =?us-ascii?Q?F3/rYqsGEXee6UMPziPsSU7ZbcbzK/OaM74U4rizCCKzQUr4UUpwdwVC7wLz?=
 =?us-ascii?Q?IfKWHe7OPKQSkp57il/XACMnRUYvzFrct1MsSTrnqwEXn09vKnDoEtBa8dBP?=
 =?us-ascii?Q?qXGD+LbQcH3d1dwXOhqBj6ekT7YB3MMJ7GUuRM1Z?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01eafd4d-e7c1-4329-a058-08dc1c3ba9f7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 17:49:36.1468
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8I3nUFE4PwgC1GD8atVqfqkbyM6ssM4oYdhQGUq/+1eaGJfSxPycmc2eUx3prYb+QxqLhcHr9qafjhYzQKUq/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8025

On Tue, Jan 23, 2024 at 05:27:13PM +0000, Conor Dooley wrote:
> On Tue, Jan 23, 2024 at 12:02:05PM -0500, Frank Li wrote:
> > Add device tree binding allow platform overwrite default value of *REQIN in
> > GSBUSCFG0.
> 
> Why might a platform actually want to do this? Why does this need to be
> set at the board level and being aware of which SoC is in use is not
> sufficient for the driver to set the correct values?

In snps,dwc3.yaml, there are already similary proptery, such as
snps,incr-burst-type-adjustment. Use this method can keep whole dwc3 usb
driver keep consistent. And not all platform try enable hardware
dma_cohenrence. It is configable for difference platform.

Frank

> 
> Thanks,
> Conor.
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/usb/snps,dwc3.yaml    | 36 +++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index 8f5d250070c78..43e7fea3f6798 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -439,6 +439,42 @@ properties:
> >      items:
> >        enum: [1, 4, 8, 16, 32, 64, 128, 256]
> >  
> > +  snps,des-wr-reqinfo:
> > +    description: Value for DESEWRREQIN of GSBUSCFG0 register.
> > +      ----------------------------------------------------------------
> > +       MBUS_TYPE| bit[3]       |bit[2]       |bit[1]     |bit[0]
> > +      ----------------------------------------------------------------
> > +       AHB      |Cacheable     |Bufferable   |Privilegge |Data
> > +       AXI3     |Write Allocate|Read Allocate|Cacheable  |Bufferable
> > +       AXI4     |Allocate Other|Allocate     |Modifiable |Bufferable
> > +       AXI4     |Other Allocate|Allocate     |Modifiable |Bufferable
> > +       Native   |Same as AXI   |Same as AXI  |Same as AXI|Same as AXI
> > +      ----------------------------------------------------------------
> > +      The AHB, AXI3, AXI4, and PCIe busses use different names for certain
> > +      signals, which have the same meaning:
> > +      Bufferable = Posted
> > +      Cacheable = Modifiable = Snoop (negation of No Snoop)
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    maxItem: 15
> > +
> > +  snps,des-rd-reqinfo:
> > +    description: Value for DESRDREQIN of GSBUSCFG0 register. ref
> > +      snps,des-wr-reqinfo
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    maxItem: 15
> > +
> > +  snps,dat-wr-reqinfo:
> > +    description: Value for DATWRREQIN of GSBUSCFG0 register. ref
> > +      snps,des-wr-reqinfo
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    maxItem: 15
> > +
> > +  snps,des-wr-reqinfo:
> > +    description: Value for DATWRREQIN of GSBUSCFG0 register. ref
> > +      snps,des-wr-reqinfo
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    maxItem: 15
> > +
> >    num-hc-interrupters:
> >      maximum: 8
> >      default: 1
> > -- 
> > 2.34.1
> >