Received-SPF: pass (google.com: domain of linux-kernel+bounces-35878-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Jan 2024 18:42:03 +0000
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Edmund Grimley-Evans <edmund.grimley-evans@arm.com>
Subject: Re: [PATCH 3/4] arm64/fp: Clarify effect of setting an unsupported
 system VL
Message-ID: <46571fac-28bf-4c6e-a5a4-38b1182b93a0@sirena.org.uk>
References: <20240122-arm64-sve-sme-doc-v1-0-3d492e45265b@kernel.org>
 <20240122-arm64-sve-sme-doc-v1-3-3d492e45265b@kernel.org>
 <Za/gB3oCNAyiPPnu@e133380.arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Wi8C1+Ocdx9GTbVa"
Content-Disposition: inline
In-Reply-To: <Za/gB3oCNAyiPPnu@e133380.arm.com>


--Wi8C1+Ocdx9GTbVa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 03:49:27PM +0000, Dave Martin wrote:
> On Mon, Jan 22, 2024 at 08:41:53PM +0000, Mark Brown wrote:

> >  /proc/sys/abi/sme_default_vector_length
> > =20
> >      Writing the text representation of an integer to this file sets th=
e system
> > -    default vector length to the specified value, unless the value is =
greater
> > -    than the maximum vector length supported by the system in which ca=
se the
> > -    default vector length is set to that maximum.
> > +    default vector length to the specified value rounded to a supporte=
d value
> > +    using the same rules as for setting vector length via prctl().

> Do parallel changes need to be made in sve.rst?

They are, in this very patch?

> (There seems to be so much duplication and copy-paste between these
> files that I wonder whether it would make sense to merge them...  but
> that's probably a separate discussion.)

Indeed, thanks for volunteering.  Note that there are differences
resulting from specification differences.

> Nit: is it better to name the prctl here than just to say prctl()?
> That would be easier for the reader to cross-reference.

I guess, though it doesn't seem entirely idiomatic.

--Wi8C1+Ocdx9GTbVa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWwCHoACgkQJNaLcl1U
h9D0Ywf+IsH2g0If00Q6Xk+sM/N4fUnp2hK2AfnBw8nxWQ5Odt/OYSj8MHbBtvSO
1yDO0dHZ9PvXpJNJG3mrrsxZhVg2SEHvoQ6O28G1GGQPciM4/3Qm02F5KNeu0ak9
iJxeljkaWSxQOLKnbnxF2z36xZ/DmdY0mLF2ns8lTijWS14OFy/rsjVY4rVnK742
CDEmB+OyW6oiMrpwOVURKa1gD9pUiHa56ju7qN0E3mNydfNv9SeXljc3Kqsr+Qic
Yt5CFfrUqvBlq50CfErsPZcCjH4GgDDzFTCRmkclu5E14fohiftWeENBEx6yhXYm
9Bu11n7PyA5yEQSgS5GB7V8qQ60eiw==
=apO6
-----END PGP SIGNATURE-----

--Wi8C1+Ocdx9GTbVa--