Received-SPF: pass (google.com: domain of linux-kernel+bounces-35915-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 23 Jan 2024 18:47:40 +0000
From: Oliver Upton <oliver.upton@linux.dev>
To: Yi Wang <up2wing@gmail.com>
Cc: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, wanpengli@tencent.com,
	foxywang@tencent.com, maz@kernel.org, anup@brainfault.org,
	atishp@atishpatra.org, borntraeger@linux.ibm.com,
	frankja@linux.ibm.com, imbrenda@linux.ibm.com
Subject: Re: [v2 1/4] KVM: irqchip: add setup empty irq routing function
Message-ID: <ZbAJzFeRa_6NQznQ@linux.dev>
References: <20240121111730.262429-1-foxywang@tencent.com>
 <20240121111730.262429-2-foxywang@tencent.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240121111730.262429-2-foxywang@tencent.com>

On Sun, Jan 21, 2024 at 07:17:27PM +0800, Yi Wang wrote:
> Add a new function to setup empty irq routing in kvm path, which
> can be invoded in non-architecture-specific functions. The difference
> compared to the kvm_setup_empty_irq_routing() is this function just
> alloc the empty irq routing and does not need synchronize srcu, as
> we will call it in kvm_create_vm().
> 
> This patch is a preparatory step for an upcoming patch to avoid
> delay in KVM_CAP_SPLIT_IRQCHIP ioctl.

Adding a function in a separate patch from its callsites is never
useful. Please squash this into the second patch.

-- 
Thanks,
Oliver