Received-SPF: pass (google.com: domain of linux-kernel+bounces-35916-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <14dffda2-f413-4304-9932-3ac8ddfb30e4@intel.com>
Date: Tue, 23 Jan 2024 10:48:00 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v1 3/4] tsm: Allow for mapping RTMRs to TCG TPM PCRs
To: Dan Williams <dan.j.williams@intel.com>, "Yao, Jiewen"
	<jiewen.yao@intel.com>, Qinkun Bao <qinkun@google.com>, Samuel Ortiz
	<sameo@rivosinc.com>, "Lu, Ken" <ken.lu@intel.com>
CC: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>,
	"linux-coco@lists.linux.dev" <linux-coco@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20240114223532.290550-1-sameo@rivosinc.com>
 <20240114223532.290550-4-sameo@rivosinc.com>
 <1bbf8d3e-aa94-48c7-a1e4-76f9eefc4af7@linux.intel.com>
 <65a72c305291f_3b8e29484@dwillia2-xfh.jf.intel.com.notmuch>
 <5539c533-37b2-4b12-a5c5-056881cf8e3c@linux.intel.com>
 <Za1G9I+tYuIL9ser@vermeer> <CF3D8DE1-AD47-4A77-B8BD-8A12A6F7E9DB@google.com>
 <MW4PR11MB5872F46A2089C8C2D8EF7A008C752@MW4PR11MB5872.namprd11.prod.outlook.com>
 <65aecbbce09dd_107423294b7@dwillia2-xfh.jf.intel.com.notmuch>
 <c3b99264-233b-4997-9e20-c4c2693b8cdc@intel.com>
 <65aeecea827f0_37ad2948@dwillia2-xfh.jf.intel.com.notmuch>
Content-Language: en-US
From: "Xing, Cedric" <cedric.xing@intel.com>
In-Reply-To: <65aeecea827f0_37ad2948@dwillia2-xfh.jf.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BPRlRVMmhWcE5YeSt2RzZCY0ltbjN1bzFDUnViNEhhZDlJaWcyUmxvakpL?=
 =?utf-8?B?VWZOZFhVdGcwMFN1MzFNQlllTVJ1SmIyek55UnJSRnQvak9GM2tRUHZMeFp2?=
 =?utf-8?B?eEVVYUc3V2Q0SDZRcEROWUh3STF0ZTFYRTlxd01jaVQ1NWIzQmNlQVRZcUdy?=
 =?utf-8?B?TmtROUY5OFQ4UzRoSkJ6Z21Uazg0L1JuWjY1bXpRTDkxeG9aNVJscjk1Vi96?=
 =?utf-8?B?N2tPS0xoU24yUXk1YWR6MXNmRG5PZ3ByaVZzbDA4MVBpaW5tOU9kK0wrU3Jy?=
 =?utf-8?B?ZlhNcWJPdklmTVEzU0hXdG5QNWVaSmFZWGNWM0dmcU9wRXFDaHhpYWNKekxF?=
 =?utf-8?B?YzNweSs2eDlvRmFzSmwwTkhrZG5JckpLU0F6NlFhZkxmeDdiVVlqT2pWUlZY?=
 =?utf-8?B?ZndyQVBEaXN5cTRWblNlZTFuejRTeWVnLzlYTmJ2S20yT3VHV1ZLRFV5SjRU?=
 =?utf-8?B?UmpmK294NmsxRENHTGhHYVBZczRqTUg4ZzR5WEZEdDNMK2JJNHRpN2ZUK1I1?=
 =?utf-8?B?ZCtIMkR1cWE2dDBreDgzYUFWUmhqak1aOExhM1BmUmhwb3RJUllZN1NidXcr?=
 =?utf-8?B?a3RzVWorSmdBZ01UTlg4d1FjVFd4K3YvNVJrYUV2SGtzZTNxMHExOUpRcDQr?=
 =?utf-8?B?MUF0OG14YVk4a3c0TklXcGtpKzlkWkF1VCtkMDZ3TDdtVjN0T1ovd3BlOEVW?=
 =?utf-8?B?VVA0d09ETDBBYUFjNGRES0ZaZDd0bmNJaEJnUGlWTkxXeUcvUnlBYlJERjNl?=
 =?utf-8?B?VFdWRFoyblBHMVlxdHJyV0JQRVRLcmlnYjR5UnBVUEpwWElqdTJ2cjBrVlJz?=
 =?utf-8?B?T1p6OXR3QXBCNkhQQS9uVE43TldYZGpxajRWTGVtTGlncndOdUZaN2tQb2ND?=
 =?utf-8?B?MUlTb1kwdWdmNkQrZE15cHhDNUFjYkdab0NpOXUvL05qRFdQa1RpMWpaVUt5?=
 =?utf-8?B?QUVET3BKNjJGUXkvdWJEai9McTVjalpnWkREbWRYTnhvakZRaFVtaUQ4dDVP?=
 =?utf-8?B?TXlzUENOMHh1dHR5NXgzcUMxYUVWYVJtSCszcWtRVGY1b090bkM5TDNiK1pL?=
 =?utf-8?B?NnVWQm9za3JxcFRXcFF4Tk1XRXJuS2M3MFhnTTBsc1hLMEx0bGYwdzczdysy?=
 =?utf-8?B?OTUrYU5FZWNFaFR6NXE1bVVZK0dwdlZsbnpHeTFHeld5RGhLb2ZzMHZnVXpY?=
 =?utf-8?B?TzdRMU5ZUjF4Szl0azhGRDgwK0xTSDBQQ2l1ZDFFbkZKNW93QWhEZEZaOUMx?=
 =?utf-8?B?bGF1aFo5Q1lrOW03cCs0bWEvOWRKaTZUMWdrR3IxOVVNQkRJNy9OcDgraSs2?=
 =?utf-8?B?MTU3UUF2Y1lSeWMwT2dWNzY4SnMwSGF4N2JHTTdEemkwbW14QnRrbG0ySTRW?=
 =?utf-8?B?R2hFRDVRRmhHMTErYi9QLzJrTisvN0hUekRHeE5lQ0NyNTZmNEZFSmQyMjFi?=
 =?utf-8?B?K2tIbE5URXZZSVd1ZzBhRnozSC9LdFZBT3VrTjljTlcwNVZ2cUdQeGoyZWwr?=
 =?utf-8?B?TUJubXVtOFoyUWpSajljOEVmTC9ham5lcEgyblZUUFNRdXZ0SXJtemVmNStO?=
 =?utf-8?B?N1hTU2xUL0YvMkVqQ0psSHAvWVhpakhVQ0dzakM0eVY3QnlJTVhjWWNCNDlI?=
 =?utf-8?B?U0lzUjliZUFFV0JpU3BYZGdsdDFvT0NyTklMRDBJMDNxY056OUk1dkM2d2FL?=
 =?utf-8?B?NUNROEpjSlJqK0tRenlPVXRqYlk3OERmU01BazVxS0tDYTlGdEVDUi9LK2d0?=
 =?utf-8?B?UWpsdmR1VG5zZG5LOFJLb01td2NEUWNBNWN1aDljSkR5ZkhTV2FQMjBmV1Fp?=
 =?utf-8?B?cytyK241WjBNWk5LemlIRzlCelhoa1RrRWFnK1BkcEc1VEJlZElSa3gxd2E5?=
 =?utf-8?B?WHZ4SWNQV1FjUUh1LzltMGdacm5QVFE0SUxaZWZnT1hzbC9oMitEdzRtMUJs?=
 =?utf-8?B?aUVJRldxejNoemlEQkhRdExZdFFHMHkvQzlReXphMEl4WVM2MktHSHh4QTh1?=
 =?utf-8?B?MjVSR3hKcnR3OGE1MFBxQk85UkVrajEvYjNQelF0M0Z5dlNpY1IrbnMxOFpR?=
 =?utf-8?B?d0ZrbkpXVURYREFobzVjUlYyb0tZNWFtd0MzbE9mZ1lnZXVKZTdGbmZJZVhz?=
 =?utf-8?Q?/+fmJnpcEaLk9X6tIWISWjpsh?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f8227cc-4381-4ee5-eca8-08dc1c43d440
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6269.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2024 18:48:03.7076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sm3qmOGh0xAp6HFzbZPi9RKhlZu+DmEvVxF5PhRvqY3p8aYgluy0N3mu+mogIv0tQWsceYH9KBbe7kk5jAdk2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7128
X-OriginatorOrg: intel.com

On 1/22/2024 2:32 PM, Dan Williams wrote:
> Xing, Cedric wrote:
> [..]
>>> So, yes, the mapping should be allowed to specified by the low-level
>>> driver, but at the same time every vendor should not reinvent their own
>>> enumeration method when we have EFI for that.
>>
>> Given PCR->RTMR mapping is static, I just wonder why it needs to be kept
>> in kernel. Given that PCRs can never be 1:1 mapped to RTMRs, and that
>> TDX quotes are never TPM quotes, applications used to extend PCRs would
>> have to be changed/recompiled. Then wouldn't it suffice to define the
>> mappings as macros in an architecture specific header file?
> 
> I think something is wrong if applications are exposed to the PCR->RTMR
> mapping thrash. I would hope / expect that detail is hidden behind a TPM
> proxy layer sitting in front of this mapping on behalf of TPM-client
> applications.

Hi Dan,

My apology for the confusion! I think we are talking about 2 different 
scenarios - (1) this patch alone; and (2) this patch + vTPM.

Scenario 1: This patch provides RTMR access only. My assumption is, 
there are existing application (and/or kernel modules) that extend to 
PCRs today and would like to work in TDs where only RTMRs are available. 
Changes are of course necessary in those applications as TPMs/PCRs are 
no longer available, but from security perspective they would like to 
keep the same activity log and just change to use RTMRs (in lieu of 
PCRs) as the secure storage. Hence a PCR->RTMR mapping is necessary and 
must be agreed upon by all those applications and relying parties. IIUC, 
this is the intention of having PCR->RTMR mapping config maintained by 
the kernel, as proposed by Sam O. originally.

Scenario 2: A vTPM is implemented on top of this patch, in which case 
the existing applications don't have to change as they can continue 
extending to the same PCRs, which will then be emulated by the 
underlying vTPM implementation. PCR->RTMR mapping in this scenario is 
obviously internal to the vTPM and I agree with you completely that it 
should be hidden inside the vTPM.

My comment in my previous email was regarding Scenario 1. I hope the 
clarification above helps.

-Cedric