Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp680920rdb; Tue, 23 Jan 2024 11:17:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrTBRnUYDXMAEtcF1YddN9aH2q2q4X2YFriUFf645aH0aWoaxVr7LHB9+vmVmNpLk6jjcY X-Received: by 2002:a2e:b6c6:0:b0:2ce:aa5:3b76 with SMTP id m6-20020a2eb6c6000000b002ce0aa53b76mr157360ljo.49.1706037448656; Tue, 23 Jan 2024 11:17:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706037448; cv=pass; d=google.com; s=arc-20160816; b=o7u408I4d2vPlgmXM0QLHuk87XrVifY4KLC2/PZGy2xPCcozqfKDHcK1EXaxz13OGC 0XHnd+nlL2KJoGWYl2Ilg18URICS7i9x1I5ptN392KGrycRqs+dwdp5qInOJ3sjTyN3w ACnbgHKJIM2jKRvuklMT0izZa6bdg/m+w1mZA7DCvKehFnMMB1eEM2tAIBm1OFIVwO4Q 62jvgiNb4A9yYicUwuld+liafpkYWScDNEor12BDmwyvoEdIAyIUozAA0YOFv0It5q/r 2i3OO44WAnCFNiD4FADl+jdoNlLTlXz8CXbtMIZzUjfFXpWyCxcoiWC/wIhRTsQ1rbjs W16A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:organization:in-reply-to:subject:cc:to :from:dkim-signature; bh=eAq9edvDOaxy0s3F65mxtkDQkH8on+Q20A0iGaFOqaY=; fh=/fn1mvjOCkd20toCvoh66z+jktYBfT4DVqw24vvkOdc=; b=YMXY/jTg72cQnE37JGQjo8J3EXlPDo36s070p6ZGJNjkT+2iLxLdlqCTpVdH242MRU qaLGr3lsPvcQYHKUK7nFB4vZbeb77/fzWtF0JBMkkeCblo9E043M/Ert4KzzOXe9g04F NyXXn8KRjVizSutCkcdesWwDnNLJoyMo4LGvWGJeHolkOB2+9A52QltYzKi0qtXUF3/Z XGB2DKEYIhcfOrw7+O0rcUdljgepnmGNJPa7sgzeRNQ3/1+OGUhEUK6h3ajLWjzfxLyg bbT5p9vO0jrW/VfZf+bzOZclH7C1LY5PK58SsZLzVTDKf2mbBbFJ87sYQn5vv8HbFr7t dr8A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gvkCVxj9; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-35977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id s30-20020a50ab1e000000b0055a3288684asi5965780edc.191.2024.01.23.11.17.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 11:17:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-35977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gvkCVxj9; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-35977-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-35977-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6909E1F2A4C2 for ; Tue, 23 Jan 2024 19:17:28 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E52E081207; Tue, 23 Jan 2024 19:17:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gvkCVxj9" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C4DF50A64 for ; Tue, 23 Jan 2024 19:17:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706037441; cv=none; b=Sly/OunXPb/UGnr/qD2lHfCHteE4s2D3WUYNhV18d1FdXZlIOVfFeg1z6nTUKk9pTzZ54DNWQB6VzteLEilRuPL83arxxPxXyGug2cJD4LPUp7tpbOEZPZxlFvpA5XJ1AGQGd2vHEwNnqekxB3Q+48DoZnVcEE1dnIFik4dHgX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706037441; c=relaxed/simple; bh=a4D7Gvm3E3IKOqSNk13QoOG/5s/jLnUCyPtJuWQkTL0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ehFCkLhFDWKfEg6Cu1EAVV+zTgBPZKAqamJ1WrQvn5vxlD6Tm0BEs4untGxKp/1dn6FeoCfdyiolWDvngeW+MTYClFhg2RTPex3iSZTARR0/jqLNOeJ6MF9Iy7wHt4hqAhxZkVXskKNl1M4EEihN/hbw72qE9r2FmmqNJgMmnpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gvkCVxj9; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706037439; x=1737573439; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=a4D7Gvm3E3IKOqSNk13QoOG/5s/jLnUCyPtJuWQkTL0=; b=gvkCVxj9S93K6KWDy9/NLLI7dA/iLRha2eroai1V+pe68wY1jx1EvG/g Z3oy20/owy8fEjbl8ZyllGMITV5He323KoSb1nqjE+1HAU+MjWdr1QWA9 +eW/tnPfN8JXVPYufitZ0v18nOOd76yoIJH6JiV9vlDRALfp2RAZWRlOO 3Atp3AfWdu5/Oy4AcgMEHSWYhF6QCljaMW7NrmVoHqlh2oCpFEtvC7nl6 wh/MIug1ryldTf9mdsUd2/mPMyYcfj4RpxV2qxlbSMUcLUIVMGldi1eDX eF8g2Rvmqk4dkTunMKdBHoGJLf8G/lWIpZWaIdur31kvqe4k9bt1B0kWn A==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="15143551" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="15143551" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 11:17:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="929429114" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="929429114" Received: from pzsolt-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.40.183]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 11:17:15 -0800 From: Jani Nikula To: Thomas Zimmermann , javierm@redhat.com, chenhuacai@kernel.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thorsten Leemhuis , Thomas Zimmermann , Jaak Ristioja , Huacai Chen Subject: Re: [PATCH] Revert "drivers/firmware: Move sysfb_init() from device_initcall to subsys_initcall_sync" In-Reply-To: <874jf4nmgp.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240123120937.27736-1-tzimmermann@suse.de> <874jf4nmgp.fsf@intel.com> Date: Tue, 23 Jan 2024 21:17:13 +0200 Message-ID: <871qa7n9l2.fsf@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, 23 Jan 2024, Jani Nikula wrote: > On Tue, 23 Jan 2024, Thomas Zimmermann wrote: >> This reverts commit 60aebc9559492cea6a9625f514a8041717e3a2e4. >> >> Commit 60aebc9559492cea ("drivers/firmware: Move sysfb_init() from >> device_initcall to subsys_initcall_sync") messes up initialization order >> of the graphics drivers and leads to blank displays on some systems. So >> revert the commit. >> >> To make the display drivers fully independent from initialization >> order requires to track framebuffer memory by device and independently >> from the loaded drivers. The kernel currently lacks the infrastructure >> to do so. >> >> Reported-by: Jaak Ristioja >> Closes: https://lore.kernel.org/dri-devel/ZUnNi3q3yB3zZfTl@P70.localdomain/T/#t >> Reported-by: Huacai Chen >> Closes: https://lore.kernel.org/dri-devel/20231108024613.2898921-1-chenhuacai@loongson.cn/ >> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10133 > > FWIW, > > Acked-by: Jani Nikula > > but would be great to get a Tested-by from Jaak or from the gitlab issue > reporter. The revert works for the gitlab issue reporter. BR, Jani. -- Jani Nikula, Intel