Received-SPF: pass (google.com: domain of linux-kernel+bounces-36038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Sender: Tejun Heo <htejun@gmail.com>
Date: Tue, 23 Jan 2024 10:46:33 -1000
From: Tejun Heo <tj@kernel.org>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: willy@infradead.org, akpm@linux-foundation.org,
	hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix and cleanups to page-writeback
Message-ID: <ZbAlqdwNv_uxnKT1@slm.duckdns.org>
References: <20240123183332.876854-1-shikemeng@huaweicloud.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240123183332.876854-1-shikemeng@huaweicloud.com>

On Wed, Jan 24, 2024 at 02:33:27AM +0800, Kemeng Shi wrote:
> This series contains some random cleanups and a fix to correct
> calculation of cgroup wb's bg_thresh. More details can be found
> respective patches. Thanks!
> 
> Kemeng Shi (5):
>   mm: enable __wb_calc_thresh to calculate dirty background threshold
>   mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh
>   mm: call __wb_calc_thresh instead of wb_calc_thresh in
>     wb_over_bg_thresh
>   mm: remove redundant check in wb_min_max_ratio
>   mm: remove stale comment __folio_mark_dirty

I don't have the fifth patch in my inbox and I find the patchset difficult
to review because it's changing subtle behaviors without sufficient
justifications or concrete cases which motivated the changes. For now, I
think it'd be prudent to not apply this patchset.

Thanks.

-- 
tejun