Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp735705rdb; Tue, 23 Jan 2024 13:20:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEByeHhmOhfZ+VScu/IIyEHKEp0WFkGSAHQ9dykLZHKBQ2hOFf9Hztx5bEvYG4e4VExgnzB X-Received: by 2002:a17:903:40d1:b0:1d7:5ecb:b018 with SMTP id t17-20020a17090340d100b001d75ecbb018mr3587887pld.57.1706044836988; Tue, 23 Jan 2024 13:20:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706044836; cv=pass; d=google.com; s=arc-20160816; b=KHo923sMbBKuVOPBnZiozYquxFe9BpKCuNsGasD4rm7zZ7RY6PzkU0BzR4ECQvaH0w TslS902FIoPE2PsmoLppIBfMBUyXTjWAQb9CzuRyi2CBeBC2EJnsZJPlJI/iGlY2e8TY JBN4vL6vMUE1GJjAk20g7pT4OQTYN2LBrKvK+SD5JbpABC+/XLIT7bo47XLSEP9JGTFs EEjfNk+iAvqjsF9lUSiatARf59EnNBy1osnmvr2n8z+YIIG3kkY4mY/i0RGG0Vt7XX+Z uxzChFoi9AZ8UAiM1EjaW6M3WCBzorajUvRvKrjL8A9Nx4XrOU0dUgyYwM5q00GoDmjv 6EHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+LOWtolt7y+KJAN1QYznwoNgWUtDvoht/BbgXsXbBVI=; fh=lwCpI1Oe+KwIP/F9R5wf1MK1kLy9lQTFE9bXeOGRRoQ=; b=Mw83YALVyz7M0CfIld/whsxFPZChkLQ3y6fDjdtkFr5zsffft/CmQLiXn1KG0u6C3K 46zjAEoIUReZYAeStcSQ5tgg8+Iky4bSUp+2PQfCOt5gbpSmYaYbxM0FRXT2Am4a6Hpd 0OU9ywSY7PtIgZyJuNQG2ce1MA/ZhbSBdcUu6yWDOeofydkXwagui9Jvpsb1D/y4wOWa p6AB9EbxUiVVDEeFjOwShRrZghHcTiTrZn/5Ak3VSm9tF6Si1nAdwuCdqSbu5fXYCfcc R2JQt82+XdCmQ8UO+5c1llzv7Uf4dWawqGiLikz5SVEMP1BFPhPeMK24MuuUNoQ9X5LG vvAw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=j0OSgq+8; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-36048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id l7-20020a170902f68700b001d72b7d110bsi6826208plg.321.2024.01.23.13.20.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 13:20:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=j0OSgq+8; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-36048-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DE8EAB226C6 for ; Tue, 23 Jan 2024 20:58:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89A0663B2; Tue, 23 Jan 2024 20:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j0OSgq+8" Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80ECF3B199; Tue, 23 Jan 2024 20:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706043492; cv=none; b=hlAqTtHUDsDsQ94PpfUfQtR/LDG8XXdluCwB3tzHUKMQ0CDLlLFA7eC+H6yDjjcU6I5oEy0AVd5PgrhV7PeXIlTgrSe+jDYbSjF+dZapDByHhutr5Kor8iK28k/bQtGirfYrMrul4nGLidx5QFTQ2JEmdbPJNpbZvII+fi8Xxuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706043492; c=relaxed/simple; bh=+LOWtolt7y+KJAN1QYznwoNgWUtDvoht/BbgXsXbBVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=L7q3JUXahVyhHocbhzO9OybDKsg+bFVoVsMuqLFchg204pdrDECVkVZF8xtXF9oOqDuzotH659gkbxbTYImEzQgvMQYe27a+UNbayT3tCI4uYR3mfuUdeCXN+Bce0oVTa/WPwE7g7og3QTfLUustX6g91czVvK9EnxDdR/0E0Us= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j0OSgq+8; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40e7065b7bdso56743505e9.3; Tue, 23 Jan 2024 12:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706043489; x=1706648289; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+LOWtolt7y+KJAN1QYznwoNgWUtDvoht/BbgXsXbBVI=; b=j0OSgq+86vyTL65C7cnBsPrO8OaMWWHABCMfBpdlMIo7lupehkMF/9DUv+5OmF1On2 2TRsILZlXBY7Btdg18RWQ48ogBX1uaBwv4wxYsq2JU6bo39rt3kM0eQrTx+Ryz9zoahH 6QHA2UQ+o3LRa7KWIx0RAv+M77sKvmBLGQQoAMRIMskF8ZBGr4Ywzz9dm1VfKLhvhB+l ++Wi8ThZCwiyv9UOLg3om1yfeAs0uU7bI1DBv/0v1GBHBlc+lCwy8l6N2CIGvbS9gOqd 2y0pCliGQLk944OS/hAv0jSkcrAJ74pS3o/6kNgL1uObFZ7pf/XcCWJsesebZdJlq+8a ZLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706043489; x=1706648289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+LOWtolt7y+KJAN1QYznwoNgWUtDvoht/BbgXsXbBVI=; b=lYmyuamchfGd1qppwGXRh0mvPhLj3btoM3vFvuSgY3MmF2OJ6HBUWKFB/4+Y/UajN4 ji/XRpRSa+Gyhw2DvdYJuBnvTYLlW0U3yo0w2ZDvtmBpAxB4H4tWGb9DGLLKYEJvstBz M9kfvF38jmp82zy8IvvNVtDde9HRKVxA2SIfs1ebkxl8SYYNDFsW9K6HkjsJgj5pSoxO zB6N5Bd/rDZMWuMMh2eCQ+KHxRtrs10Gru+9+Z2dHWVgMRcRe3Dbvv05qddVgjnU0pbd /ENRjZ5tXmUqKEq2dqNxev99xSUCERAyX1BGM4zMgjcN4kEBwN+3iGZtn6bVWviwRs38 sBLg== X-Gm-Message-State: AOJu0YwX1AN8/b37+eqjE+0EHUl/WBlNOe0LIPaUrgDhe3yF7UrmUajU 22bookQFZ+5L0fTF4Mm/xGCwvPAJg57ZRgaA3aVsdhL+onvrw1062xxk75Yw X-Received: by 2002:a05:600c:3caa:b0:40e:9ef9:838d with SMTP id bg42-20020a05600c3caa00b0040e9ef9838dmr325295wmb.159.1706043488748; Tue, 23 Jan 2024 12:58:08 -0800 (PST) Received: from jernej-laptop.localnet (86-58-14-70.dynamic.telemach.net. [86.58.14.70]) by smtp.gmail.com with ESMTPSA id q20-20020a05600c46d400b0040e395cd20bsm47421305wmo.7.2024.01.23.12.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 12:58:08 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-kernel@vger.kernel.org, Randy Dunlap Cc: Randy Dunlap , Emilio =?ISO-8859-1?Q?L=F3pez?= , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Chen-Yu Tsai , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] clk: sunxi: a20-gmac: fix kernel-doc warnings Date: Tue, 23 Jan 2024 21:58:07 +0100 Message-ID: <3464017.QJadu78ljV@jernej-laptop> In-Reply-To: <20240121051837.17564-1-rdunlap@infradead.org> References: <20240121051837.17564-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Dne nedelja, 21. januar 2024 ob 06:18:35 CET je Randy Dunlap napisal(a): > Move the function kernel-doc comment to be immediately before the > function implementation, then add a function parameter description > to prevent kernel-doc warnings: >=20 > clk-a20-gmac.c:43: warning: expecting prototype for sun7i_a20_gmac_clk_se= tup(). Prototype was for SUN7I_A20_GMAC_GPIT() instead > clk-a20-gmac.c:53: warning: Function parameter or struct member 'node' no= t described in 'sun7i_a20_gmac_clk_setup' >=20 > Signed-off-by: Randy Dunlap > Cc: Emilio L=F3pez > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Samuel Holland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev Merged, thanks! Best regards, Jernej