Received-SPF: pass (google.com: domain of linux-kernel+bounces-36076-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240123212135.2607178-1-dlechner@baylibre.com>
In-Reply-To: <20240123212135.2607178-1-dlechner@baylibre.com>
From: David Lechner <dlechner@baylibre.com>
Date: Tue, 23 Jan 2024 15:27:21 -0600
Message-ID: <CAMknhBHtcPSVHikL4AWscFcLNKWO33rT77Ed7mkRYqpaBfBvsw@mail.gmail.com>
Subject: Re: [PATCH] wifi: wilc1000: remove setting msg.spi
To: Kalle Valo <kvalo@kernel.org>
Cc: Ajay Singh <ajay.kathat@microchip.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>, 
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024 at 3:22=E2=80=AFPM David Lechner <dlechner@baylibre.co=
m> wrote:
>

Not sure what happened with git send-email, but most of the commit
message seems to have disappeared. This should have included the
following:

```
Calling spi_sync() unconditionally sets the spi field of struct
spi_message. Therefore setting msg.spi =3D spi before calling spi_sync()
has no effect and can be removed.
```

I can resend if there are no further comments.

> (spi_message_add_tail() does not access this field.)
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  drivers/net/wireless/microchip/wilc1000/spi.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/wireless/microchip/wilc1000/spi.c b/drivers/net/=
wireless/microchip/wilc1000/spi.c
> index 77b4cdff73c3..7eb0f8a421a3 100644
> --- a/drivers/net/wireless/microchip/wilc1000/spi.c
> +++ b/drivers/net/wireless/microchip/wilc1000/spi.c
> @@ -300,7 +300,6 @@ static int wilc_spi_tx(struct wilc *wilc, u8 *b, u32 =
len)
>
>                 memset(&msg, 0, sizeof(msg));
>                 spi_message_init(&msg);
> -               msg.spi =3D spi;
>                 spi_message_add_tail(&tr, &msg);
>
>                 ret =3D spi_sync(spi, &msg);
> @@ -343,7 +342,6 @@ static int wilc_spi_rx(struct wilc *wilc, u8 *rb, u32=
 rlen)
>
>                 memset(&msg, 0, sizeof(msg));
>                 spi_message_init(&msg);
> -               msg.spi =3D spi;
>                 spi_message_add_tail(&tr, &msg);
>
>                 ret =3D spi_sync(spi, &msg);
> @@ -381,8 +379,6 @@ static int wilc_spi_tx_rx(struct wilc *wilc, u8 *wb, =
u8 *rb, u32 rlen)
>
>                 memset(&msg, 0, sizeof(msg));
>                 spi_message_init(&msg);
> -               msg.spi =3D spi;
> -
>                 spi_message_add_tail(&tr, &msg);
>                 ret =3D spi_sync(spi, &msg);
>                 if (ret < 0)
> --
> 2.43.0
>