Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp739974rdb; Tue, 23 Jan 2024 13:31:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKgkITc1owanf1vQa3ye7jBYCqJqfNB53Qp7SBVvdnQDM1tbR+Jp/4qKgjnrcuKbS/3IjS X-Received: by 2002:a17:90b:251:b0:28b:8e2d:4131 with SMTP id fz17-20020a17090b025100b0028b8e2d4131mr2801894pjb.31.1706045483174; Tue, 23 Jan 2024 13:31:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706045483; cv=pass; d=google.com; s=arc-20160816; b=kVtESb5OxhwaHcOAM29Ef0gY+Bbv/Gs1wkHJ5p6UCzm/M1/TrLZhOxYEd+M4awFWDb 2x7dTyS/1scW3zZkDHQj3iy8IRRkobhoV626KVJz0tQEWqkFfSR8Xfv6VEIrgIWRAO0i s/Zp3LIaNEHMRBEiX71Q9Rt/N+YIEiX4lpWKQvPbyqEBA9UcsRXesg+Q6CLsYALMiqZJ 53ulusHOPjNZVs4bcWEpJFJgX1OR9vgLD75XkOhKoFVY2pP51MJVHYFLCMLF6V8KRxDf jR+fXCgnt4fbEM1qFqmQLk9OGqDWiAPHiZvhC6dDEA89XxeJL5UJnMfLyJswCrTAk75Q bl3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cLSrHTqApY0rnoNDPNmTbGyM4UlT798vTtkhFOVuGO8=; fh=SsYO6XJn9alYV/FqWD4irWDEarj/SCu+q/Ym720nmWk=; b=AR7kGy+TZZkblDTXjtHowaElUkhah3lK11GopZJ8Tym3A9JM7o/XvTMAMbaPBQjuPI MPXan/BvAYtWSmVMaiWvNAfDBA+y9trzABslz/zElXDITG5bsfeWWtM+3DssG0PWPNfl 5FuG8/ISCAOH7XcSucPRcKh2z28jfg1UijNX8d9X2aF35EiHoFXuMyB4REzlgnS8/TeS 5XWlEYFonKibkzdLJD1JGTeQDPWkD18H8XhUkkhmoNJRpasH4NoejljqwyKS01MmdCA+ UEH2FKqozFEzySIBWqcJwJjVtsqC9IBl5hXxPkalMukCFCLEdMzoioTamSZE3j6cMd3c oJag== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ad60CBuj; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-36079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36079-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ng13-20020a17090b1a8d00b00290d31ce53csi1486149pjb.1.2024.01.23.13.31.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 13:31:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-36079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ad60CBuj; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-36079-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-36079-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CD719282D73 for ; Tue, 23 Jan 2024 21:31:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 56EAC3BB38; Tue, 23 Jan 2024 21:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ad60CBuj" Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F2052C682 for ; Tue, 23 Jan 2024 21:31:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706045474; cv=none; b=WEIGmARkw1EDE+kw4vBSrWpudEsFFBv2aItUaLmoGnoksWPcKhnOtH9q9ygFIAvIqU51Yzy3GtsnOX53CUPHN/TZPD1TIRkOY4xMWqzmD2gLxX5dYJ6TAajIzzurQ9QBMYMyR+CsdldHtqR7awIRJKTWNWsaU+qVJPm2J1WMtcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706045474; c=relaxed/simple; bh=jP2/IW9UNkEjSgAKZeY0ax+X34XlCZzhZYmXu4icG+o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bt5u7gyag6PhZ4Q1trldtWqLo2iFa2ZV79Rf8flpGWtg0Xz9YmeZ4xSV8qY6d1HBzPwSeWeXCKBOtnS7ol+HZzy3jkEYS4XS2LnGFoVJ44/WJkTYQpQJrGELoW5KcAso7QvHCMobBhhFCr4LsKCKdCcY95h8hjS9Li3UBqUt3d4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Ad60CBuj; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5ce07cf1e5dso2681789a12.2 for ; Tue, 23 Jan 2024 13:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1706045472; x=1706650272; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cLSrHTqApY0rnoNDPNmTbGyM4UlT798vTtkhFOVuGO8=; b=Ad60CBujlqu06M2IFBbPXvjYD8g/BEXRejYj+DNvOwe8wY8n5vBoew7hrTl/u+VcTX Mw1Suq5x7dhwT8+Kg1UpTRVofpgjJnrHYr6gl+HBY//ZZHbqrNqMWfVbigTZJZHXagmU rnCo70Rr5QxK6vUJfK1EJi4krFDpBRl+2UwKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706045472; x=1706650272; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cLSrHTqApY0rnoNDPNmTbGyM4UlT798vTtkhFOVuGO8=; b=ediMbpM2NQ7+7gRMfWODEs8BfsP/N+sOCpZTyuOUyYQrbDP82BKMgkkdiR4cTorvwi uPM2LsNQDDsCiZds7WSSK6GcvBXZkw3VydQrOKxQWs/fOPygf2VoSZktlBBq2GrHv7yO CY84TWrvhgfgWrGhAyo55IOf5AIgg+ZIr8lGH+Iy6Ci0Up3Yv3UhQOAxw9niYrloG5hS az4ugW7rRaSOHU6aGcxnWL7IcF3HxDUFDnTYTP7A4MdUCWAuNjOx7aLyq/4ucr1xkFRQ yVxzwo3ybegJZj4DybqMDnnusMojClGxKvCIcPQWaBcXPuTAphjwJMvCR8j/48SqnWAe imng== X-Gm-Message-State: AOJu0YwYCN+Hi5s7V9/JgwdQyWX/hPyn9qKGi/GkCmUMYscIMB4RXeNL oK5fwQaoLluyQPIDx11YjGIqoqyV7AQUelCVFc2ig+IVyDgfYsTvhI3EnNCBqDtg4J1GEvj6Mam 5RQ== X-Received: by 2002:a05:6a20:28a1:b0:19a:3a7f:63cd with SMTP id q33-20020a056a2028a100b0019a3a7f63cdmr3098127pzf.49.1706045472672; Tue, 23 Jan 2024 13:31:12 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id kr8-20020a056a004b4800b006da73b90fe4sm12541675pfb.14.2024.01.23.13.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 13:31:12 -0800 (PST) Date: Tue, 23 Jan 2024 13:31:11 -0800 From: Kees Cook To: Adrian Hunter Cc: linux-hardening@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , John Garry , Fangrui Song , linux-perf-users@vger.kernel.org, "Gustavo A. R. Silva" , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 69/82] perf tools: Refactor intentional wrap-around test Message-ID: <202401231330.C55D17922@keescook> References: <20240122235208.work.748-kees@kernel.org> <20240123002814.1396804-69-keescook@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 23, 2024 at 08:21:41AM +0200, Adrian Hunter wrote: > perf tools has separate includes to the kernel, so does not > seem to include add_would_overflow() in any of its include > files at this point. Need to update > tools/include/linux/overflow.h first. Oops, thank you! I will adjust this. -- Kees Cook