Received-SPF: pass (google.com: domain of linux-kernel+bounces-36105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Jan 2024 23:01:30 +0100
From: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>
To: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, 
	Alain Volmat <alain.volmat@foss.st.com>, Pavel Machek <pavel@ucw.cz>, 
	Arnaud Ferraris <arnaud.ferraris@collabora.com>
Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: Add front/back cameras
Message-ID: <rkx4iuuudkk7iaaudmr3ccwpatps7kz2qyjalcfzp4ongmbaby@rcosajd6c746>
Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>, 
	Andrey Skvortsov <andrej.skvortzov@gmail.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, 
	Alain Volmat <alain.volmat@foss.st.com>, Pavel Machek <pavel@ucw.cz>, 
	Arnaud Ferraris <arnaud.ferraris@collabora.com>
References: <20240123214729.2852346-1-andrej.skvortzov@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240123214729.2852346-1-andrej.skvortzov@gmail.com>

Hi Andrey,

On Wed, Jan 24, 2024 at 12:47:29AM +0300, Andrey Skvortsov wrote:
> From: Ondřej Jirman <megi@xff.cz>
> 
> Pinephone has OV5640 back camera and GC2145 front camera. Add support
> for both.

The upstream driver doesn't support multiple endpoints per port. See:

https://elixir.bootlin.com/linux/v6.8-rc1/source/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml#L43

Only one endpoint is allowed/supported. Looking throught LKML, I don't
see the support for multiple parallel interface endpoints being added
recently...

So this patch will not work, and will cause DTS validation errors.

Kind regards,
	o.

> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> ---
>  .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 91 +++++++++++++++++++
>  1 file changed, 91 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index 87847116ab6d..4104a136ff75 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -36,6 +36,15 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	i2c_csi: i2c-csi {
> +		compatible = "i2c-gpio";
> +		sda-gpios = <&pio 4 13 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; /* PE13 */
> +		scl-gpios = <&pio 4 12 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; /* PE12 */
> +		i2c-gpio,delay-us = <3>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  
> @@ -124,6 +133,36 @@ &cpu3 {
>  	cpu-supply = <&reg_dcdc2>;
>  };
>  
> +&csi {
> +	pinctrl-0 = <&csi_pins>, <&csi_mclk_pin>;
> +	status = "okay";
> +
> +	port {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		csi_ov5640_ep: endpoint@0 {
> +			reg = <0>;
> +			remote-endpoint = <&ov5640_ep>;
> +			bus-width = <8>;
> +			hsync-active = <1>; /* Active high */
> +			vsync-active = <0>; /* Active low */
> +			data-active = <1>;  /* Active high */
> +			pclk-sample = <1>;  /* Rising */
> +		};
> +
> +		csi_gc2145_ep: endpoint@1 {
> +			reg = <1>;
> +			remote-endpoint = <&gc2145_ep>;
> +			bus-width = <8>;
> +			hsync-active = <1>;
> +			vsync-active = <1>;
> +			data-active = <1>;
> +			pclk-sample = <1>;
> +		};
> +	};
> +};
> +
>  &dai {
>  	status = "okay";
>  };
> @@ -158,6 +197,58 @@ &ehci1 {
>  	status = "okay";
>  };
>  
> +&i2c_csi {
> +	gc2145: front-camera@3c {
> +		compatible = "galaxycore,gc2145";
> +		reg = <0x3c>;
> +		clocks = <&ccu CLK_CSI_MCLK>;
> +		clock-names = "xclk";
> +		avdd-supply = <&reg_dldo3>;
> +		dvdd-supply = <&reg_aldo1>;
> +		iovdd-supply = <&reg_eldo3>;
> +		reset-gpios = <&pio 4 16 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; /* PE16 */
> +		powerdown-gpios = <&pio 4 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; /* PE17 */
> +		rotation = <270>;
> +		orientation = <0>;
> +
> +		port {
> +			gc2145_ep: endpoint {
> +				remote-endpoint = <&csi_gc2145_ep>;
> +				bus-width = <8>;
> +				hsync-active = <1>;
> +				vsync-active = <1>;
> +				data-active = <1>;
> +				pclk-sample = <1>;
> +			};
> +		};
> +	};
> +
> +	ov5640: rear-camera@4c {
> +		compatible = "ovti,ov5640";
> +		reg = <0x4c>;
> +		clocks = <&ccu CLK_CSI_MCLK>;
> +		clock-names = "xclk";
> +		AVDD-supply = <&reg_dldo3>;
> +		DOVDD-supply = <&reg_aldo1>; /* shared with AFVCC */
> +		DVDD-supply = <&reg_eldo3>;
> +		reset-gpios = <&pio 3 3 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>; /* PD3 */
> +		powerdown-gpios = <&pio 2 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; /* PC0 */
> +		rotation = <90>;
> +		orientation = <1>;
> +
> +		port {
> +			ov5640_ep: endpoint {
> +				remote-endpoint = <&csi_ov5640_ep>;
> +				bus-width = <8>;
> +				hsync-active = <1>; /* Active high */
> +				vsync-active = <0>; /* Active low */
> +				data-active = <1>;  /* Active high */
> +				pclk-sample = <1>;  /* Rising */
> +			};
> +		};
> +	};
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  
> -- 
> 2.43.0
>